Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676544 Rahul Sundaram <methe...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |methe...@gmail.com --- Comment #1 from Rahul Sundaram <methe...@gmail.com> 2011-02-10 23:30:20 EST --- I am not a sponsor and hence cannot approve but I will do a review. You do not need to define a buildroot or have a %clean section any longer in the spec file. These are defined by RPM automatically. Also you the license tag in the spec says GPLv2+ but the logplugin.c under src directory which is the only source file has a copyright notice that says: -- /* Improved Log Viewer for Pidgin. * Tirtha Chatterjee * This code is licensed under GPL v2 */ --- You need to talk to upstream on whether this is just GPLv2 or whether it is GPLv2 or later. The plan for the author is to eventually merge this into Pidgin and hence I think GPLv2 is preferable but do confirm first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
