Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676544 --- Comment #6 from Martin Gieseking <martin.giesek...@uos.de> 2011-02-15 03:41:52 EST --- The BuildRoot field is still present (below Source0). Please remove it. I suggest to add the svn revision number to the Release tag. This helps to identify the exact sources used to build the package: Release: 3.20110208svn13%{?dist} Some (optional) cosmetic enhancements: - You could shorten the Summary a bit, e.g. "User-friendly and intuitive chat log viewer for Pidgin" - Please capitalize "Pidgin" in the %description (2nd sentence). Besides that the package looks good now and works properly. $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm pidgin-logviewer.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging pidgin-logviewer.src: W: invalid-url Source0: pidgin-logviewer-0.2.tar.gz pidgin-logviewer.x86_64: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging 3 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
