https://bugzilla.redhat.com/show_bug.cgi?id=2434126
--- Comment #4 from Ben Beasley <[email protected]> --- (In reply to Gwyn Ciesla from comment #3) > Thank you, addressed everything, same URLS. Thanks. The dos2unix invocation in %prep looks right, but BuildRequires: dos2unix is missing. You can get that by making sure that [requires] build = ["dos2unix"] is present in rust2rpm.toml. > Not sure how to handle the duplicate files in this situation. Something like the following is produced by fedora-review on every Rust library package: - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/either_n-0.2.0/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files I *meant* to write the following: OK: not a serious problem; due to reasonable design decisions in rust2rpm.toml This is a duplicate listing, not a duplicate installed file; it causes no harm in practice; and avoiding the diagnostic would make all rust2rpm-generated spec files messier. Nothing needs to be changed here. > Filed: > https://github.com/cramertj/EitherN-rs/issues/1 Thanks! I’ll keep an eye on this and be ready to re-review once there’s a submission with MIT license text included. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2434126 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202434126%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
