https://bugzilla.redhat.com/show_bug.cgi?id=2524750
--- Comment #6 from Jeremy Cline <[email protected]> --- Great, this looks almost perfect. The only minor issue is that now the Source points to your personal fork, which isn't exactly wrong, but confusing. It's okay for it to not point to the upstream GitHub release and just be something like "azure-protected-vm-secrets-subtree.tar.gz" (e.g. not a URL at all) or something, as long as you also provide a shell script to process the upstream release. When we import the package into Fedora we upload the tarball to the lookaside cache with `fedpkg new-sources` the sources don't need to be accessible via a URL directly. It would be ideal if the upstream repo itself did the same immutable release you did, but a shell script we check into the repo that automatically produces a subtree tarball from an upstream release is also acceptable. Since this is your first package, I know you also need a sponsor and I am happy to be your sponsor. Before I sponsor you, though, can you perform two practice package reviews? The list of packages in need of review is at https://fedoraproject.org/PackageReviewStatus/reviewable.html - I recommend you pick something recently filed. It's meant to demonstrate you're familiar with the packaging guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines) and review tools, so picking packages that are straightforward and relatively simple is best. When you post your review, prefix it with a note that it's a practice review and not an official review. In a "real" review you also set the bugzilla fedora-review flag to +, which you won't do during your practice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2524750 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202524750%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
