https://bugzilla.redhat.com/show_bug.cgi?id=2524750
Jeremy Cline <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #10 from Jeremy Cline <[email protected]> --- (In reply to aashishjha from comment #7) > > Source0 is now a bare filename (%{name}-%{version}.tar.gz) rather than a > URL, to be uploaded to the lookaside cache with fedpkg new-sources at import > time. I've also checked a generator script into the packaging dir — > packaging/fedora/generate-source-tarball.sh — that reproduces the subtree > tarball from the upstream release tag (git archive of just the > azure-protected-vm-secrets/ component, so it stays MP4-free and ~150 KB). > It's included in the SRPM. Thanks, now that the specfile has an ExclusiveArch: directive and a tarball without that MP4 file, I'm comfortable approving the package. One note regarding the tarball: I see you checked it into the upstream repository, which is a bit unfortunate. You'll likely want to remove it from there as future releases will cause the Fedora tarball to have that tarball within its tarball. We can generate the tarball downstream (or upstream can make release artifacts with the tarball) but we don't want to check the tarball into any git repos. > > For the sponsor I would love to do that and learn about the process however, > I might not be able to pick it up anytime soon. Will that be a blocker for > this package approval and sponsoring? It's not a blocker for the package approval. I know you're out of office a couple of months and someone else on the team is covering for you, so it's mostly about figuring out how best to map that into Fedora's requirements for sponsoring (https://docs.fedoraproject.org/en-US/fesco/Packager_sponsor_policy/#requirements). I feel reasonably confident in your abilities given this package submission and the discussions we've had, so how about I sponsor you under the condition you'll perform a couple practice package reviews on your return? You can also make me the co-maintainer of the package and I can work with Anirudh to ensure they're comfortable with the package maintainer policies and responsibilities, and then they can be sponsored as a co-maintainer of the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2524750 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202524750%23c10 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
