Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756443 Volker Fröhlich <volke...@gmx.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volke...@gmx.at --- Comment #1 from Volker Fröhlich <volke...@gmx.at> 2011-12-09 08:27:11 EST --- According to the files, license is GPLv3+, not GPLv3 rm -rf %{buildroot}/*, clean section and buildroot definition are not necessary, if you're not aiming for EPEL 5: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag Defining sitearch or sitelib is only necessary for EPEL 5 as well, see http://fedoraproject.org/wiki/Packaging:Python The if clause for Suse is no use in Fedora. I guess you're trying to keep a single spec for Suse and Fedora. I don't know Suse's guidelines, but that might not work. Don't install the documentation on your own. Only use %doc in the files section: http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation FSF postal address is wrong: [makerpm@desktop SPECS]$ rpmlint /home/makerpm/rpmbuild/RPMS/noarch/cagraph-1.2-7.fc16.noarch.rpm cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/axis/taxis.py cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/cagraph-1.2/examples/example99.py cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/cagraph-1.2/examples/example6.py cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/axis/xaxis.py ... Please contact the developers on that and feel free to correct it. I think this package should have "python" in the name: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 I suppose you can use a single chmod to change all the py file's permissions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
