Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769056 Veeti Paananen <veeti.paana...@rojekti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veeti.paana...@rojekti.fi --- Comment #5 from Veeti Paananen <veeti.paana...@rojekti.fi> 2011-12-27 12:25:43 EST --- Hi! Just a few comments/suggestions: - You could use a macro in the Source0 line: replace the hardcoded version number with %{version} so that you don't need to update it in two places later. - Do you plan on maintaining this package on EPEL5? If yes, add the BuildRoot as instructed in http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies . Otherwise you can drop the rm -rf %{buildroot} from the beginning of %install, since it's done automatically in newer versions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
