Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769056 --- Comment #6 from Athmane Madjoudj <athma...@gmail.com> 2011-12-27 13:37:30 EST --- (In reply to comment #5) > Hi! > > Just a few comments/suggestions: > > - You could use a macro in the Source0 line: replace the hardcoded version > number with %{version} so that you don't need to update it in two places > later. > Fixed, it was a mistake when I was testing. > - Do you plan on maintaining this package on EPEL5? If yes, add the BuildRoot > as instructed in http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies . > Otherwise you can drop the rm -rf %{buildroot} from the beginning of %install, > since it's done automatically in newer versions. I'm not planing to support epel5, so I've removed rm -rf %{buildroot} from %install Thanks for your suggestions. Spec URL: http://athmane.fedorapeople.org/pkgs/wbox.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/wbox-5-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
