Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728302 --- Comment #15 from Rex Dieter <rdie...@math.unl.edu> 2012-01-07 09:48:03 EST --- some more now, 6. Licensing. using licensecheck too, seems all files include the gpl 'or later' clause, so we can go with License: GPLv2+ 7. use the included configure script (esp to control build options, see 8). unless there's some good reasons not to, and if so, please document them in a .spec comment 8. bundled libraries in third_party, to better ensure they're not used, add build options: --with-external-speex --with-external-gsm --with-external-pa will require additional BuildRequires for each of these, like BuildRequires: speex-devel BuildRequires: gsm-devel BuildRequires: portaudio-devel respectively (there's other stuff in there that requires more scrutiny, but this is a good first effort) 9. document in %build section comment that %{?_smp_mflags} cannot be used 10. drop/omit empty main pkg, ie, remove %files and only do %files devel ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
