Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728302

--- Comment #17 from Rex Dieter <rdie...@math.unl.edu> 2012-01-07 15:07:17 EST 
---
Excellent!

I'm reviewing the remaining third_party bits.


in the meantime, one piece of advice, I see stuff like
%files devel
%dir %{_includedir}/pj++/
%{_includedir}/pj++/*.hpp

you can simplify these 2 down to 1 line:
%{_includedir}/pj++/

(listing a directory will own it, and recursively everything under it)
which, for me at least, is simpler and easier to read.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to