Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811418 --- Comment #1 from Bohuslav "Slavek" Kabrda <bkab...@redhat.com> 2012-04-16 05:02:56 EDT --- - Are you planning to use this gem in EPEL, too? Because if yes, you will have to define the macros conditionally. Otherwise, please remove the defattr lines, see [1]. - The %{docdir} and TODO in doc subpackage should be marked as %doc, to distinguish them from other files in this subpackage, that are not documentation. - I think you should exclude the .document file, it doesn't contain anything useful. - For any other gem, I would tell you to run the test suite, but since it requires passwordless login on localhost [2], it would be pain to get it working and it probably wouldn't even work on koji. - Please fix these rpmlint warnings (make the files executable): rubygem-hydra-doc.noarch: E: non-executable-script /usr/share/gems/gems/hydra-0.24.0/test/fixtures/many_outputs_to_console.rb 0664L /usr/bin/env rubygem-hydra-doc.noarch: E: non-executable-script /usr/share/gems/gems/hydra-0.24.0/test/fixtures/hello_world.rb 0664L /usr/bin/env [1] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions [2] https://github.com/ngauthier/hydra/wiki/development-environment -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
