Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811418 --- Comment #5 from Bohuslav "Slavek" Kabrda <bkab...@redhat.com> 2012-04-25 02:36:58 EDT --- Hi Matt, this looks really good now, however there is a small issue: On RHEL 7, we will already have rubygems-devel and rubyabi 1.9.1. So I'd advise you to use conditionals like this one: %if 0%{?rhel5}%{?rhel6} Please note that you cannot use this: %if 0%{?rhel} <= 6 because it would always evaluate to true on Fedora. Also, there is one small needles Requires: rubygems in the %{?rhel} section. Otherwise the package looks good, so once you fix these two minorities, I will approve it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
