Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809882 --- Comment #6 from Michael Scherer <m...@zarb.org> 2012-04-27 16:21:14 EDT --- You have uploaded the bnary rpm instead of the src.rpm, and that's required to run fedora-review , and sorry, did forgot I started this review :/ For %defattr, this is no longer needed on newer rpm version. %clean will default to rm -Rf $RPM_BUILD_ROOT, or something like that, so this can be removed too in new distribution ( can be kept of course ). And that's the same for the rm just at the %install, it is done by default nowadays. - I think the email address is likely wrong ( unless me and LDAP missed a memo ) - Guidelines also requires ( IIRC ) to ship the license file if present, or to ask to upstream to ship it if not. ( so that's the 2nd case here, so i just remind gently to do so :) ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
