Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809882 --- Comment #7 from Tim Bielawa <tbiel...@redhat.com> 2012-04-30 12:40:51 EDT --- (In reply to comment #6) > You have uploaded the bnary rpm instead of the src.rpm, and that's required to > run fedora-review , and sorry, did forgot I started this review :/ Sorry about that, I uploaded both RPMs and linked the binary instead of the SRPM. Fixed that now: http://people.redhat.com/~tbielawa/ansible/ansible-0.3-1.fc16.src.rpm Also, uploaded the new spec file: http://people.redhat.com/~tbielawa/ansible/ansible.spec > For %defattr, this is no longer needed on newer rpm version. %clean will > default to rm -Rf $RPM_BUILD_ROOT, or something like that, so this can be > removed too in new distribution ( can be kept of course ). And that's the same > for the rm just at the %install, it is done by default nowadays. Decided we're not going to target EPEL 5: - Removed %defattr - Removed %clean > - I think the email address is likely wrong ( unless me and LDAP missed a memo > ) Good call. Fixed! > - Guidelines also requires ( IIRC ) to ship the license file if present, or to > ask to upstream to ship it if not. > ( so that's the 2nd case here, so i just remind gently to do so :) ) Fixed that too! Also, re-built the man pages to show the correct version, 0.3. Thanks for taking the time to review this. I appreciate it a lot! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
