On 11/05/10 05:30, Nezmer wrote:
This change makes sense for me in general. The use-case I ran into was
needing the dependencies when repackaging.
Signed-off-by: Nezmer<[email protected]>
---
scripts/makepkg.sh.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index a2db90b..34261b5 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -1867,7 +1867,7 @@ if (( SOURCEONLY )); then
fi
# fix flyspray bug #5973
-if (( NODEPS || NOBUILD || REPKG )); then
+if (( (NODEPS || NOBUILD || REPKG)&& ! DEP_BIN )); then
# no warning message needed for nobuild, repkg
if (( NODEPS )); then
warning "$(gettext "Skipping dependency checks.")"
I think I would prefer something like:
if (( NODEPS || ( ( NOBUILD || REPKG ) && !DEP_BIN ) )); then
For NODEPS, we can safely skip installing deps if someone uses
"--nodeps --syncdeps" because that person is an idiot!
I think REPKG should only installed deps when explicitly asked as a fair
portion of the time installing deps will be unneeded.
Finally, I am not sure whether "--nobuild --syncdeps" is an OK
combination. I think it is.
Sound fine?
Allan
