Steffen Mueller wrote:

I tested your patch (with slight modifications) and these initial, rough, tests seem to show everything is okay. The patch comes with no tests, however. I think we should figure out a way to add at least a few simple tests.

To make all of this easier, I just created a Module::ScanDeps branch "caching" at Module-ScanDeps/tags/caching and the corresponding "caching" branch of PAR::Packer in PAR-Packer/tags/caching. I committed your patch there (including my small adjustments). Please just commit your changes to that branch at will and send a quick reminder to the list if you'd like review.

Hi,

if anyone would like to take a look at this, checkout from
http://svn.openfoundry.org/par/Module-ScanDeps/branches/caching

I moved code to Module-ScanDeps, added tests and pod. The option for ScanDeps is now named 'cache_file', scandeps.pl gets a switch '-C CACHEFILE'.

I still do not know how the dependencies-cache-file option to pp should be named. I used cd|cachedeps but I think it's a poor choice because it's not obvious, that it requires a filename as an argument.

Cheers, Christoph

Reply via email to