I pushed a vtk topic branch to gerrit. The topic moves the debug leaks from from ViewsQt to GUISupportQt.
http://review.source.kitware.com/#/t/1829/ I updated the 13024-debug-leaks-view branch on paraview stage. When the vtk topic goes from gerrit to master, then this branch can be added to paraview. Pat On Wed, Dec 5, 2012 at 10:19 PM, Pat Marion <pat.mar...@kitware.com> wrote: > Hi John, > > Thanks for the patch! Actually, funny you should send this email... I > just revived this this branch, 13024-debug-leaks-view, over the weekend. I > encountered that same thing as you did, merge conflicts and an annoying > dependency on vtkViewsQt. > > Unfortunately, the vtkQtDebugLeaksView got moved into vtkViewsQt during > modularization, even though it doesn't have a dependency on vtkViews. I'll > submit a patch to vtk to move the class into vtkGUISupportQt where I think > it belongs, then I'll get 13024-debug-leaks-view merged into ParaView. > > It's fine if you want to do work on moving dock panels around, I don't > have any new development on the class planned. > > > > Is it feasible to view debug leaks on remote nodes? > > It would be feasible, and could be quite useful! Might not be the most > straightforward to implement, though. Also, I'm not sure to what extent > you use the python console in ParaView for debugging, but it's always been > a dream of mine to add a feature that allows the python console to inspect > remote objects on server nodes. > > Pat > > > > On Wed, Dec 5, 2012 at 3:46 AM, Biddiscombe, John A. <biddi...@cscs.ch>wrote: > >> I’m replying on this thread, but my comments are really addressed to >> Pat.**** >> >> ** ** >> >> Having made use of the memory inspector, I have memory leaks in my reader >> and wanted to track them down. **** >> >> I tried to merge in the DebugLeaksView**** >> >> http://public.kitware.com/Wiki/DebugLeaksView**** >> >> helper which I thought would be nice to test. Using 3.98 I encountered >> conflicts and made a patch (though the conflicts I had might be caused by >> another tweak I made locally). Anyway, attached it a new patchset to get >> the debug leaks going in 3.98**** >> >> ** ** >> >> For wiki page : I had to turn on VTK_DEBUG_LEAKS (fairly obvious) and >> manually enable vtkViewsQt module or something like that.**** >> >> ** ** >> >> When compiling, lots of include paths were wrong so I just hard coded >> them and manually added vtkViewsQt.lib to the link line for paraview exe. >> **** >> >> ** ** >> >> The debug leaks window is really fabulous. I spent an hour tweaking my >> code and reduced my ref counts and spare objects by a full factor of two. >> Now I have no leaks. **** >> >> ** ** >> >> Feature request : Combine memory inspector and debug leaks into a single >> dock window. (Is it feasible to view debug leaks on remote nodes? – while >> running possibly, but not at closedown I suppose).**** >> >> ** ** >> >> I may have a play with the QtDebugLeaks stuff if you aren’t developing it >> any more to do the dock window combination changes.**** >> >> ** ** >> >> Patches attached are not very useful as the VTK stuff isn’t included and >> it would only take you 2 minutes to do it yourself anyway. Mostly just >> wanted to bump this thread in case someone was going to cleanly integrate >> the debugleaks in 3.98**** >> >> ** ** >> >> Thanks very much for both these memory management controls, really saved >> me a lot of work.**** >> >> ** ** >> >> JB**** >> >> ** ** >> >> ** ** >> >> ** ** >> >> ** ** >> >> *From:* Burlen Loring [mailto:blor...@lbl.gov] >> *Sent:* 01 December 2012 21:03 >> *To:* Sebastien Jourdain >> *Cc:* Biddiscombe, John A.; paraview@paraview.org >> *Subject:* Re: [Paraview] new memory inspector panel documentation**** >> >> ** ** >> >> Sebastien, >> >> Thanks for putting it in the right place. This morning I've merged the >> new docs with the old in the user guide to clean it up a bit. I wasn' t >> sure how important having a consitent look was (eg dialogs/windows in mac >> style), so I left the old images in the source but commented out in case >> that is important to you guys. >> >> Burlen >> >> On 12/01/2012 11:51 AM, Sebastien Jourdain wrote: **** >> >> Thanks Burlen, **** >> >> ** ** >> >> I've moved your doc inside the User guide on the wiki. **** >> >> I'll regenerate the PDF of the User Guide for the coming release which >> will include your contribution.**** >> >> ** ** >> >> Thanks again,**** >> >> ** ** >> >> Seb**** >> >> ** ** >> >> On Sat, Dec 1, 2012 at 1:25 PM, Burlen Loring <blor...@lbl.gov> wrote:*** >> * >> >> Just wanted to mentioned that Utkarsh and Sebastien deserve a lot of >> credit for this too. Their help is always very much appreciated :-) **** >> >> >> >> On 12/01/2012 08:59 AM, Burlen Loring wrote:**** >> >> Hi John, Thanks! That's great to know, very glad to hear you've found it >> useful. >> >> Burlen >> >> >> >> On 12/01/2012 03:56 AM, Biddiscombe, John A. wrote: >> >> **** >> >> Burlen >> >> The inspector is great and I've been using it extensively to monitor some >> of the big jobs I've run recently. It really helps knowing how much memory >> you've actually used on each node - and more importantly, how close you are >> to getting a job killed. >> >> Thanks for taking the time to contribute it. >> >> JB >> >> >> -----Original Message----- >> From: paraview-boun...@paraview.org [mailto:paraview-boun...@paraview.org] >> On Behalf Of burlen >> Sent: 01 December 2012 01:16 >> To: paraview@paraview.org >> Subject: [Paraview] new memory inspector panel documentation >> >> Documentation for the new memory inspector panel can be found here: >> >> http://paraview.org/Wiki/ParaView/Memory_Inspector_Panel >> >> The new panel reports per-process usage and provides some additional >> debugging tools. It should be available in the 3.98 release. >> >> Burlen >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the ParaView Wiki at: >> http://paraview.org/Wiki/ParaView >> >> Follow this link to subscribe/unsubscribe: >> http://www.paraview.org/mailman/listinfo/paraview >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the ParaView Wiki at: >> http://paraview.org/Wiki/ParaView >> >> Follow this link to subscribe/unsubscribe: >> http://www.paraview.org/mailman/listinfo/paraview**** >> >> ** ** >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the ParaView Wiki at: >> http://paraview.org/Wiki/ParaView >> >> Follow this link to subscribe/unsubscribe: >> http://www.paraview.org/mailman/listinfo/paraview**** >> >> ** ** >> >> ** ** >> > >
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview