Hi Tom, Thanks for your further comments!
On Tue, Nov 22, 2022 at 5:49 PM tom petch <ie...@btconnect.com> wrote: > From: Pce <pce-boun...@ietf.org> on behalf of tom petch < > ie...@btconnect.com> > Sent: 17 November 2022 10:42 > > From: Pce <pce-boun...@ietf.org> on behalf of julien.meu...@orange.com < > julien.meu...@orange.com> > Sent: 17 November 2022 09:38 > > As mentioned in the PCE session during IETF 115, this WGLC has ended. > Thanks Tom for your review. Comment resolution is in progress. > > <tp> > > -20 did appear in October. Is that worth looking at or waiting for -21? > > <tp2> > > Sigh, it is big, it is complicated and one day I will get to review it > all, but not just yet. > > MSD. Treated here as a single value but other I-D now treat it as a list > of different types as in draft-qu-mpls-mpls-msd-yang and there is an IANA > registry of types as well as differentiation between node and link MSD. > Which does PCE mean? Or should it join the crowd and have lists thereof? > > In PCEP we have only one field to carry MSD as per RFC 8664 and its description is clear in that RFC. draft-ietf-mpls-msd also defined msd-ERLD which is not carried in PCEP and same with link MSD. I don't think we need to make any further changes here! > -20 changes the reference for the IANA PCE flags. This change to IANA is > by draft-ietf-lsr-pce-discovery-security-support-13 so I see that I-D as a > Normative Reference. > > Ack. > -20 adds two new flags. TCP-AO I see in the flags but nowhere else, no > reference, no feature, no explanation. Something needs adding and I would > expect that to include Security Considerations. Again this makes that > lsr-pce I-D a Normative Reference IMO. > > Ack. > p.11 Tree diagram seems to be missing a vertical bar where auth has been > slotted in > > Ack > "Set to true if SR-MPLS is enabled > but where is this enablement? Not in RFC8664 AFAICT > > RFC 8664 states -> Implementations MUST allow the operator to enable and disable the Segment Routing path setup type on a PCEP-speaking device. Note that it is done via the RFC 8408 mechanism. > "PCEP Association Global Source."; > I see > "PCEP Global Association Source."; > In RFC8697 > > Ack > [IANA-IGP] reference > Title seems short of a 'P' > > Ack Please see the new update for the I-D posted - https://datatracker.ietf.org/doc/draft-ietf-pce-pcep-yang/ Diff - https://author-tools.ietf.org/iddiff?url2=draft-ietf-pce-pcep-yang-21 Thanks! Dhruv > > Tom Petch > > > Regards, > > Julien > > > On 26/09/2022 15:01, julien.meu...@orange.com wrote: > > Hi PCE WG, > > > > This message starts a 2-week WG Last Call for > > draft-ietf-pce-pcep-yang-19. Please review and share any feedback > > using the PCE mailing list. > > This WGLC will end on Tuesday October 11. > > > > Thanks, > > > > Julien > > _______________________________________________ > Pce mailing list > Pce@ietf.org > https://www.ietf.org/mailman/listinfo/pce >
_______________________________________________ Pce mailing list Pce@ietf.org https://www.ietf.org/mailman/listinfo/pce
