I would suggest merging. I recall that it did pass all relevant tests. I made several change suggestions and many have been implemented. I don't know if all, and I didn't use the mechanism of 'pull request' as I didn't (don't) know how to use it.
On Thu, Apr 25, 2019 at 06:39:52PM +0000, Ed . wrote: > Does the complex_atan2 branch need merging into legacy pdl/master and > bringing over to PDLA? > > -----Original Message----- > From: Luis Mochan > Sent: Thursday, April 25, 2019 7:38 PM > To: pdl-devel@lists.sourceforge.net > Subject: Re: [Pdl-devel] hidden type conversion > > I made a similar discovery and asked on the pdl-general list on > Jan. 18. The answer I got from Derek Lamb is that the issue has been > corrected on the complex_atan2 branch in github. I recall there have been > several other changes to PDL::Complex on that branch. > > Regards, > Luis > > > On Thu, Apr 25, 2019 at 08:01:01PM +0200, Ingo Schmid wrote: > > Hi, > > > > comparison of complex numbers make sense only to some extent, < , > are > > not defined. Yet even though in ops.pd they are disabled, somehow the > > real part gets compared. I guess there's a hidden conversion to double. > > I just can's see where that's happening. > > > > Does anyone know? > > > > Best wishes > > > > Ingo > > > > > > > > > > _______________________________________________ > > pdl-devel mailing list > > pdl-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/pdl-devel > > > -- > > o > W. Luis Mochán, | tel:(52)(777)329-1734 /<(*) > Instituto de Ciencias Físicas, UNAM | fax:(52)(777)317-5388 `>/ /\ > Apdo. Postal 48-3, 62251 | (*)/\/ \ > Cuernavaca, Morelos, México | moc...@fis.unam.mx /\_/\__/ > GPG: 791EB9EB, C949 3F81 6D9B 1191 9A16 C2DF 5F0A C52B 791E B9EB > > > > > _______________________________________________ > pdl-devel mailing list > pdl-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/pdl-devel > -- o W. Luis Mochán, | tel:(52)(777)329-1734 /<(*) Instituto de Ciencias Físicas, UNAM | fax:(52)(777)317-5388 `>/ /\ Apdo. Postal 48-3, 62251 | (*)/\/ \ Cuernavaca, Morelos, México | moc...@fis.unam.mx /\_/\__/ GPG: 791EB9EB, C949 3F81 6D9B 1191 9A16 C2DF 5F0A C52B 791E B9EB _______________________________________________ pdl-devel mailing list pdl-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pdl-devel
