no,you help me avoid a ClassCastException,thanks.And I committed it to head
just now;)
2011/6/27 Robert Gründler <r.gruend...@gmail.com>
> **
> excuse my ignorance, the patch wasn't applied correctly...
>
> it's working fine now, thanks!
>
>
> -robert
>
>
>
>
>
> On 27.06.11 14:46, 赵忠伟 wrote:
>
> did you see my attachment,looks much the same?
> but I did not add the instanceof judement,I will add it now,lol
>
> if (o instanceof AbstractSemanticHighlighting) {
>
> }
>
>
>
> 2011/6/27 Robert Gründler <r.gruend...@gmail.com>
>
>> nope, i'm still getting the ClassNotFoundException for my extension.
>>
>> according to the irc channel the problem is line 71:
>>
>> AbstractSemanticHighlighting instance = clazz.newInstance();
>>
>> which should look more like this:
>>
>> final Object o = element.createExecutableExtension("class");
>>
>> if (o instanceof AbstractSemanticHighlighting) {
>> AbstractSemanticHighlighting instance = (AbstractSemanticHighlighting) o;
>> rules.add(instance);
>>
>>
>> }
>>
>>
>> not sure though if this causes the ClassNotFoundException though.
>>
>>
>> regards
>>
>> -robert
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On 27.06.11 14:21, 赵忠伟 wrote:
>>
>> hi,
>>
>> Does this patch work?
>>
>> 2011/6/27 Robert Gründler <r.gruend...@gmail.com>
>>
>>> Hi again,
>>>
>>> i tried to follow the Wiki entry to add SemanticHighlighting to my plugin
>>> for
>>> PHP Annotations:
>>>
>>> http://wiki.eclipse.org/PDT/Dev2Dev/Semantic
>>>
>>> by adding an extension point like this:
>>>
>>> <extension
>>> point="org.eclipse.wst.sse.ui.semanticHighlighting">
>>> <highlighting
>>>
>>> class="org.eclipse.symfony.ui.editor.highlighting.AnnotationHighlighting"
>>> target="org.eclipse.php.core.phpsource">
>>> </highlighting>
>>> </extension>
>>>
>>> I'm getting a ClassNotFoundException during startup for
>>> org.eclipse.symfony.ui.editor.highlighting.AnnotationHighlighting,
>>> although my plugin is exporting the necessary packages.
>>>
>>> According to the eclipse irc channel, the way the SemanticHighlighting
>>> extensions are loaded by the PDT plugin will only work for internal
>>> pdt-bundle classes (in SemanticHighlightingManager line 71).
>>>
>>> Is this a bug in PDT or am i just not providing the extension point
>>> correctly?
>>>
>>> thanks!
>>>
>>> -robert
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> pdt-dev mailing list
>>> pdt-dev@eclipse.org
>>> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>>>
>>
>>
>>
>> --
>>
>> Thanks!
>>
>> Best Regards!
>>
>> Zhao
>>
>>
>> _______________________________________________
>> pdt-dev mailing
>> listpdt-dev@eclipse.orghttps://dev.eclipse.org/mailman/listinfo/pdt-dev
>>
>>
>>
>> _______________________________________________
>> pdt-dev mailing list
>> pdt-dev@eclipse.org
>> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>>
>>
>
>
> --
>
> Thanks!
>
> Best Regards!
>
> Zhao
>
>
> _______________________________________________
> pdt-dev mailing
> listpdt-dev@eclipse.orghttps://dev.eclipse.org/mailman/listinfo/pdt-dev
>
>
>
> _______________________________________________
> pdt-dev mailing list
> pdt-dev@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>
>
--
Thanks!
Best Regards!
Zhao
_______________________________________________
pdt-dev mailing list
pdt-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/pdt-dev
