On Thu, May 09, 2002 at 09:45:24PM -0700, chromatic wrote:
> On Thursday 09 May 2002 21:32, Jarkko Hietaniemi wrote:
> 
> > > +open(OUT, '>lib/B/success.pm') or skip_all( 'Cannot write fake backend
> > > module');
> > Unportable filename.
> 
> Would File::Spec help?

Yup.

> > > +@lines = split(/\n/, runperl( args => \@args, stderr => 1 ) );
> > Portable to split on /\n/?
> 
> Looking at runperl in test.pl, my guess is yes.  Another option is a pattern 
> of /[\r\n]+/, which seems to make sense for \r, \r\n, and \n.

I guess as long as as you are matching so that possible surplus
eol characters don't cause failures.

> If you're happy with these, prepare for a new patch.
> 
> -- c

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Reply via email to