-----BEGIN PGP SIGNED MESSAGE-----

Moin,

while trying to fix the error I noticed that the testsuite breaks when
Devel::Cover is already installed (and/or cover is moved into a dir of
PATH).

null:/home/te/perl/Devel-Cover-0.14 # make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/t1....ok
t/t2....Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
Use of uninitialized value in multiplication (*) at
/home/te/perl/Devel-Cover-0.14/blib/lib/Devel/Cover/Criterion.pm line 32.
t/t2....NOK 1# Test 1 got: 'mismatch: extra' (t/t2.t at line 35)
#   Expected: 'done'
t/t2....FAILED test 1
        Failed 1/1 tests, 0.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
- ----------------------------------------------------------------------------
- ---
t/t2.t                     1    1 100.00%  1
Failed 1/2 test scripts, 50.00% okay. 1/2 subtests failed, 50.00% okay.
make: *** [test_dynamic] Error 29
null:/home/te/perl/Devel-Cover-0.14 #



The attached patch fixes the "START" crash as well as a "ROOT" crash that
would occur on line 175. I have no idea if it is the right fix, but it
seems to work. Somebody with more insight can probably tell if this is a
Devel::Cover or a v5.8.0 problem. Also, Devel::Cover's testsuite did not
catch it, since it worked flawlessly at the first run.

Anyway, even with that fix I get a lot of 

Use of uninitialized value in multiplication (*) at
/usr/local/lib/perl5/site_perl/5.8.0/i686-linux/Devel/Cover/Criterion.pm
line 32.

when trying to run for instance 5.8.0-Complex.t trough it. Hm. Tomorrow is
another day...

HTH,

Tels







- -- 
 perl -MDev::Bollocks -e'print Dev::Bollocks->rand(),"\n"'
 proactively maintain essential e-tailers

 http://bloodgate.com/perl       My current Perl projects
 PGP key available on http://bloodgate.com/tels.asc or via email

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: When cryptography is outlawed, bayl bhgynjf jvyy unir cevinpl.

iQEVAwUBPXZ+h3cLPEOTuEwVAQHLhgf9EC0zXb7UJox/EZ7hJ+H6Sdef1FotJ2fK
jkfoeoiByOc2uOz8nh7mv1MG5wq7eDjRjKO7jpJGh2mSconOdUFyi+1qmafS8gKg
9subSOknxd46naD8cyFBOXBkQXy2LxG2bzf9ZYcojITFpbupqipZtfm6rbkWGmRn
u8KQ/71xRl+OJE5ug1m47pSVUQ4sfYSLnnbK1IARiGstZLsOx6k9KP3bTran+MLT
AQlKJjzQ7aw3M3IDYFHMLjCjNBaK7BPOmDHQ84IHQL4XoIDR+Nl3d76jvv/KeLWx
ANzrFxBWjlx9vz2rAm+Kibw6FMvqQIFI3TkJDX4UgOmTeUnq3Cve1Q==
=BgmY
-----END PGP SIGNATURE-----
--- Cover.pm.old        Wed Sep  4 23:36:14 2002
+++ Cover.pm    Wed Sep  4 23:38:46 2002
@@ -144,6 +144,8 @@ sub report
 
     for my $sub (@Todo)
     {
+        next unless $sub->[1]->CV->isa('B::CV');
+
         if (class($sub->[1]->CV->START) eq "COP")
         {
             # Determine whether this sub is in a package we are covering.

Reply via email to