----- Original Message ---- > From: Andy Lester <[EMAIL PROTECTED]> > > I was very surprised to find that tests that I was skipping via > > plan skip_all => 'wangdoodle not installed' if $@; > > were not showing up in the results when I ran make test or prove. > In my mind, prove and make test should DEFINITELY be showing that we're > skipping tests, even though they've effectively passed. > > Instead of > > t/html_lint_ok............ok 500 ms > t/has_tag.................ok 1649 ms > > we should have > > t/html_lint_ok............ok 500 ms > # SKIP: HTML::Lint is not installed, test cannot be run. > t/has_tag.................ok 1649 ms
This sounds reasonable. It seems to me that TAP::Formatter::Console::Session somewhere should have a line like: if ( $parser->skip_all ) { $formatter->_output( '# SKIP: ' . $parser->skip_all ); } Or something like that. However, TAP::Parser doesn't seem to have a &skip_all method (returning boolean or explanation? What if no skip reason given?). I was also going nuts trying to figure out where I'd put the tests for this. I feel like I've lagged far behind in TAP::Parser development :( Cheers, Ovid -- Buy the book - http://www.oreilly.com/catalog/perlhks/ Perl and CGI - http://users.easystreet.com/ovid/cgi_course/ Personal blog - http://publius-ovidius.livejournal.com/ Tech blog - http://use.perl.org/~Ovid/journal/