On Wed, Oct 15, 2008 at 1:43 PM, Steve Peters <[EMAIL PROTECTED]> wrote: > On Tue, Oct 14, 2008 at 10:15 PM, Michael G Schwern <[EMAIL PROTECTED]> wrote: >> http://schwern.org/src/Test-Simple-0.82.tar.gz >> or coming soon on CPAN. >> >> Please report bugs via >> http://code.google.com/p/test-more/issues/list >> >> There are some user visible changes which might cause "fixage" for those who >> depend too closely on the output of Test::Builder. Here's the new features >> and feature changes. >> >> New Test::More Features >> * new_ok() combines a call to new() with isa_ok(). >> * note() is like diag() but only shows up in verbose output >> * explain() is a handy data dumping function >> >> New Test::Builder Features >> * TODO tests can be declared more accurately using todo_start() >> and todo_end(). >> >> Feature Changes >> * use Test::More no_plan => 1; now issues a warning >> * A test's exit code is now preserved rather than exiting with 255. >> * The "Looks like your test died" message is now "Looks like your test >> exited with $exit_code" >> * The "extra tests" message shows the number of tests run rather than >> the number extra to avoid having to do mental math >> * The diagnostics for isnt() are more obvious, rather than being >> recycled cmp_ok() output. >> >> >> 0.82 Tue Oct 14 23:06:56 EDT 2008 >> Bug Fixes >> - 0.81_01 broke $TODO such that $TODO = '' was considered todo. >> >> >> 0.81_02 Tue Sep 9 04:35:40 PDT 2008 >> New Features >> * Test::Builder->reset_outputs() to reset all the output methods back to >> their defaults. >> >> Bug Fixes >> - Fixed the file and line number reported by like when it gets a bad >> regex. >> >> Features Changed >> - Now preserves the tests' exit code if it exits abnormally, rather than >> setting it to 255. >> - Changed the "Looks like your test died" message to >> "Looks like your test exited with $exit_code" >> - no_plan now only warns if given an argument. There were a lot of people >> doing that, and it's a sensible mistake. [test-more.googlecode.com 13] >> >> >> 0.81_01 Sat Sep 6 15:13:50 PDT 2008 >> New Features >> * Adam Kennedy bribed me to add new_ok(). The price was one DEFCON >> license key. >> [rt.cpan.org 8891] >> * TODO tests can now start and end with 'todo_start' and 'todo_end' >> Test::Builder methods. [rt.cpan.org 38018] >> * Added Test::Builder->in_todo() for a safe way to check if a test is >> inside a >> TODO block. This allows TODO tests with no reason. >> * Added note() and explain() to both Test::More and Test::Builder. >> [rt.cpan.org 14764] [test-more.googlecode.com 3] >> >> Features Changed >> * Changed the message for extra tests run to show the number of tests run >> rather than >> the number extra to avoid the user having to do mental math. >> [rt.cpan.org 7022] >> >> Bug fixes >> - using a relative path to perl broke tests [rt.cpan.org >> 34050] >> - use_ok() broke $SIG{__DIE__} in the used module [rt.cpan.org >> 34065] >> - diagnostics for isnt() were confusing on failure [rt.cpan.org >> 33642] >> - warnings when MakeMaker's version contained _ [rt.cpan.org >> 33626] >> - add explicit test that non-integer plans die correctly [rt.cpan.org >> 28836] >> (Thanks to Hans Dieter Pearcey [confound] for fixing the above) >> - die if no_plan is given an argument [rt.cpan.org >> 27429] >> > > After upgrading bleadperl to T-S-0.82, we get test failures in > lib/constant.t. It appears that a new warning is generated by > Test::Builder within its code. lib/constant.t, however, traps all > constants and fails the test if warnings appear. The failure is > included below. > > Steve Peters > [EMAIL PROTECTED] > > [EMAIL PROTECTED] t]$ ./perl harness ../lib/constant.t > ../lib/constant....1/97 > # Failed test at ../lib/constant.t line 115. > # got: '1' > # expected: '0' > # unexpected warning > # Argument "12 cats" isn't numeric in addition (+) at > ../lib/Test/Builder.pm line 492. > # Looks like you failed 1 test of 97. > ../lib/constant.... Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/97 subtests >
I've applied the follow change to bleadperl. It somewhat muscles its way to a fix, but its the quickest fix to keep the smokers from putting out loads of black smoke. I'm sure there is a better fix, but it will take a little more time to look into it. Steve Peters [EMAIL PROTECTED] Change 34491 by [EMAIL PROTECTED] on 2008/10/15 19:07:38 Silence a warning in Test::Builder that was causing lib/constant.t to fail. Affected files ... ... //depot/perl/lib/Test/Builder.pm#35 edit Differences ... ==== //depot/perl/lib/Test/Builder.pm#35 (text) ==== @@ -5,7 +5,7 @@ use strict; use warnings; -our $VERSION = '0.82'; +our $VERSION = '0.82_01'; $VERSION = eval $VERSION; ## no critic (BuiltinFunctions::ProhibitStringyEval) # Make Test::Builder thread-safe for ithreads. @@ -487,6 +487,7 @@ $self->_unoverload( '0+', @_ ); + no warnings 'numeric'; for my $val (@_) { next unless $self->_is_dualvar($$val); $$val = $$val + 0;