Jez White wrote:

Kurt,

droplist didn't work with the mouse but it wasn't obvious why. I wonder if invoking Dialog() via an instance should be outright forbidden in GUI.pm or GUI.xs.


Unless there is a reason for Dialog to exists as a method - it probably should be forbidden - thoughts anyone?

I can't (personally) see any reason for calling Dialog() on a specific window, but given that MS allow GetMessage() to be called with a specific window handle, there must be cases when people want to do this, and Dialog() is written to allow it. Hence, I wouldn't change it to be forbidden.

Perhaps a warning issued if Dialog() is not called statically? Something like:

if( PL_dowarn && items !=0) warn("You probably meant Win32::GUI::Dialog()\n");

near the start of the CODE section?

Regards,
Rob.


Reply via email to