On 19 February 2014 23:24, Steve Hay <steve.m....@googlemail.com> wrote:
> On 19 February 2014 23:04, Karl Williamson <pub...@khwilliamson.com> wrote:
>> On 02/19/2014 03:52 PM, Steve Hay wrote:
>>>
>>> I understand. Sorry - I didn't mean to sound rude. I really appreciate
>>> your efforts on this. It can't be easy coding "blind", as you are.
>>>
>>> At 730252b299f0cde0043bed7edb5bcf0c3e37fd38 blead builds but I still
>>> have run/locale.t failing 4,5 and 7:
>>
>>
>> I didn't think you were being rude.
>>
>> This is strange, by faking out the #ifdef's I was able to reproduce the
>> problem on my machine, until I made those fixes.
>
> Ah... I now have run/locale.t passing after doing a clean and fresh
> build. I only rebuilt my existing build before, trusting that the
> Makefile would rebuild the necessary, but it seems not :-/ So this
> could be a false alarm.
>
> I've just set a full test suite running and will report back in
> 15-20min (whatever it takes) to confirm if all is well.
Sorry - that was slower than I expected!
t/run/locale.t does indeed pass all tests now, but now I have
lib/locale.t failing 6 tests (otherwise everything else has passed):
C:\Dev\Git\perl\t>perl harness -v ..\lib\locale.t
../lib/locale.t ..
[...]
ok 67 verify that isn't tainted: /(\N{CYRILLIC CAPITAL LETTER A})/i $&
ok 68 verify that isn't tainted: $`
ok 69 verify that isn't tainted: $'
ok 70 verify that isn't tainted: $+
ok 71 verify that isn't tainted: $1
ok 72 $1 is 'small cyrillic a'
ok 73 verify that isn't tainted: $2
ok 74 verify that isn't tainted: /./ $&
not ok 75 verify that is tainted: /(\N{KELVIN SIGN})/i $&
not ok 76 verify that is tainted: $`
not ok 77 verify that is tainted: $'
not ok 78 verify that is tainted: $+
not ok 79 verify that is tainted: $1
not ok 80 $1 is 'k'
ok 81 verify that isn't tainted: $2
ok 82 verify that isn't tainted: /(.)/ $&
[...]
1..553
Failed 6/553 subtests
Test Summary Report
-------------------
../lib/locale.t (Wstat: 0 Tests: 553 Failed: 6)
Failed tests: 75-80
Files=1, Tests=553, 4 wallclock secs ( 0.01 usr + 0.00 sys = 0.01 CPU)
Result: FAIL
