Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 544112d4371b60e6fc092870e9564e3e476bc6e5
https://github.com/Perl/perl5/commit/544112d4371b60e6fc092870e9564e3e476bc6e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 9035f6bed3861d9157edf6c719ad209b6fd2c855
https://github.com/Perl/perl5/commit/9035f6bed3861d9157edf6c719ad209b6fd2c855
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 26a6e984cb4cc348c5f0ba1dc1ca7638932af825
https://github.com/Perl/perl5/commit/26a6e984cb4cc348c5f0ba1dc1ca7638932af825
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: d56458c322d8c370fc4222822af2c89c8723be9a
https://github.com/Perl/perl5/commit/d56458c322d8c370fc4222822af2c89c8723be9a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: e428f073acd061b91ea77033b99cc7bae1aaa306
https://github.com/Perl/perl5/commit/e428f073acd061b91ea77033b99cc7bae1aaa306
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 4bfbf5487928b40a450e62924238d53ac39ac41d
https://github.com/Perl/perl5/commit/4bfbf5487928b40a450e62924238d53ac39ac41d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: b5b00f8b573554a70af98b5e16e150ec5bcbc1da
https://github.com/Perl/perl5/commit/b5b00f8b573554a70af98b5e16e150ec5bcbc1da
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 1753dd7d7c16f69efe4bc9bb743052b89bac80e6
https://github.com/Perl/perl5/commit/1753dd7d7c16f69efe4bc9bb743052b89bac80e6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: ae7554f56d00dfc29b0dd392fd3a81bed0b28aec
https://github.com/Perl/perl5/commit/ae7554f56d00dfc29b0dd392fd3a81bed0b28aec
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 941239d348290da6ab035f9984a875ccaddd0469
https://github.com/Perl/perl5/commit/941239d348290da6ab035f9984a875ccaddd0469
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: aa2d03f4fb9609d88de7ddbb9d75f5fff4efa31c
https://github.com/Perl/perl5/commit/aa2d03f4fb9609d88de7ddbb9d75f5fff4efa31c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: feae811097daecae1f22067a42647913b115455c
https://github.com/Perl/perl5/commit/feae811097daecae1f22067a42647913b115455c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 8cdf12d69c6f50f82bfbc83ac7361dbf05432704
https://github.com/Perl/perl5/commit/8cdf12d69c6f50f82bfbc83ac7361dbf05432704
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 3ac43c2d8f9da74491542c41c3ed6942a146a458
https://github.com/Perl/perl5/commit/3ac43c2d8f9da74491542c41c3ed6942a146a458
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 2438489f9697332377a887a6e19fdb7eb0fca81b
https://github.com/Perl/perl5/commit/2438489f9697332377a887a6e19fdb7eb0fca81b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 8cf2e01c853b0d9a7fe76e85ebde9743a22496a6
https://github.com/Perl/perl5/commit/8cf2e01c853b0d9a7fe76e85ebde9743a22496a6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 030595663f0710f73f87b564a1ea31eadec6754d
https://github.com/Perl/perl5/commit/030595663f0710f73f87b564a1ea31eadec6754d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 31dc75bcbbf7d924f71e243f9bfce1af2d007d26
https://github.com/Perl/perl5/commit/31dc75bcbbf7d924f71e243f9bfce1af2d007d26
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 44319d0a47fa1e0fb5581ec7e328643c7c03da57
https://github.com/Perl/perl5/commit/44319d0a47fa1e0fb5581ec7e328643c7c03da57
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: d8a6de52b36aef5b231906cc0179f3121ee1322c
https://github.com/Perl/perl5/commit/d8a6de52b36aef5b231906cc0179f3121ee1322c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 619ac82be96d142537eff2a2aae0ff41253ccd49
https://github.com/Perl/perl5/commit/619ac82be96d142537eff2a2aae0ff41253ccd49
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: a51d566526e01c7d6b8c4c634b17d34d0eea5b96
https://github.com/Perl/perl5/commit/a51d566526e01c7d6b8c4c634b17d34d0eea5b96
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 51a3fdec06be47cc089ab1de816dc6b97fd4122f
https://github.com/Perl/perl5/commit/51a3fdec06be47cc089ab1de816dc6b97fd4122f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: a2f632fa03fffe33d772f699537738719e8a15cf
https://github.com/Perl/perl5/commit/a2f632fa03fffe33d772f699537738719e8a15cf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 777b338aeabfcebbd3fe7cc49551b8e73b60f657
https://github.com/Perl/perl5/commit/777b338aeabfcebbd3fe7cc49551b8e73b60f657
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 0a612f72ffb0b6333e8b9bbe59eed26bbef22017
https://github.com/Perl/perl5/commit/0a612f72ffb0b6333e8b9bbe59eed26bbef22017
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 9e08da8a598cb31048cf85ad6ffddf122046a737
https://github.com/Perl/perl5/commit/9e08da8a598cb31048cf85ad6ffddf122046a737
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: eb589cea13a573273d432e1fd8b74d6372ae0921
https://github.com/Perl/perl5/commit/eb589cea13a573273d432e1fd8b74d6372ae0921
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 1262fccc6123963947bbf1e367125903bea30ce4
https://github.com/Perl/perl5/commit/1262fccc6123963947bbf1e367125903bea30ce4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 637556ab4f02167124d00ccf58f71dd16cf3a744
https://github.com/Perl/perl5/commit/637556ab4f02167124d00ccf58f71dd16cf3a744
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 99901f0821f6a28005698599cb2a17be56041a4a
https://github.com/Perl/perl5/commit/99901f0821f6a28005698599cb2a17be56041a4a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 4d9325fc369a968fea5e04166e6bf869af691214
https://github.com/Perl/perl5/commit/4d9325fc369a968fea5e04166e6bf869af691214
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 9a662ef94b362e438b1aa1931a35dc18311afabf
https://github.com/Perl/perl5/commit/9a662ef94b362e438b1aa1931a35dc18311afabf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 1ec7c18128c5395037d52a3ace89d2fbac25dc34
https://github.com/Perl/perl5/commit/1ec7c18128c5395037d52a3ace89d2fbac25dc34
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 0b6de9b42537eb2afbac4f2be8b86f4ae633800f
https://github.com/Perl/perl5/commit/0b6de9b42537eb2afbac4f2be8b86f4ae633800f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 99e2a765708dbee66891c426b2f1502481ca36cf
https://github.com/Perl/perl5/commit/99e2a765708dbee66891c426b2f1502481ca36cf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 41e04db332c7966299660bca27c49e1899e7a497
https://github.com/Perl/perl5/commit/41e04db332c7966299660bca27c49e1899e7a497
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 7420de17fa60c3476ca478e8d47db1afdc71339e
https://github.com/Perl/perl5/commit/7420de17fa60c3476ca478e8d47db1afdc71339e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 701405e13607ba65e607fde9ad16be038cf05c46
https://github.com/Perl/perl5/commit/701405e13607ba65e607fde9ad16be038cf05c46
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 18a8edc8290d96e431efb8ced3e25e3080c6a171
https://github.com/Perl/perl5/commit/18a8edc8290d96e431efb8ced3e25e3080c6a171
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 2a9ade78a6b4897b6a9350808113471e4d5ee77a
https://github.com/Perl/perl5/commit/2a9ade78a6b4897b6a9350808113471e4d5ee77a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 065e0ac85904a127c06f0348104818c8ea5510d3
https://github.com/Perl/perl5/commit/065e0ac85904a127c06f0348104818c8ea5510d3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 8c35cf6610e7423818a2d6ca536c15a3c030a349
https://github.com/Perl/perl5/commit/8c35cf6610e7423818a2d6ca536c15a3c030a349
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: a6e0ff24015e059c6e6db69419b438f21b6d6827
https://github.com/Perl/perl5/commit/a6e0ff24015e059c6e6db69419b438f21b6d6827
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 1a66e878da4eee3bb4954aad23c44e8605308016
https://github.com/Perl/perl5/commit/1a66e878da4eee3bb4954aad23c44e8605308016
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: bcbceca35cc108a041425efe8f6c65137cfa2064
https://github.com/Perl/perl5/commit/bcbceca35cc108a041425efe8f6c65137cfa2064
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 687c0d81fb39d8b8bcf23513d1091c0ce0b49ad7
https://github.com/Perl/perl5/commit/687c0d81fb39d8b8bcf23513d1091c0ce0b49ad7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 10c3d156b6d93c4ee37e1049693de26b47be4f5b
https://github.com/Perl/perl5/commit/10c3d156b6d93c4ee37e1049693de26b47be4f5b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: cb4f4ae31bbd155bf8ca16f66cdfb5b55a56a88f
https://github.com/Perl/perl5/commit/cb4f4ae31bbd155bf8ca16f66cdfb5b55a56a88f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 702b720b3ee48755d274d68cfc43a62c9851fa10
https://github.com/Perl/perl5/commit/702b720b3ee48755d274d68cfc43a62c9851fa10
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 88eef6ad3b3b51c072c201b7c56303b2fa9d767b
https://github.com/Perl/perl5/commit/88eef6ad3b3b51c072c201b7c56303b2fa9d767b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 4a9c4ec61fc625a7a18059a5907dfa24f16e6d30
https://github.com/Perl/perl5/commit/4a9c4ec61fc625a7a18059a5907dfa24f16e6d30
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: a2a5e7ef6e3eb0c049b13c5842de146acf1a1aa9
https://github.com/Perl/perl5/commit/a2a5e7ef6e3eb0c049b13c5842de146acf1a1aa9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 52002cd48ca303f946bc908b7cf6b94a58d5332f
https://github.com/Perl/perl5/commit/52002cd48ca303f946bc908b7cf6b94a58d5332f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 5503f3c70216dfc5a25e44f698f0885b7bc7154b
https://github.com/Perl/perl5/commit/5503f3c70216dfc5a25e44f698f0885b7bc7154b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: adab0d30cdc9669dd230adc8386b14a432499c57
https://github.com/Perl/perl5/commit/adab0d30cdc9669dd230adc8386b14a432499c57
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 480c4b6ede05e1a2515bf7ec36ed47b9edb7718c
https://github.com/Perl/perl5/commit/480c4b6ede05e1a2515bf7ec36ed47b9edb7718c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: aed37acedfd3bbefc0003fc944d2ceed2d47206a
https://github.com/Perl/perl5/commit/aed37acedfd3bbefc0003fc944d2ceed2d47206a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
XXX re-enable 2008 exclusion, rmv #if0 locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and I
don't understand why this wasn't such an egregious Windows bug that it
was allowed to fester all this time. It should be a common paradigm
that you want to toggle locales temporarily and get back to the
original. Perhaps the affected locales are uncommon. I'm told it is
fixed in the latest versions.
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I rewrote the function to handle LC_ALL, which can arise from the
Windows bug; a change in that that I think harmless is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 4cf9c6557a1ca9a5fe8a1c7640f3ac9eb9722f0e
https://github.com/Perl/perl5/commit/4cf9c6557a1ca9a5fe8a1c7640f3ac9eb9722f0e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 2d9b0a416c8f3cc3e27263ad9a63862b4ffc0fd9
https://github.com/Perl/perl5/commit/2d9b0a416c8f3cc3e27263ad9a63862b4ffc0fd9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: a59880d37388d5c94958a4c8eb000aaeaf985042
https://github.com/Perl/perl5/commit/a59880d37388d5c94958a4c8eb000aaeaf985042
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 9aeb2e16a8184cf8ec12b91c7c57e2a46b246583
https://github.com/Perl/perl5/commit/9aeb2e16a8184cf8ec12b91c7c57e2a46b246583
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 12fb377ae229dcebba4cacbc5aeaa654c31dd1c1
https://github.com/Perl/perl5/commit/12fb377ae229dcebba4cacbc5aeaa654c31dd1c1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: b755a07ffacda341a86ac76d2cf001c3151f36e2
https://github.com/Perl/perl5/commit/b755a07ffacda341a86ac76d2cf001c3151f36e2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: fc615d7be505abc0f1afba3e2d88593d8de76c74
https://github.com/Perl/perl5/commit/fc615d7be505abc0f1afba3e2d88593d8de76c74
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: da57e4cb511f10d0f8814ee69c1f3e8961365360
https://github.com/Perl/perl5/commit/da57e4cb511f10d0f8814ee69c1f3e8961365360
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: b9c3cc0c1bfa5415330779fb417051bdeccb626d
https://github.com/Perl/perl5/commit/b9c3cc0c1bfa5415330779fb417051bdeccb626d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 1a002eae9bb801cafdcee1b0546d5353ebffbc0a
https://github.com/Perl/perl5/commit/1a002eae9bb801cafdcee1b0546d5353ebffbc0a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: d471828d29c2287d463f48ffb0f801e1b89517f0
https://github.com/Perl/perl5/commit/d471828d29c2287d463f48ffb0f801e1b89517f0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 93537c0952198bf4df8b1d8a73a7e74e172fc969
https://github.com/Perl/perl5/commit/93537c0952198bf4df8b1d8a73a7e74e172fc969
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 102ab977974f37e9c36c44cb4c4d5c102201da76
https://github.com/Perl/perl5/commit/102ab977974f37e9c36c44cb4c4d5c102201da76
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 72659b62f70202f9ee849fd7c53f9d4d231979fd
https://github.com/Perl/perl5/commit/72659b62f70202f9ee849fd7c53f9d4d231979fd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 04caefb269a868f814dc4ebad229a9d40f6ace91
https://github.com/Perl/perl5/commit/04caefb269a868f814dc4ebad229a9d40f6ace91
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: fc7845ebbeb936f4b7cbcf81f6d5fde19368c37c
https://github.com/Perl/perl5/commit/fc7845ebbeb936f4b7cbcf81f6d5fde19368c37c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 8347701fafcf84b6428257131c29edd849e84222
https://github.com/Perl/perl5/commit/8347701fafcf84b6428257131c29edd849e84222
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 5c6f1738f46956a1a9d9d8131acee4d3815723f8
https://github.com/Perl/perl5/commit/5c6f1738f46956a1a9d9d8131acee4d3815723f8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 31cda51e69e695a2ff6f14703d67ffd916bbd710
https://github.com/Perl/perl5/commit/31cda51e69e695a2ff6f14703d67ffd916bbd710
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 6b6063d8ad6c52fd2c7b516600b8ef189ef41271
https://github.com/Perl/perl5/commit/6b6063d8ad6c52fd2c7b516600b8ef189ef41271
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 5be863e93a6d8d285a6e6877c11e9d9af8e805b5
https://github.com/Perl/perl5/commit/5be863e93a6d8d285a6e6877c11e9d9af8e805b5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: c803034495192f16c3bb8f6c08a71f039d11dcbb
https://github.com/Perl/perl5/commit/c803034495192f16c3bb8f6c08a71f039d11dcbb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 24f1b8a1cf85975f11ec19c068adcfa7bad2607f
https://github.com/Perl/perl5/commit/24f1b8a1cf85975f11ec19c068adcfa7bad2607f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: eab7165364b8a2b0b940ce496cb4a4a683950208
https://github.com/Perl/perl5/commit/eab7165364b8a2b0b940ce496cb4a4a683950208
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 12660716c7e49a86734f345a33d627c2ea3f0b6e
https://github.com/Perl/perl5/commit/12660716c7e49a86734f345a33d627c2ea3f0b6e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: f849e76370b59bbd13ae1190483bc1090733ebc2
https://github.com/Perl/perl5/commit/f849e76370b59bbd13ae1190483bc1090733ebc2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: de81d709f581f491134ef515a3e1d5d3529dbe83
https://github.com/Perl/perl5/commit/de81d709f581f491134ef515a3e1d5d3529dbe83
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 96adeb6986e80a62cbfa1de951a2487988430393
https://github.com/Perl/perl5/commit/96adeb6986e80a62cbfa1de951a2487988430393
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 2e548a221f22e456cbf963ddd36b6f38fec7c2fb
https://github.com/Perl/perl5/commit/2e548a221f22e456cbf963ddd36b6f38fec7c2fb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: fa092e09c098683d101a01db1e9748ae42eda687
https://github.com/Perl/perl5/commit/fa092e09c098683d101a01db1e9748ae42eda687
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 925794fee2169de27ab7e4adce28a524a9d9cd77
https://github.com/Perl/perl5/commit/925794fee2169de27ab7e4adce28a524a9d9cd77
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 68e7aa2899b7e7a43192760d51148026f1de0d12
https://github.com/Perl/perl5/commit/68e7aa2899b7e7a43192760d51148026f1de0d12
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 7d0ddf466e6d769f350d76d29ba03f436a4b2fe5
https://github.com/Perl/perl5/commit/7d0ddf466e6d769f350d76d29ba03f436a4b2fe5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 056b524d4d84de435c33e876154a34b279abdc76
https://github.com/Perl/perl5/commit/056b524d4d84de435c33e876154a34b279abdc76
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: d1930883c98473ee2c9573ca51f5dc4891217ebb
https://github.com/Perl/perl5/commit/d1930883c98473ee2c9573ca51f5dc4891217ebb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: a7e9909ec797eea2a02732f369924a0c2aca64a9
https://github.com/Perl/perl5/commit/a7e9909ec797eea2a02732f369924a0c2aca64a9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: fc3e0639a961e80eef5e5e8198cc8c80b1fa128a
https://github.com/Perl/perl5/commit/fc3e0639a961e80eef5e5e8198cc8c80b1fa128a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 2b0db216fdfad8edc23ee9d5257e46bd4714d56f
https://github.com/Perl/perl5/commit/2b0db216fdfad8edc23ee9d5257e46bd4714d56f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 0cc0f89eab2e25bf31c85ca30c838c030d5fe3b5
https://github.com/Perl/perl5/commit/0cc0f89eab2e25bf31c85ca30c838c030d5fe3b5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 07a180be032a28f880c0832259ef150a50ddbe4f
https://github.com/Perl/perl5/commit/07a180be032a28f880c0832259ef150a50ddbe4f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 03e632bf62d91662deabbea64fce9dd11220f1e7
https://github.com/Perl/perl5/commit/03e632bf62d91662deabbea64fce9dd11220f1e7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 33b522049e9b843afda62f4cde8b57727a0500ac
https://github.com/Perl/perl5/commit/33b522049e9b843afda62f4cde8b57727a0500ac
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 5741b9c63d45688e598872a9dd18e5f0675c3328
https://github.com/Perl/perl5/commit/5741b9c63d45688e598872a9dd18e5f0675c3328
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 2cdbf437f894609f053192b02269f5160ae3666c
https://github.com/Perl/perl5/commit/2cdbf437f894609f053192b02269f5160ae3666c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: e3834f7d766a16d1e4cb1fd46159dabd2df611ff
https://github.com/Perl/perl5/commit/e3834f7d766a16d1e4cb1fd46159dabd2df611ff
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: e36c488431fa9cc7fdd8e0f5c41d20c86b0fa50c
https://github.com/Perl/perl5/commit/e36c488431fa9cc7fdd8e0f5c41d20c86b0fa50c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: b6d82250cffaa694f5b364ac807bb88d473fe6fc
https://github.com/Perl/perl5/commit/b6d82250cffaa694f5b364ac807bb88d473fe6fc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 3de6788ecaee0774e3e3ce6d0a57a22ab3d4cf79
https://github.com/Perl/perl5/commit/3de6788ecaee0774e3e3ce6d0a57a22ab3d4cf79
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 51ea4a5acd1ae521495c07483a8ed3907a194ecf
https://github.com/Perl/perl5/commit/51ea4a5acd1ae521495c07483a8ed3907a194ecf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 90468edf0d144d4ad7519e90fc83d1720de0eeb7
https://github.com/Perl/perl5/commit/90468edf0d144d4ad7519e90fc83d1720de0eeb7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 1947e4d09490838663db307bf91da169813ba4fc
https://github.com/Perl/perl5/commit/1947e4d09490838663db307bf91da169813ba4fc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: cd8c640be6f62c59551496b2c84d79d81a08e5a0
https://github.com/Perl/perl5/commit/cd8c640be6f62c59551496b2c84d79d81a08e5a0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 09e27e217558afd1896b2348bfbb78652dbd6de3
https://github.com/Perl/perl5/commit/09e27e217558afd1896b2348bfbb78652dbd6de3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: d6ccdc60551373f663c980b65bd86338f92195b2
https://github.com/Perl/perl5/commit/d6ccdc60551373f663c980b65bd86338f92195b2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: faa323c00d365f77bb3cb432f4ebfb43cc35ea27
https://github.com/Perl/perl5/commit/faa323c00d365f77bb3cb432f4ebfb43cc35ea27
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: d09798d68bb779dcb376396e57dd08683383037f
https://github.com/Perl/perl5/commit/d09798d68bb779dcb376396e57dd08683383037f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 48c2829825fe40f32df632ac06ab02a6ffb75d77
https://github.com/Perl/perl5/commit/48c2829825fe40f32df632ac06ab02a6ffb75d77
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: a6fb472ceef093b8776bed1cc839f2ce653ace93
https://github.com/Perl/perl5/commit/a6fb472ceef093b8776bed1cc839f2ce653ace93
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 226e47c5ad4c33eb9cbf5ff090479ccf8ed47a2c
https://github.com/Perl/perl5/commit/226e47c5ad4c33eb9cbf5ff090479ccf8ed47a2c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 65728721154b205b8268ec0687ca231af019ce52
https://github.com/Perl/perl5/commit/65728721154b205b8268ec0687ca231af019ce52
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 78b7d3b8eca14f182ecb33113ddffc998aa024b5
https://github.com/Perl/perl5/commit/78b7d3b8eca14f182ecb33113ddffc998aa024b5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 6fa2af483f17c2f8e7400a2ede9b3b63f8ec207b
https://github.com/Perl/perl5/commit/6fa2af483f17c2f8e7400a2ede9b3b63f8ec207b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 566892a13f0e87c14c5d2b3c555df6dd5c73f014
https://github.com/Perl/perl5/commit/566892a13f0e87c14c5d2b3c555df6dd5c73f014
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 91b777462d5e13d0074038636078227361661efd
https://github.com/Perl/perl5/commit/91b777462d5e13d0074038636078227361661efd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 7d11bb167a7efc29be712cb637fc302db35145c5
https://github.com/Perl/perl5/commit/7d11bb167a7efc29be712cb637fc302db35145c5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 0ae7820ccc6bd32f195d2b05d3d27d389b9aabe8
https://github.com/Perl/perl5/commit/0ae7820ccc6bd32f195d2b05d3d27d389b9aabe8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 5d9d283cfdfccd4630057fcd9e3086f4e4a6cb14
https://github.com/Perl/perl5/commit/5d9d283cfdfccd4630057fcd9e3086f4e4a6cb14
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 30550a2859e0746ef98031aed73369d3ca96df39
https://github.com/Perl/perl5/commit/30550a2859e0746ef98031aed73369d3ca96df39
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 1019afaf8f90d4b58082dbdb8c5380f7f7ca04ed
https://github.com/Perl/perl5/commit/1019afaf8f90d4b58082dbdb8c5380f7f7ca04ed
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 63d9854496767db367a0ffe99e712d4eb05fc09b
https://github.com/Perl/perl5/commit/63d9854496767db367a0ffe99e712d4eb05fc09b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 2a63e8f93b60265abd81f33fd79d6ff51e96ec57
https://github.com/Perl/perl5/commit/2a63e8f93b60265abd81f33fd79d6ff51e96ec57
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 57fd0462a81dddf28a557ddab8f82b78c985cd8f
https://github.com/Perl/perl5/commit/57fd0462a81dddf28a557ddab8f82b78c985cd8f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 7895eb03112896a258798732cd28e951320cf4d8
https://github.com/Perl/perl5/commit/7895eb03112896a258798732cd28e951320cf4d8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 6ebb07add3c6340cfeda08c1e0896840fd181eba
https://github.com/Perl/perl5/commit/6ebb07add3c6340cfeda08c1e0896840fd181eba
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 061b1fe68578796107e842111d5efbb3469274a7
https://github.com/Perl/perl5/commit/061b1fe68578796107e842111d5efbb3469274a7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 7c396c3c3b3e162982b2937db8ab5cb820b8d21a
https://github.com/Perl/perl5/commit/7c396c3c3b3e162982b2937db8ab5cb820b8d21a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: a59a04ac1416c0afa4da4f93018297a6c66ee09b
https://github.com/Perl/perl5/commit/a59a04ac1416c0afa4da4f93018297a6c66ee09b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 787a5539ccc23add5295989e37a4c0583aac2a01
https://github.com/Perl/perl5/commit/787a5539ccc23add5295989e37a4c0583aac2a01
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 4346b5f90206840d7a06915381061c661e56eda5
https://github.com/Perl/perl5/commit/4346b5f90206840d7a06915381061c661e56eda5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 9fc88bbf0c184ff6bc105cfa51f1b4f554955f25
https://github.com/Perl/perl5/commit/9fc88bbf0c184ff6bc105cfa51f1b4f554955f25
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 8928b44b5f2b85975daa2d44223f9c7770d5dc26
https://github.com/Perl/perl5/commit/8928b44b5f2b85975daa2d44223f9c7770d5dc26
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a5358ca6b6d5c08a015d274056b201c50c007a98
https://github.com/Perl/perl5/commit/a5358ca6b6d5c08a015d274056b201c50c007a98
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 67df51584843e3c9930ad0af0ef742cccb52f4f3
https://github.com/Perl/perl5/commit/67df51584843e3c9930ad0af0ef742cccb52f4f3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: d84877e3dfeb42a3e4462b236fa077012146f7c6
https://github.com/Perl/perl5/commit/d84877e3dfeb42a3e4462b236fa077012146f7c6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: cd5bd6ad3cde6b07f0d5df8a7313a5643b0b562e
https://github.com/Perl/perl5/commit/cd5bd6ad3cde6b07f0d5df8a7313a5643b0b562e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 46bbb096a9bfd35e327577268a9fadae99c17979
https://github.com/Perl/perl5/commit/46bbb096a9bfd35e327577268a9fadae99c17979
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 56785c7041612c2f4da9a40335b980e2e5d76270
https://github.com/Perl/perl5/commit/56785c7041612c2f4da9a40335b980e2e5d76270
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 0579a76923a3a7b1d198603afc21e425cb069e62
https://github.com/Perl/perl5/commit/0579a76923a3a7b1d198603afc21e425cb069e62
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 43f9c94c6265cfda00f6f6a176fee5ee54e0ed46
https://github.com/Perl/perl5/commit/43f9c94c6265cfda00f6f6a176fee5ee54e0ed46
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 9c17cf7cfb5bad481280a702a1375e7a3406379a
https://github.com/Perl/perl5/commit/9c17cf7cfb5bad481280a702a1375e7a3406379a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 16b5d460b3ee8fe9c3d321e5c472047d22df242b
https://github.com/Perl/perl5/commit/16b5d460b3ee8fe9c3d321e5c472047d22df242b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 0ba1eaa0b21ef7a4d58203b3d5d76da4a5bb1aa9
https://github.com/Perl/perl5/commit/0ba1eaa0b21ef7a4d58203b3d5d76da4a5bb1aa9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: f3b2dc67571fe9c3cba77b97ac5964b629b45c16
https://github.com/Perl/perl5/commit/f3b2dc67571fe9c3cba77b97ac5964b629b45c16
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: a7ac1a1d69016d041186cd353190ae687473002a
https://github.com/Perl/perl5/commit/a7ac1a1d69016d041186cd353190ae687473002a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 7b76fe16f1b88d87d6aaaf13c08ffe05c29555f1
https://github.com/Perl/perl5/commit/7b76fe16f1b88d87d6aaaf13c08ffe05c29555f1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 135931e5904dbe21ef81fdf5b861a63c61d29744
https://github.com/Perl/perl5/commit/135931e5904dbe21ef81fdf5b861a63c61d29744
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 25986ac899b30195ba4bc2d53e402e9cf0553180
https://github.com/Perl/perl5/commit/25986ac899b30195ba4bc2d53e402e9cf0553180
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 2f950be5fb9b19a8f91771b5defc1fd51bbee762
https://github.com/Perl/perl5/commit/2f950be5fb9b19a8f91771b5defc1fd51bbee762
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 0335b52e2f217402fb56978528ae9810f9953bbb
https://github.com/Perl/perl5/commit/0335b52e2f217402fb56978528ae9810f9953bbb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: a5df8e71a1a9579e2e9669e5fc016781067a22d4
https://github.com/Perl/perl5/commit/a5df8e71a1a9579e2e9669e5fc016781067a22d4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: ed1d340c00f8396eb86e438ba34ad71b8b8e8a1c
https://github.com/Perl/perl5/commit/ed1d340c00f8396eb86e438ba34ad71b8b8e8a1c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 6356d1ffdf872f8de5746e3625def8cad83470c9
https://github.com/Perl/perl5/commit/6356d1ffdf872f8de5746e3625def8cad83470c9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 4432cdec6d845b6eb95df7547301465da2382820
https://github.com/Perl/perl5/commit/4432cdec6d845b6eb95df7547301465da2382820
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 8ca2e0a8668b315af3da9183f14ef1c0c5313613
https://github.com/Perl/perl5/commit/8ca2e0a8668b315af3da9183f14ef1c0c5313613
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 09fc605d74f6f3e0594100ec44fecdd354352ad9
https://github.com/Perl/perl5/commit/09fc605d74f6f3e0594100ec44fecdd354352ad9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 46cbd06104b1ae0ad7065e487a089f6b7dc51f4b
https://github.com/Perl/perl5/commit/46cbd06104b1ae0ad7065e487a089f6b7dc51f4b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: fd25cf812f26c98a52d4e89a562102eecee574d5
https://github.com/Perl/perl5/commit/fd25cf812f26c98a52d4e89a562102eecee574d5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 159b891dd47204972b370c5980983cccd9bd3b1c
https://github.com/Perl/perl5/commit/159b891dd47204972b370c5980983cccd9bd3b1c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 673c12dccd8993f82871ea12da8ffef7e8dae628
https://github.com/Perl/perl5/commit/673c12dccd8993f82871ea12da8ffef7e8dae628
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 6659eea378b7508e2f27861da3a5cd5774f7eb85
https://github.com/Perl/perl5/commit/6659eea378b7508e2f27861da3a5cd5774f7eb85
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 3d5ace4096dd6670f9d46f4ed89c04bbbaa93927
https://github.com/Perl/perl5/commit/3d5ace4096dd6670f9d46f4ed89c04bbbaa93927
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: e2407034fa16383166fe5714a53816626ec6987b
https://github.com/Perl/perl5/commit/e2407034fa16383166fe5714a53816626ec6987b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 127c522e31d12c0886369c99df678ee898762dc1
https://github.com/Perl/perl5/commit/127c522e31d12c0886369c99df678ee898762dc1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 731925631e7375d3a9d460cd45e8d8789c6f4f4b
https://github.com/Perl/perl5/commit/731925631e7375d3a9d460cd45e8d8789c6f4f4b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: aa70b8a0f57c7241699fcddad89ae19e4085b38a
https://github.com/Perl/perl5/commit/aa70b8a0f57c7241699fcddad89ae19e4085b38a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cf2c47bb20fb58b60264108a3510e0fe7e4ef6ab
https://github.com/Perl/perl5/commit/cf2c47bb20fb58b60264108a3510e0fe7e4ef6ab
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 8a24d23c32c902191e03e02b2c26e5b32014f678
https://github.com/Perl/perl5/commit/8a24d23c32c902191e03e02b2c26e5b32014f678
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 5d245936d4e0231bc19746560c483528bb25caad
https://github.com/Perl/perl5/commit/5d245936d4e0231bc19746560c483528bb25caad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 6722b741d49f3b652ac4ccc88b2967fecc04dbf9
https://github.com/Perl/perl5/commit/6722b741d49f3b652ac4ccc88b2967fecc04dbf9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: ca83963ea4ba2cf24a6a168a77c9d12fa802eced
https://github.com/Perl/perl5/commit/ca83963ea4ba2cf24a6a168a77c9d12fa802eced
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: fb29fd2d2fb63104b06be49256a2b68ce1c9f091
https://github.com/Perl/perl5/commit/fb29fd2d2fb63104b06be49256a2b68ce1c9f091
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2756aaac8c3bb934686812124a15546bde8be27a
https://github.com/Perl/perl5/commit/2756aaac8c3bb934686812124a15546bde8be27a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 924c08dfa79acee7121e8e011573d9e91fe15397
https://github.com/Perl/perl5/commit/924c08dfa79acee7121e8e011573d9e91fe15397
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 37ce845d64db5d72445698a8d847986ddf0ca019
https://github.com/Perl/perl5/commit/37ce845d64db5d72445698a8d847986ddf0ca019
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 124358f2176dd22535e868b02699b995333693c7
https://github.com/Perl/perl5/commit/124358f2176dd22535e868b02699b995333693c7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 383715911174c574a976f1bcdbb9e8f5b28e2603
https://github.com/Perl/perl5/commit/383715911174c574a976f1bcdbb9e8f5b28e2603
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: e4d0bcf796b6457e6630016e1447e745f00512c5
https://github.com/Perl/perl5/commit/e4d0bcf796b6457e6630016e1447e745f00512c5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 4f8ccb044587a375137ea0af021b9c1590c78937
https://github.com/Perl/perl5/commit/4f8ccb044587a375137ea0af021b9c1590c78937
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 2a11488e1590f0f0ace292711a69cb76af0bba3e
https://github.com/Perl/perl5/commit/2a11488e1590f0f0ace292711a69cb76af0bba3e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
run/locale.t temp win
Commit: 959bcbb3541c5b9b29f525817bcfbad9ac9b32e1
https://github.com/Perl/perl5/commit/959bcbb3541c5b9b29f525817bcfbad9ac9b32e1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: b2e1d2b2d3cf2dd6fa44bd54f0996c673813109f
https://github.com/Perl/perl5/commit/b2e1d2b2d3cf2dd6fa44bd54f0996c673813109f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Change tabs to blanks; Fix indentation
Remove some unneeded blank lines
Commit: 89dfbd3e90803740dc1faeff85534cd452ae3700
https://github.com/Perl/perl5/commit/89dfbd3e90803740dc1faeff85534cd452ae3700
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil
Commit: 8caef63638a98bb7474579e792cb6cc75d689057
https://github.com/Perl/perl5/commit/8caef63638a98bb7474579e792cb6cc75d689057
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: a72eda493f0a38c2225f94cbee4a26805dc3c34b
https://github.com/Perl/perl5/commit/a72eda493f0a38c2225f94cbee4a26805dc3c34b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
loc_tools: debug, white space
Commit: f8c0c4bd00ede3f21787661e75190c2a72de0e42
https://github.com/Perl/perl5/commit/f8c0c4bd00ede3f21787661e75190c2a72de0e42
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 4477f12d7c9e013bccf19f61ce946fe005033f16
https://github.com/Perl/perl5/commit/4477f12d7c9e013bccf19f61ce946fe005033f16
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 99a74df7fa30eedd9d87660e49a77e23f10fee55
https://github.com/Perl/perl5/commit/99a74df7fa30eedd9d87660e49a77e23f10fee55
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy
Commit: cac1173b1f08de6b7dccf91beaf6a16205dcc35b
https://github.com/Perl/perl5/commit/cac1173b1f08de6b7dccf91beaf6a16205dcc35b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 1ac672811d23a4f832e0c3a752923b4122fa94b7
https://github.com/Perl/perl5/commit/1ac672811d23a4f832e0c3a752923b4122fa94b7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
f stdsize
Commit: 3c0a58f642bd1660caddd2707a02de1420d6d07f
https://github.com/Perl/perl5/commit/3c0a58f642bd1660caddd2707a02de1420d6d07f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
debug stdized
Commit: 526115f2eaba8a111e0a7d044b681113f73a3f2d
https://github.com/Perl/perl5/commit/526115f2eaba8a111e0a7d044b681113f73a3f2d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 5312d8c1cb1e134319065631c29c766af674bad8
https://github.com/Perl/perl5/commit/5312d8c1cb1e134319065631c29c766af674bad8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 3688f62b3f99d92198e38ee34e36274b275cc840
https://github.com/Perl/perl5/commit/3688f62b3f99d92198e38ee34e36274b275cc840
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
f strxfrm errno
Commit: 3965f4feacfeb6cbbe040583a09dc0dfce462da6
https://github.com/Perl/perl5/commit/3965f4feacfeb6cbbe040583a09dc0dfce462da6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M t/re/pat.t
Log Message:
-----------
re/pat.t: Skip locale tests if no locales available
Commit: b15e6378f369ec860209819024715995e40aecf3
https://github.com/Perl/perl5/commit/b15e6378f369ec860209819024715995e40aecf3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M sv.c
Log Message:
-----------
f sv.c Init fold array
Commit: ab306b0806b3997101d29e05162ee96e0c3476bb
https://github.com/Perl/perl5/commit/ab306b0806b3997101d29e05162ee96e0c3476bb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-28 (Sun, 28 Mar 2021)
Changed paths:
M embed.fnc
Log Message:
-----------
f save_to_buffer ignore return
Compare: https://github.com/Perl/perl5/compare/611c4e00707c...ab306b0806b3
