Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: c4b30f06a55dbe767361137fe43a5892c1bc47a9
https://github.com/Perl/perl5/commit/c4b30f06a55dbe767361137fe43a5892c1bc47a9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/re/pat.t
Log Message:
-----------
re/pat.t: Skip locale tests if no locales available
Commit: 232687b96b247d5efba666ec73067ce3daf1d1f9
https://github.com/Perl/perl5/commit/232687b96b247d5efba666ec73067ce3daf1d1f9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 258ca6ad43da133373fae61bf00aec020a5278ce
https://github.com/Perl/perl5/commit/258ca6ad43da133373fae61bf00aec020a5278ce
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: f6a86784734ec9f599683016b94578dc2cd83913
https://github.com/Perl/perl5/commit/f6a86784734ec9f599683016b94578dc2cd83913
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 23b02baa7d1277c5294f447def3867a952fd5f4d
https://github.com/Perl/perl5/commit/23b02baa7d1277c5294f447def3867a952fd5f4d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: db6d202f721e06166a96ead29a44db9451ef98ee
https://github.com/Perl/perl5/commit/db6d202f721e06166a96ead29a44db9451ef98ee
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: c8b4c5836dc843e9a507bfe6703b3d5aaa0c8385
https://github.com/Perl/perl5/commit/c8b4c5836dc843e9a507bfe6703b3d5aaa0c8385
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 89311b226d453efa14823b6673fee4b205655e53
https://github.com/Perl/perl5/commit/89311b226d453efa14823b6673fee4b205655e53
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 591bf736081a868005d691199e49405311fa618c
https://github.com/Perl/perl5/commit/591bf736081a868005d691199e49405311fa618c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: e71c9d3c65560211ce7a57b7022d25a8f38f22da
https://github.com/Perl/perl5/commit/e71c9d3c65560211ce7a57b7022d25a8f38f22da
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 4e3dbcdb41146ddecf36abc38c195a343e5d36b8
https://github.com/Perl/perl5/commit/4e3dbcdb41146ddecf36abc38c195a343e5d36b8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 9a3449840349d90ac83b386affa176f4d36c46e5
https://github.com/Perl/perl5/commit/9a3449840349d90ac83b386affa176f4d36c46e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 69c20253f13247f5a262203cedf4054bcf4eef3a
https://github.com/Perl/perl5/commit/69c20253f13247f5a262203cedf4054bcf4eef3a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: a482acc9809b1e307e1c1f32e37c0444bb39aece
https://github.com/Perl/perl5/commit/a482acc9809b1e307e1c1f32e37c0444bb39aece
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: ff470c14b3f5b00b61723e5dac416fc8418467f4
https://github.com/Perl/perl5/commit/ff470c14b3f5b00b61723e5dac416fc8418467f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 08cfed3d5c8a451bb148c864fdb1018ab4cb6a4e
https://github.com/Perl/perl5/commit/08cfed3d5c8a451bb148c864fdb1018ab4cb6a4e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: a30b7bbddad25e0013351516b6beff0cd4a4c34e
https://github.com/Perl/perl5/commit/a30b7bbddad25e0013351516b6beff0cd4a4c34e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: c9ee4a668f16ca4cb4b821ffc806c3b493958a6c
https://github.com/Perl/perl5/commit/c9ee4a668f16ca4cb4b821ffc806c3b493958a6c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: e375740a759690c5568266bcc88ff21ccfd8bbd4
https://github.com/Perl/perl5/commit/e375740a759690c5568266bcc88ff21ccfd8bbd4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: c91628ac6b76b737bf0206b6b32c717d3e4ffb3b
https://github.com/Perl/perl5/commit/c91628ac6b76b737bf0206b6b32c717d3e4ffb3b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 80a3ff6e938273e35de9ce68a361fa251ad0bee7
https://github.com/Perl/perl5/commit/80a3ff6e938273e35de9ce68a361fa251ad0bee7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: a207f0824150f466a4c9b773d077aa1ee28d59d8
https://github.com/Perl/perl5/commit/a207f0824150f466a4c9b773d077aa1ee28d59d8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 4a7caa60ede6b026ce4f934df426b0328fccd1f0
https://github.com/Perl/perl5/commit/4a7caa60ede6b026ce4f934df426b0328fccd1f0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: fc9a90034e8848b72dbe505cd996b5ec5164ec4c
https://github.com/Perl/perl5/commit/fc9a90034e8848b72dbe505cd996b5ec5164ec4c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: b2a46c9c583f1b8556d9310bf8cc087d12090709
https://github.com/Perl/perl5/commit/b2a46c9c583f1b8556d9310bf8cc087d12090709
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: ed1b28188b7529e2196fca6ebbb1ca337b97c4f5
https://github.com/Perl/perl5/commit/ed1b28188b7529e2196fca6ebbb1ca337b97c4f5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: e64067a4b3498b1fd630f9197965722febfe50b8
https://github.com/Perl/perl5/commit/e64067a4b3498b1fd630f9197965722febfe50b8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 40886a80abbe271c1f387bbb30420b001e470889
https://github.com/Perl/perl5/commit/40886a80abbe271c1f387bbb30420b001e470889
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: c0a31c691a3f3aba373fbf087317bd8ba8b7c9e9
https://github.com/Perl/perl5/commit/c0a31c691a3f3aba373fbf087317bd8ba8b7c9e9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: f537b9fa54955b9b4a1dd3d804e7f2d813b892a7
https://github.com/Perl/perl5/commit/f537b9fa54955b9b4a1dd3d804e7f2d813b892a7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 86838db01328cdbce22cb600e7c05667c7c50148
https://github.com/Perl/perl5/commit/86838db01328cdbce22cb600e7c05667c7c50148
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: ad406310667007948db5afcce83acf6a02e868ad
https://github.com/Perl/perl5/commit/ad406310667007948db5afcce83acf6a02e868ad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 023d0b1212516bad02d2ed777f2f56e7aae37ec6
https://github.com/Perl/perl5/commit/023d0b1212516bad02d2ed777f2f56e7aae37ec6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: bb8f597dd628faaf55efe5faa1302af14967aa76
https://github.com/Perl/perl5/commit/bb8f597dd628faaf55efe5faa1302af14967aa76
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 0e6960b832e7b2c26b6933123f025291111b6e5f
https://github.com/Perl/perl5/commit/0e6960b832e7b2c26b6933123f025291111b6e5f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 619b8058529a6b1ae58e06b04981ac8ba069af11
https://github.com/Perl/perl5/commit/619b8058529a6b1ae58e06b04981ac8ba069af11
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: ecc6714112ee1de03b88570cfa99b2e5e4e45ac6
https://github.com/Perl/perl5/commit/ecc6714112ee1de03b88570cfa99b2e5e4e45ac6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 9a71606fae97d201bcf7362d10ea25c93702b643
https://github.com/Perl/perl5/commit/9a71606fae97d201bcf7362d10ea25c93702b643
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: ad5da59c0a7dbaf464a7a581ff7a884d05098490
https://github.com/Perl/perl5/commit/ad5da59c0a7dbaf464a7a581ff7a884d05098490
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: d8cc1f0d2abd62bea00ce419079c62252676590e
https://github.com/Perl/perl5/commit/d8cc1f0d2abd62bea00ce419079c62252676590e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 29476a9d07ca16f6236897b5da8ef267ee69c60b
https://github.com/Perl/perl5/commit/29476a9d07ca16f6236897b5da8ef267ee69c60b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 84fe9fb0a8b607e3af13979936823a004f3ff619
https://github.com/Perl/perl5/commit/84fe9fb0a8b607e3af13979936823a004f3ff619
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 8eba8b3cf78afc29bba675ef224894f9ed018c50
https://github.com/Perl/perl5/commit/8eba8b3cf78afc29bba675ef224894f9ed018c50
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: abf5be424422c973692291489d79612f979b8cb3
https://github.com/Perl/perl5/commit/abf5be424422c973692291489d79612f979b8cb3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: ee8513837a2e2b74a4c2e61bae8061d5b48df043
https://github.com/Perl/perl5/commit/ee8513837a2e2b74a4c2e61bae8061d5b48df043
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 514b273559d608bddd159e8ba71981370ba595b9
https://github.com/Perl/perl5/commit/514b273559d608bddd159e8ba71981370ba595b9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 36219d5e2aacf962e602b0d8ccd4a7684e0d96d1
https://github.com/Perl/perl5/commit/36219d5e2aacf962e602b0d8ccd4a7684e0d96d1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: e06ea620eb946768d886d0604ff6fcf2dcf86059
https://github.com/Perl/perl5/commit/e06ea620eb946768d886d0604ff6fcf2dcf86059
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 1fd5b3ab200eda100a2498cf75e882c3306b22c8
https://github.com/Perl/perl5/commit/1fd5b3ab200eda100a2498cf75e882c3306b22c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: d938782b75272ba44db6f770651276b865c09190
https://github.com/Perl/perl5/commit/d938782b75272ba44db6f770651276b865c09190
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 9d31d448aabc8ae9dfe6f0433a55b9eb87cc100f
https://github.com/Perl/perl5/commit/9d31d448aabc8ae9dfe6f0433a55b9eb87cc100f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: bb776266c3d8c617097cb67ae79286ab2fddf3da
https://github.com/Perl/perl5/commit/bb776266c3d8c617097cb67ae79286ab2fddf3da
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: ddb1c6bf3f9acc2b81cb60f893025a3b6741ba5c
https://github.com/Perl/perl5/commit/ddb1c6bf3f9acc2b81cb60f893025a3b6741ba5c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 16d7d0d310b87d7b5a73cf5f13171528c772d622
https://github.com/Perl/perl5/commit/16d7d0d310b87d7b5a73cf5f13171528c772d622
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 72d78932cdd7a63bfb913385164e98ad41013b57
https://github.com/Perl/perl5/commit/72d78932cdd7a63bfb913385164e98ad41013b57
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: be44754b290a7bf5469731294b29754f61aa9e41
https://github.com/Perl/perl5/commit/be44754b290a7bf5469731294b29754f61aa9e41
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 1c76b95c1b85cfba04ac3f7c7e0d02ebe6bab98d
https://github.com/Perl/perl5/commit/1c76b95c1b85cfba04ac3f7c7e0d02ebe6bab98d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: df0a4ec0522eee65c0cd9fe52b49a92fc2ed6eb4
https://github.com/Perl/perl5/commit/df0a4ec0522eee65c0cd9fe52b49a92fc2ed6eb4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: ea598802a0aa873dafbf2c388279096fd03a0d89
https://github.com/Perl/perl5/commit/ea598802a0aa873dafbf2c388279096fd03a0d89
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: a22f17ccf6fa676bceff87541b577ef42544041c
https://github.com/Perl/perl5/commit/a22f17ccf6fa676bceff87541b577ef42544041c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 5e946f918ac118a4f9ff3c7ba505eaa34a4aac88
https://github.com/Perl/perl5/commit/5e946f918ac118a4f9ff3c7ba505eaa34a4aac88
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 7ab4af107fb5082dcda9443cb930fa681be7e229
https://github.com/Perl/perl5/commit/7ab4af107fb5082dcda9443cb930fa681be7e229
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: d31dc76d4405e847a28523e9ddc011c30485f051
https://github.com/Perl/perl5/commit/d31dc76d4405e847a28523e9ddc011c30485f051
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 0c78349b3a44b4720a3c2e9fb34d3a0c94b2d7ea
https://github.com/Perl/perl5/commit/0c78349b3a44b4720a3c2e9fb34d3a0c94b2d7ea
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 4b9eb0616930787d8908b4a13880efa3795f9390
https://github.com/Perl/perl5/commit/4b9eb0616930787d8908b4a13880efa3795f9390
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: dc67260f48496cf7b39801e98f4c4b3041937c0b
https://github.com/Perl/perl5/commit/dc67260f48496cf7b39801e98f4c4b3041937c0b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 344f7370b8c2eb6c1c2a1aabc80fc34e26f60cfb
https://github.com/Perl/perl5/commit/344f7370b8c2eb6c1c2a1aabc80fc34e26f60cfb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 080ae2ee7a1c9b82d6b21669ee62b6113bc8487b
https://github.com/Perl/perl5/commit/080ae2ee7a1c9b82d6b21669ee62b6113bc8487b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: ae20f2170e391059130d136ea7887cf1264c51c2
https://github.com/Perl/perl5/commit/ae20f2170e391059130d136ea7887cf1264c51c2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 521b0c1de2f7e3072d56437a6cde580b7b943b13
https://github.com/Perl/perl5/commit/521b0c1de2f7e3072d56437a6cde580b7b943b13
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 29426674ee008ff7a53059f47914ef70a45c1546
https://github.com/Perl/perl5/commit/29426674ee008ff7a53059f47914ef70a45c1546
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 65444cbffb9e8091949228553ba9de59e176d16e
https://github.com/Perl/perl5/commit/65444cbffb9e8091949228553ba9de59e176d16e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 9feb31fdb138b9089d2a409761c60f0de23dc52c
https://github.com/Perl/perl5/commit/9feb31fdb138b9089d2a409761c60f0de23dc52c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 81f6fa6bcca4b5298d46c8ff52999ec38762ae44
https://github.com/Perl/perl5/commit/81f6fa6bcca4b5298d46c8ff52999ec38762ae44
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 7eee06610a39393efea9bfdeab3e79185cca2266
https://github.com/Perl/perl5/commit/7eee06610a39393efea9bfdeab3e79185cca2266
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 15e15b4d13235e2dcadce6026b789e26433311ca
https://github.com/Perl/perl5/commit/15e15b4d13235e2dcadce6026b789e26433311ca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 491b85948f386818d7ae64db622240d8630d3aca
https://github.com/Perl/perl5/commit/491b85948f386818d7ae64db622240d8630d3aca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: fc1ca3ab6a44b2b65aa4e8e09b8ebddb5d596d47
https://github.com/Perl/perl5/commit/fc1ca3ab6a44b2b65aa4e8e09b8ebddb5d596d47
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 141a2d063b36913fa476459f3f9ae65989fccb5f
https://github.com/Perl/perl5/commit/141a2d063b36913fa476459f3f9ae65989fccb5f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: dc77d0a56483ae7bbac73b6bdd0ab93c287f6b69
https://github.com/Perl/perl5/commit/dc77d0a56483ae7bbac73b6bdd0ab93c287f6b69
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 3e63ad1ae3f750c8436234b557c115d6470471cf
https://github.com/Perl/perl5/commit/3e63ad1ae3f750c8436234b557c115d6470471cf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 4ea2cb08c3ea90de97176f0d8273570875e0d988
https://github.com/Perl/perl5/commit/4ea2cb08c3ea90de97176f0d8273570875e0d988
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 0881a2a448dc21ae41c99ce2a705b456c6811a3f
https://github.com/Perl/perl5/commit/0881a2a448dc21ae41c99ce2a705b456c6811a3f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: fb93ebad927d4450dc0ccd46000b6df82aa97fa6
https://github.com/Perl/perl5/commit/fb93ebad927d4450dc0ccd46000b6df82aa97fa6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: dacf5c09ab4b9aae4852435d32fefddf20651e9d
https://github.com/Perl/perl5/commit/dacf5c09ab4b9aae4852435d32fefddf20651e9d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: c18b5f7b22e87288e42d351f06bacf83f7a69125
https://github.com/Perl/perl5/commit/c18b5f7b22e87288e42d351f06bacf83f7a69125
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 8285ccf4159457659940412b88312e6afd9bd1df
https://github.com/Perl/perl5/commit/8285ccf4159457659940412b88312e6afd9bd1df
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: e7b815964b60938f3ab4e3e041777345970b2f56
https://github.com/Perl/perl5/commit/e7b815964b60938f3ab4e3e041777345970b2f56
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: b7b0059b6fa823f57d496cd46a50270a364d5027
https://github.com/Perl/perl5/commit/b7b0059b6fa823f57d496cd46a50270a364d5027
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: e9f7497731d12c6565257f6de9178a60e6137bbd
https://github.com/Perl/perl5/commit/e9f7497731d12c6565257f6de9178a60e6137bbd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 290f6518d75475e5cede40da2b4c0825401db5b3
https://github.com/Perl/perl5/commit/290f6518d75475e5cede40da2b4c0825401db5b3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 8a53ade9e9eaa54299d6a1080956552bbcda1ff7
https://github.com/Perl/perl5/commit/8a53ade9e9eaa54299d6a1080956552bbcda1ff7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 1d61dca314814888a658350c17397cc0db8483ad
https://github.com/Perl/perl5/commit/1d61dca314814888a658350c17397cc0db8483ad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: a0d4b3abba6e14fdb8f2eaa8897aae94492f3f44
https://github.com/Perl/perl5/commit/a0d4b3abba6e14fdb8f2eaa8897aae94492f3f44
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 48fd6c69d0728cf177598954663ab92beb17b124
https://github.com/Perl/perl5/commit/48fd6c69d0728cf177598954663ab92beb17b124
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 5cceca481ea41738fa2adafbf29e4cff27677e13
https://github.com/Perl/perl5/commit/5cceca481ea41738fa2adafbf29e4cff27677e13
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: d9b6e75937d9372ffd45b6e4610d6c4fa0437a45
https://github.com/Perl/perl5/commit/d9b6e75937d9372ffd45b6e4610d6c4fa0437a45
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: e3ed9580509d0c5b5b2cc18cedd7885fcd33108c
https://github.com/Perl/perl5/commit/e3ed9580509d0c5b5b2cc18cedd7885fcd33108c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 3da633f602f961db56bc0c5f8bfa1afc4ffa0423
https://github.com/Perl/perl5/commit/3da633f602f961db56bc0c5f8bfa1afc4ffa0423
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: acf6f39868a7cb693792a8cf1c599d171fd57670
https://github.com/Perl/perl5/commit/acf6f39868a7cb693792a8cf1c599d171fd57670
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 8b8c70ed50617536df8b07cc48fff707b12991f0
https://github.com/Perl/perl5/commit/8b8c70ed50617536df8b07cc48fff707b12991f0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 87fb143563b5a9c9baf32ede3c11a1f62b6c4b21
https://github.com/Perl/perl5/commit/87fb143563b5a9c9baf32ede3c11a1f62b6c4b21
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: a3431da49eb0fe81613b4af832e7a6cf6e69195e
https://github.com/Perl/perl5/commit/a3431da49eb0fe81613b4af832e7a6cf6e69195e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 91867f739ab69fbea08117e1be9695efa2c1b13b
https://github.com/Perl/perl5/commit/91867f739ab69fbea08117e1be9695efa2c1b13b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: a0364765d229b043280f663e64940366dabc3fab
https://github.com/Perl/perl5/commit/a0364765d229b043280f663e64940366dabc3fab
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: affd19a4f1650b0af898e89ba19a8a6a390cd7fe
https://github.com/Perl/perl5/commit/affd19a4f1650b0af898e89ba19a8a6a390cd7fe
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 0b7214a51e4d22e309a1b47c549c78ffb9386131
https://github.com/Perl/perl5/commit/0b7214a51e4d22e309a1b47c549c78ffb9386131
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 18a1cc9ab6b84ffcf4e9a369bad0ad202e2122ad
https://github.com/Perl/perl5/commit/18a1cc9ab6b84ffcf4e9a369bad0ad202e2122ad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 47768a4db842bfa53ddce0966476639e0cf43016
https://github.com/Perl/perl5/commit/47768a4db842bfa53ddce0966476639e0cf43016
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: c8239eb40424cd1870d1763c439c4da2cabc67af
https://github.com/Perl/perl5/commit/c8239eb40424cd1870d1763c439c4da2cabc67af
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 8ca444a7cd89ab73baf2d6ad8ac0cd3d963ccff6
https://github.com/Perl/perl5/commit/8ca444a7cd89ab73baf2d6ad8ac0cd3d963ccff6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: b49023cdaa315b0492f676d33e53caae0ea73e66
https://github.com/Perl/perl5/commit/b49023cdaa315b0492f676d33e53caae0ea73e66
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 474f555eec29a6df4dafd0459ffbb4ff0a9f2e73
https://github.com/Perl/perl5/commit/474f555eec29a6df4dafd0459ffbb4ff0a9f2e73
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: a7c02212c288ca97f1bef1b8de3285e9e55962c8
https://github.com/Perl/perl5/commit/a7c02212c288ca97f1bef1b8de3285e9e55962c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: eef6fe3c0a87461b9a008df5a83c82eb3477e420
https://github.com/Perl/perl5/commit/eef6fe3c0a87461b9a008df5a83c82eb3477e420
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 5e394b88621f89fd4e6921339b14a7d38494d4bf
https://github.com/Perl/perl5/commit/5e394b88621f89fd4e6921339b14a7d38494d4bf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 30e07a94c4acfaed23c4d011654f0f72be90a42e
https://github.com/Perl/perl5/commit/30e07a94c4acfaed23c4d011654f0f72be90a42e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 3e243d02d6777ef1c52c59594f63d17bdb8761f9
https://github.com/Perl/perl5/commit/3e243d02d6777ef1c52c59594f63d17bdb8761f9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 2424b1a79a30bb40f41040424256f72c21f2350a
https://github.com/Perl/perl5/commit/2424b1a79a30bb40f41040424256f72c21f2350a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: c3ae7433b34094442d19e0349feb5edade418586
https://github.com/Perl/perl5/commit/c3ae7433b34094442d19e0349feb5edade418586
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: df2a83be5c97f34ccba5ece3244b88511f761752
https://github.com/Perl/perl5/commit/df2a83be5c97f34ccba5ece3244b88511f761752
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 95c8d631826cbecb79206ee49e808877549560f3
https://github.com/Perl/perl5/commit/95c8d631826cbecb79206ee49e808877549560f3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: c74195b0fab218129718161e4021ad1f31fa9657
https://github.com/Perl/perl5/commit/c74195b0fab218129718161e4021ad1f31fa9657
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 200cb525f6cddefb7594a8c38566ee16bf2731c3
https://github.com/Perl/perl5/commit/200cb525f6cddefb7594a8c38566ee16bf2731c3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 4f3390fe780e9f6dbfe2d4fb02284c015a575de4
https://github.com/Perl/perl5/commit/4f3390fe780e9f6dbfe2d4fb02284c015a575de4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 2eacdf53a1f33c988a420a47a0b8d6ed162fb0b1
https://github.com/Perl/perl5/commit/2eacdf53a1f33c988a420a47a0b8d6ed162fb0b1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 770fa2129bb9c2d87421dcb34de12aad94251217
https://github.com/Perl/perl5/commit/770fa2129bb9c2d87421dcb34de12aad94251217
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 8185345e5626d812e77466325c0436e7db3a650e
https://github.com/Perl/perl5/commit/8185345e5626d812e77466325c0436e7db3a650e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: f9ff1aace0963c899070cd3f40bafc6f06dca493
https://github.com/Perl/perl5/commit/f9ff1aace0963c899070cd3f40bafc6f06dca493
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 569727c611509aab282e65f9e36e0366be5b2c98
https://github.com/Perl/perl5/commit/569727c611509aab282e65f9e36e0366be5b2c98
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 336fa20d53f7067deac4ff1723c46ef6b4715c40
https://github.com/Perl/perl5/commit/336fa20d53f7067deac4ff1723c46ef6b4715c40
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 605ae861ef100467ee49c6df132c8005e40d7d08
https://github.com/Perl/perl5/commit/605ae861ef100467ee49c6df132c8005e40d7d08
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: fc20b45212ec3ea1a70658c7257985729ec55426
https://github.com/Perl/perl5/commit/fc20b45212ec3ea1a70658c7257985729ec55426
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 85a8aead415770c4fdb90a122abf31c4b1251b7a
https://github.com/Perl/perl5/commit/85a8aead415770c4fdb90a122abf31c4b1251b7a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 18a64da422e411ef70600763f07d7fb2a26ec55f
https://github.com/Perl/perl5/commit/18a64da422e411ef70600763f07d7fb2a26ec55f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 041e223953510c10be5050ce6f8b4ab461a5b45a
https://github.com/Perl/perl5/commit/041e223953510c10be5050ce6f8b4ab461a5b45a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 7c9d76f53b2712d7979f3ae67312d39cdd3a8f0b
https://github.com/Perl/perl5/commit/7c9d76f53b2712d7979f3ae67312d39cdd3a8f0b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 85d43d430bd2bdff4499edb12c0a1a71006baf6e
https://github.com/Perl/perl5/commit/85d43d430bd2bdff4499edb12c0a1a71006baf6e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 5ab969a3b69e423756ff66304096e4d6f48d9ba5
https://github.com/Perl/perl5/commit/5ab969a3b69e423756ff66304096e4d6f48d9ba5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 32a5494a907edcd8b42b4e2c1ce5f9264d4667f1
https://github.com/Perl/perl5/commit/32a5494a907edcd8b42b4e2c1ce5f9264d4667f1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: b9625425bb850720782ce18cec41521ebaf7e513
https://github.com/Perl/perl5/commit/b9625425bb850720782ce18cec41521ebaf7e513
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 600882281b0c6ab249b17ec4915bbc13acce556d
https://github.com/Perl/perl5/commit/600882281b0c6ab249b17ec4915bbc13acce556d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 44c58cdbe3903d125a1d4069fc21825a7cceee32
https://github.com/Perl/perl5/commit/44c58cdbe3903d125a1d4069fc21825a7cceee32
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: e8322a8d8abe878c6d40426af9533124c5a6e4eb
https://github.com/Perl/perl5/commit/e8322a8d8abe878c6d40426af9533124c5a6e4eb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 4752e20bbb109548be35b6729910e1e69a97af9e
https://github.com/Perl/perl5/commit/4752e20bbb109548be35b6729910e1e69a97af9e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 5f21933d4bbdbc072aa840ef343f0c5a663c50a7
https://github.com/Perl/perl5/commit/5f21933d4bbdbc072aa840ef343f0c5a663c50a7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 57d1e7ed49d6b49eeb8dc0c1d87228bf5a0ba452
https://github.com/Perl/perl5/commit/57d1e7ed49d6b49eeb8dc0c1d87228bf5a0ba452
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: f2a38eb04a3fe233b653dea905cb459a7d02d112
https://github.com/Perl/perl5/commit/f2a38eb04a3fe233b653dea905cb459a7d02d112
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 10398e510ae939ec9dc58e029b2ec15db5f3dde5
https://github.com/Perl/perl5/commit/10398e510ae939ec9dc58e029b2ec15db5f3dde5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: e0d1edec98d6c30f0f90b663043992fd28e1f6c0
https://github.com/Perl/perl5/commit/e0d1edec98d6c30f0f90b663043992fd28e1f6c0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 076649839fe894e93039ff9feca97755ebf77c5e
https://github.com/Perl/perl5/commit/076649839fe894e93039ff9feca97755ebf77c5e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: aa0e551628bf6a0926a5c5548287d0ecce7a3ade
https://github.com/Perl/perl5/commit/aa0e551628bf6a0926a5c5548287d0ecce7a3ade
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: a65920f20eb805120a9b1a6484250c1aebf85c5d
https://github.com/Perl/perl5/commit/a65920f20eb805120a9b1a6484250c1aebf85c5d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: a8e64285427d012cc92d7e3e038aa284c7358a56
https://github.com/Perl/perl5/commit/a8e64285427d012cc92d7e3e038aa284c7358a56
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: ad25556cf41822cee1add14dcda03f84effb9d33
https://github.com/Perl/perl5/commit/ad25556cf41822cee1add14dcda03f84effb9d33
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 8f860c31398c2bddd12c059ede396336e989ea35
https://github.com/Perl/perl5/commit/8f860c31398c2bddd12c059ede396336e989ea35
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 573baf39b275fbfdd0b479c4adaa0ddfaa2a6610
https://github.com/Perl/perl5/commit/573baf39b275fbfdd0b479c4adaa0ddfaa2a6610
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 8b7d8ee97655068360fcb36afe4dc996de997317
https://github.com/Perl/perl5/commit/8b7d8ee97655068360fcb36afe4dc996de997317
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: b3e8b7494568bb1becdbf4d897c37008410f2a3b
https://github.com/Perl/perl5/commit/b3e8b7494568bb1becdbf4d897c37008410f2a3b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: f735fab2aa25148d9c19fe22c7d76997c68e1d1b
https://github.com/Perl/perl5/commit/f735fab2aa25148d9c19fe22c7d76997c68e1d1b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 7c5d5a6cff165ac1aaeee867978d9b9dc5826743
https://github.com/Perl/perl5/commit/7c5d5a6cff165ac1aaeee867978d9b9dc5826743
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: af128eb7f545f70eb1221f82e6dde07c5d08910c
https://github.com/Perl/perl5/commit/af128eb7f545f70eb1221f82e6dde07c5d08910c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 6b9929e6e381c4079422e5f25fffdb40788ff88a
https://github.com/Perl/perl5/commit/6b9929e6e381c4079422e5f25fffdb40788ff88a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 79a6a501337c7308b86943ddd8b33b28e138b3d8
https://github.com/Perl/perl5/commit/79a6a501337c7308b86943ddd8b33b28e138b3d8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 00e17605b3a53015bab85c01d777ad835cc3113d
https://github.com/Perl/perl5/commit/00e17605b3a53015bab85c01d777ad835cc3113d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 3dd00f25e36759e288558ab35d848779334a180e
https://github.com/Perl/perl5/commit/3dd00f25e36759e288558ab35d848779334a180e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 0542e87d66b4fed04807b5af4c7cd77dd977c335
https://github.com/Perl/perl5/commit/0542e87d66b4fed04807b5af4c7cd77dd977c335
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 94e03cc4fe8463f456e11455b2e5f6e5b320a080
https://github.com/Perl/perl5/commit/94e03cc4fe8463f456e11455b2e5f6e5b320a080
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: fb100d07bd6e2f0f59f45ce6d6fb128fe833c9b8
https://github.com/Perl/perl5/commit/fb100d07bd6e2f0f59f45ce6d6fb128fe833c9b8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 5a39602d4bcafeb46528be5e0a96f0a11f3bde24
https://github.com/Perl/perl5/commit/5a39602d4bcafeb46528be5e0a96f0a11f3bde24
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: e7e2daf64569527a5200883bd12b1a7e32d46ce0
https://github.com/Perl/perl5/commit/e7e2daf64569527a5200883bd12b1a7e32d46ce0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 4e839177b3dcb41f1f57f555f45d30f8f1649ab4
https://github.com/Perl/perl5/commit/4e839177b3dcb41f1f57f555f45d30f8f1649ab4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 6ea68f4e70e0e5af028008a4a72a9336e3c8d70f
https://github.com/Perl/perl5/commit/6ea68f4e70e0e5af028008a4a72a9336e3c8d70f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: d9582e36227ab2d30afbb80ec4264915b9204878
https://github.com/Perl/perl5/commit/d9582e36227ab2d30afbb80ec4264915b9204878
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 2b7b5eaf7724d6e80ce6cdcfb3608baa7f12bf22
https://github.com/Perl/perl5/commit/2b7b5eaf7724d6e80ce6cdcfb3608baa7f12bf22
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 501ed4d486d2ed9a76577da738d51eccb9f9cbb4
https://github.com/Perl/perl5/commit/501ed4d486d2ed9a76577da738d51eccb9f9cbb4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: ae7f7ef5f2d8089097f6893f8502239a31d40e35
https://github.com/Perl/perl5/commit/ae7f7ef5f2d8089097f6893f8502239a31d40e35
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c4d335b4a14e7be17962c8fbd2bc856ea5ddb5c9
https://github.com/Perl/perl5/commit/c4d335b4a14e7be17962c8fbd2bc856ea5ddb5c9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 51d6de80d269910b2552ea24d927d67ecfcdc0f4
https://github.com/Perl/perl5/commit/51d6de80d269910b2552ea24d927d67ecfcdc0f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: d64e0c2943de9dedd404e642286f0281dd4ace53
https://github.com/Perl/perl5/commit/d64e0c2943de9dedd404e642286f0281dd4ace53
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 68857319065629170557c4783c475b6f7b79c752
https://github.com/Perl/perl5/commit/68857319065629170557c4783c475b6f7b79c752
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 1c2b46143c988487b8824bc381122ac1011124b4
https://github.com/Perl/perl5/commit/1c2b46143c988487b8824bc381122ac1011124b4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: f44c20d1fc70d5e4c0235f5e4b4ada373a8cac56
https://github.com/Perl/perl5/commit/f44c20d1fc70d5e4c0235f5e4b4ada373a8cac56
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: be0579a52d73db9a788d2d71ccb889c638b093fc
https://github.com/Perl/perl5/commit/be0579a52d73db9a788d2d71ccb889c638b093fc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 299c989017bb5d84fe64720d01da24e421627fda
https://github.com/Perl/perl5/commit/299c989017bb5d84fe64720d01da24e421627fda
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 4a11d062a53e93111995bd1a6c125fb50eee5668
https://github.com/Perl/perl5/commit/4a11d062a53e93111995bd1a6c125fb50eee5668
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: c77e714e7f107a447f609c81b05937c853d77c38
https://github.com/Perl/perl5/commit/c77e714e7f107a447f609c81b05937c853d77c38
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 6e02256b2f765d4ad46b6162378425607ab7d4a5
https://github.com/Perl/perl5/commit/6e02256b2f765d4ad46b6162378425607ab7d4a5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 170a2e758a9a80f152521b1012b0f14f7896154c
https://github.com/Perl/perl5/commit/170a2e758a9a80f152521b1012b0f14f7896154c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: abff2253e9f7174c0e275ab09439fa0e5b3781d6
https://github.com/Perl/perl5/commit/abff2253e9f7174c0e275ab09439fa0e5b3781d6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 762d430866e73ec3995d4be603a61da1c0908aba
https://github.com/Perl/perl5/commit/762d430866e73ec3995d4be603a61da1c0908aba
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: bac1d0e63e0515659628a4454fdefba4beb855a2
https://github.com/Perl/perl5/commit/bac1d0e63e0515659628a4454fdefba4beb855a2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: fec75b26d5ae794e7f870fbcb218c4d608ca4b84
https://github.com/Perl/perl5/commit/fec75b26d5ae794e7f870fbcb218c4d608ca4b84
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 8b005f0cb5c44fc3f41d33e5e213473473d27950
https://github.com/Perl/perl5/commit/8b005f0cb5c44fc3f41d33e5e213473473d27950
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 0ffcf299ec94ef30a841d1bd5497d6f4edef7ff7
https://github.com/Perl/perl5/commit/0ffcf299ec94ef30a841d1bd5497d6f4edef7ff7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: f17cf48a5023da05cbd9814e17636797419cdf3b
https://github.com/Perl/perl5/commit/f17cf48a5023da05cbd9814e17636797419cdf3b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: cf9aca5c21091d61b140ed4ef8c41cfcd0ac7ca1
https://github.com/Perl/perl5/commit/cf9aca5c21091d61b140ed4ef8c41cfcd0ac7ca1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 03a713ea5bbb8febd78ef98bad49d111d07fd957
https://github.com/Perl/perl5/commit/03a713ea5bbb8febd78ef98bad49d111d07fd957
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: de637be8449c532ec68e1d9f8694f054adc05837
https://github.com/Perl/perl5/commit/de637be8449c532ec68e1d9f8694f054adc05837
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 9e5e0c7868d2c39e21ee3028525ca77bd111d3c3
https://github.com/Perl/perl5/commit/9e5e0c7868d2c39e21ee3028525ca77bd111d3c3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: fd20fa131df54fb4f00652230a0258820e8ddf69
https://github.com/Perl/perl5/commit/fd20fa131df54fb4f00652230a0258820e8ddf69
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 0a042011be7c26988617352ed64ec04ec292dc16
https://github.com/Perl/perl5/commit/0a042011be7c26988617352ed64ec04ec292dc16
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: a26a9606b0897477f717bf8c5faf1cec8e74d450
https://github.com/Perl/perl5/commit/a26a9606b0897477f717bf8c5faf1cec8e74d450
Author: Karl Williamson <k...@cpan.org>
Date: 2021-03-29 (Mon, 29 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Compare: https://github.com/Perl/perl5/compare/ab306b0806b3...a26a9606b089
