Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 7d88da43fa5d970e7918846f022b93379c0a2bad
https://github.com/Perl/perl5/commit/7d88da43fa5d970e7918846f022b93379c0a2bad
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 8393d37c34c00d6a06d4d81bb2293b8e49385d97
https://github.com/Perl/perl5/commit/8393d37c34c00d6a06d4d81bb2293b8e49385d97
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 368ff2ff06495ca4d415515aa143285f6c255318
https://github.com/Perl/perl5/commit/368ff2ff06495ca4d415515aa143285f6c255318
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 61da5a7fec8b5b2b1a667d9b48a434427505262a
https://github.com/Perl/perl5/commit/61da5a7fec8b5b2b1a667d9b48a434427505262a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 798b9c517cbc28aacd30fffbf304e40e9a8297ba
https://github.com/Perl/perl5/commit/798b9c517cbc28aacd30fffbf304e40e9a8297ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 3b568e35301d338c46e0a4bd3026472cb6563311
https://github.com/Perl/perl5/commit/3b568e35301d338c46e0a4bd3026472cb6563311
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: dd765e94ae26976561c59a4b57b17c33eb427804
https://github.com/Perl/perl5/commit/dd765e94ae26976561c59a4b57b17c33eb427804
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: e95d39465b860753ea41d2cccb17252094ab5945
https://github.com/Perl/perl5/commit/e95d39465b860753ea41d2cccb17252094ab5945
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: a50b4dbaed18d258c07bac4007cd528e15e0ed79
https://github.com/Perl/perl5/commit/a50b4dbaed18d258c07bac4007cd528e15e0ed79
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 9032c61c4d3b065854ba53972fbd72da2ee24b67
https://github.com/Perl/perl5/commit/9032c61c4d3b065854ba53972fbd72da2ee24b67
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 1e8e8928f0622f32f12c13dc6d0d5b30c0f13eee
https://github.com/Perl/perl5/commit/1e8e8928f0622f32f12c13dc6d0d5b30c0f13eee
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 4b8d68f63f613ac0750741b3df168def4c702636
https://github.com/Perl/perl5/commit/4b8d68f63f613ac0750741b3df168def4c702636
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 81cf8adf0876a936d97a342f934991fc565222bf
https://github.com/Perl/perl5/commit/81cf8adf0876a936d97a342f934991fc565222bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 686327d0527d4ce11aa6181992c52b653d5e4f92
https://github.com/Perl/perl5/commit/686327d0527d4ce11aa6181992c52b653d5e4f92
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: f8da9bc65fb3b086071e80c195cde9ace3818d2c
https://github.com/Perl/perl5/commit/f8da9bc65fb3b086071e80c195cde9ace3818d2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: e800c4044597a11b52e49810710c01f140c6f18d
https://github.com/Perl/perl5/commit/e800c4044597a11b52e49810710c01f140c6f18d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 2bb2684bf16457ef7126d56f0e23c561cae79d9d
https://github.com/Perl/perl5/commit/2bb2684bf16457ef7126d56f0e23c561cae79d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 989ede0048838bb1f8ec346d6fc17cc26af44b10
https://github.com/Perl/perl5/commit/989ede0048838bb1f8ec346d6fc17cc26af44b10
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 48b4e1dbd957aca2ad780b8c31969bf6ec22e004
https://github.com/Perl/perl5/commit/48b4e1dbd957aca2ad780b8c31969bf6ec22e004
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 41cd035d4beccb8fe6d964605398a7a93cbde539
https://github.com/Perl/perl5/commit/41cd035d4beccb8fe6d964605398a7a93cbde539
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 85ac67d68e35919d11f73ac17ab46471b2280278
https://github.com/Perl/perl5/commit/85ac67d68e35919d11f73ac17ab46471b2280278
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 094710282373cba08282a61a1571bd8b7a801b94
https://github.com/Perl/perl5/commit/094710282373cba08282a61a1571bd8b7a801b94
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: e0e44b76df43e0f8343bb2a2a92421c29c769e82
https://github.com/Perl/perl5/commit/e0e44b76df43e0f8343bb2a2a92421c29c769e82
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 12264439f8fb47351f2b23ffed528e8833197a74
https://github.com/Perl/perl5/commit/12264439f8fb47351f2b23ffed528e8833197a74
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 6f8900c8b184c3a2dfd54437187f95d5a8ea6c7a
https://github.com/Perl/perl5/commit/6f8900c8b184c3a2dfd54437187f95d5a8ea6c7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 52ff58b295d79d2c319cff84167dd9b68bf19ae5
https://github.com/Perl/perl5/commit/52ff58b295d79d2c319cff84167dd9b68bf19ae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 09eb6c0ab6e6cc975dfecc83729c38314b962cdf
https://github.com/Perl/perl5/commit/09eb6c0ab6e6cc975dfecc83729c38314b962cdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: a4fb886ec08f23351d2c9a80c8090c11e9873b1e
https://github.com/Perl/perl5/commit/a4fb886ec08f23351d2c9a80c8090c11e9873b1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 3d415acf71d31c7c0fb1757efe6ddff90be3c1b4
https://github.com/Perl/perl5/commit/3d415acf71d31c7c0fb1757efe6ddff90be3c1b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 8ae90c8de569dc9bf11a963a0de5299e40254afb
https://github.com/Perl/perl5/commit/8ae90c8de569dc9bf11a963a0de5299e40254afb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 386b88cce0885945fcc623595867b3b292619ac2
https://github.com/Perl/perl5/commit/386b88cce0885945fcc623595867b3b292619ac2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 13685520ba70d01e7a964976c129e308431f4c54
https://github.com/Perl/perl5/commit/13685520ba70d01e7a964976c129e308431f4c54
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 17e8b719f6fd4fb3905a2183bbb51ac0fee22538
https://github.com/Perl/perl5/commit/17e8b719f6fd4fb3905a2183bbb51ac0fee22538
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 343520d7f173f2510056ab0bb55dac7501d525e8
https://github.com/Perl/perl5/commit/343520d7f173f2510056ab0bb55dac7501d525e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: e67efffa48a873dad2fad10d0cc766024bab03e1
https://github.com/Perl/perl5/commit/e67efffa48a873dad2fad10d0cc766024bab03e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: fe2c01bb0a2ec56c3b9835d471b765293fbe5135
https://github.com/Perl/perl5/commit/fe2c01bb0a2ec56c3b9835d471b765293fbe5135
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 3e5a1a943873d7d5b0e7e64620adc6f11852bfb0
https://github.com/Perl/perl5/commit/3e5a1a943873d7d5b0e7e64620adc6f11852bfb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 9e417ada4f0c1716abf28af467804435414713e8
https://github.com/Perl/perl5/commit/9e417ada4f0c1716abf28af467804435414713e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: a39df8edb0207efb8ec909b3f88207f47a038b04
https://github.com/Perl/perl5/commit/a39df8edb0207efb8ec909b3f88207f47a038b04
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: b0cade5bca1a14fae57adc876d2603040b55e4a4
https://github.com/Perl/perl5/commit/b0cade5bca1a14fae57adc876d2603040b55e4a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 2e6fad5de239043cd83354259f913a21bec9cc4d
https://github.com/Perl/perl5/commit/2e6fad5de239043cd83354259f913a21bec9cc4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 7f3ff0b0812aa20464bf69c5ee774a6e7543e491
https://github.com/Perl/perl5/commit/7f3ff0b0812aa20464bf69c5ee774a6e7543e491
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: b3f872b917186fc19dcfbc88f43636b01ed4fdbb
https://github.com/Perl/perl5/commit/b3f872b917186fc19dcfbc88f43636b01ed4fdbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: d46a42f4d612dd2b89b68f0c9e029c092f3bdbd5
https://github.com/Perl/perl5/commit/d46a42f4d612dd2b89b68f0c9e029c092f3bdbd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: ed73bb9c70f1640c861b77216a3ef90af1ee0b73
https://github.com/Perl/perl5/commit/ed73bb9c70f1640c861b77216a3ef90af1ee0b73
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 34cb97d28f028711818784e9e5a52921f3e055e2
https://github.com/Perl/perl5/commit/34cb97d28f028711818784e9e5a52921f3e055e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: febc25da96aafb484f6ea974febceeaefc650932
https://github.com/Perl/perl5/commit/febc25da96aafb484f6ea974febceeaefc650932
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 202af7a848befe6d1c8081c7ab827045fdcd49b7
https://github.com/Perl/perl5/commit/202af7a848befe6d1c8081c7ab827045fdcd49b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 77ae739634872cf81f4c4b93e91ba8a4a35c82d6
https://github.com/Perl/perl5/commit/77ae739634872cf81f4c4b93e91ba8a4a35c82d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 62c9647e7acde6d57484e9ad4a70b93c7c5c5218
https://github.com/Perl/perl5/commit/62c9647e7acde6d57484e9ad4a70b93c7c5c5218
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 67af53c9c1a14432aad45983a78e966f8dcdb351
https://github.com/Perl/perl5/commit/67af53c9c1a14432aad45983a78e966f8dcdb351
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: e8f8f21fa3bfc063dfe6c9fe8ca532e32bd301d1
https://github.com/Perl/perl5/commit/e8f8f21fa3bfc063dfe6c9fe8ca532e32bd301d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 5862c4612c808350e0964927c5cc28f5b17ac33e
https://github.com/Perl/perl5/commit/5862c4612c808350e0964927c5cc28f5b17ac33e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 4a72e0dc36aa4d2917f74d8a7a6190d129129fab
https://github.com/Perl/perl5/commit/4a72e0dc36aa4d2917f74d8a7a6190d129129fab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 5e19f29971ee6296fcdcb885e0855810edc449d6
https://github.com/Perl/perl5/commit/5e19f29971ee6296fcdcb885e0855810edc449d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 2224b87b4c4a73a3ed08fdb07f5482e921ec4390
https://github.com/Perl/perl5/commit/2224b87b4c4a73a3ed08fdb07f5482e921ec4390
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 3fa7779d1c37b3e4ddf202d044f583eff263f9d8
https://github.com/Perl/perl5/commit/3fa7779d1c37b3e4ddf202d044f583eff263f9d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: d3d443202715597ce8e0c7aa6c4a1746a6229de4
https://github.com/Perl/perl5/commit/d3d443202715597ce8e0c7aa6c4a1746a6229de4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 6a235b3764e3a8699d662a94138e15e51ffc2985
https://github.com/Perl/perl5/commit/6a235b3764e3a8699d662a94138e15e51ffc2985
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: f4a3692c5d4926d855d1357132f93e65f4f1e1c1
https://github.com/Perl/perl5/commit/f4a3692c5d4926d855d1357132f93e65f4f1e1c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 33cceaa7a2bdde3d38791f4baf8ce0b5c62884d3
https://github.com/Perl/perl5/commit/33cceaa7a2bdde3d38791f4baf8ce0b5c62884d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 549fa9cd67a4604da0915f079d1ef2ae2fc013f2
https://github.com/Perl/perl5/commit/549fa9cd67a4604da0915f079d1ef2ae2fc013f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 0d5e9fb726d1f5c9031e8e4058d65182cef8d2eb
https://github.com/Perl/perl5/commit/0d5e9fb726d1f5c9031e8e4058d65182cef8d2eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 881340519764b9b0c874fc8285548e927a746d4b
https://github.com/Perl/perl5/commit/881340519764b9b0c874fc8285548e927a746d4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 06e484f2fa7499a56cd76d94009094fe59ffe2fa
https://github.com/Perl/perl5/commit/06e484f2fa7499a56cd76d94009094fe59ffe2fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 8e9ef5284a66b16a83fddce095d63cede60d6cd0
https://github.com/Perl/perl5/commit/8e9ef5284a66b16a83fddce095d63cede60d6cd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 3279831c3f393c349ec946a55750007f14cc78d2
https://github.com/Perl/perl5/commit/3279831c3f393c349ec946a55750007f14cc78d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: a78282b477095a65e0f7371c9948e1f95d7e47f0
https://github.com/Perl/perl5/commit/a78282b477095a65e0f7371c9948e1f95d7e47f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: cca9c7ef30576b07eb243d01d4bc3ee7ff65d9b8
https://github.com/Perl/perl5/commit/cca9c7ef30576b07eb243d01d4bc3ee7ff65d9b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 4e9f567500e60585ee331304933f6a8c7362de4b
https://github.com/Perl/perl5/commit/4e9f567500e60585ee331304933f6a8c7362de4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: e5291c80fcaa1f3adf4183720065810073145420
https://github.com/Perl/perl5/commit/e5291c80fcaa1f3adf4183720065810073145420
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 3cd14a761d7c585730beca05c38570cc1e834498
https://github.com/Perl/perl5/commit/3cd14a761d7c585730beca05c38570cc1e834498
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: fda9347c5e5d032bc5d13b23bc7e888c1ec54f1e
https://github.com/Perl/perl5/commit/fda9347c5e5d032bc5d13b23bc7e888c1ec54f1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 5be949db8a64e6c051c5ac7e65204f1786b3f949
https://github.com/Perl/perl5/commit/5be949db8a64e6c051c5ac7e65204f1786b3f949
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: b13c6ebecf8eaa3dc8300a6c8bbd81aad0c86ba1
https://github.com/Perl/perl5/commit/b13c6ebecf8eaa3dc8300a6c8bbd81aad0c86ba1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 3d66d20d40ac6f83aac118d28deaeb023f98332e
https://github.com/Perl/perl5/commit/3d66d20d40ac6f83aac118d28deaeb023f98332e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 08d02852befb9acc345a317f098bc5c546662640
https://github.com/Perl/perl5/commit/08d02852befb9acc345a317f098bc5c546662640
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 93bfb38befdbdc1baedba703efd616f3e98013ef
https://github.com/Perl/perl5/commit/93bfb38befdbdc1baedba703efd616f3e98013ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: ed2a8b917076972e587883184e89de0a426dd9e5
https://github.com/Perl/perl5/commit/ed2a8b917076972e587883184e89de0a426dd9e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: e7f6adb2e4f8ded263fdd678872afefb8e348969
https://github.com/Perl/perl5/commit/e7f6adb2e4f8ded263fdd678872afefb8e348969
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 8a7e4df3fc67d4041f9bad7985d0a0e8471baf85
https://github.com/Perl/perl5/commit/8a7e4df3fc67d4041f9bad7985d0a0e8471baf85
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 86e89eccf0f7afae939cf3426220d2e57b60b816
https://github.com/Perl/perl5/commit/86e89eccf0f7afae939cf3426220d2e57b60b816
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 3a2c5223c7801fa46d0b1fb153cfcd1f4f508c55
https://github.com/Perl/perl5/commit/3a2c5223c7801fa46d0b1fb153cfcd1f4f508c55
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: b121e7c905d9ba7f0f2fd6582b5a5b878c929f5c
https://github.com/Perl/perl5/commit/b121e7c905d9ba7f0f2fd6582b5a5b878c929f5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 65e1ef166ebfb2fe8e1f3bc17718a3749c802e01
https://github.com/Perl/perl5/commit/65e1ef166ebfb2fe8e1f3bc17718a3749c802e01
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 3bfd2785679d75e0673414d9447d27a2b73c59cb
https://github.com/Perl/perl5/commit/3bfd2785679d75e0673414d9447d27a2b73c59cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 3f642ef7449f84eb96a595b1af8a7ac843bfc475
https://github.com/Perl/perl5/commit/3f642ef7449f84eb96a595b1af8a7ac843bfc475
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 75f7436a59ab3788e730c3f39af605c787b25d35
https://github.com/Perl/perl5/commit/75f7436a59ab3788e730c3f39af605c787b25d35
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: a8503e0239fd08d86d8027233e06a3a52c693f1a
https://github.com/Perl/perl5/commit/a8503e0239fd08d86d8027233e06a3a52c693f1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 9ee5d869f95990edbd555ab4808842d04416772d
https://github.com/Perl/perl5/commit/9ee5d869f95990edbd555ab4808842d04416772d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 9721fb3f0dfea021b62ed1968f94c365c2f1e846
https://github.com/Perl/perl5/commit/9721fb3f0dfea021b62ed1968f94c365c2f1e846
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: c4e29ff0dace958f526368f8ebb81270e3aa57e8
https://github.com/Perl/perl5/commit/c4e29ff0dace958f526368f8ebb81270e3aa57e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 401c7819ce8ef091f37dd3f9135f9fe9d31ef112
https://github.com/Perl/perl5/commit/401c7819ce8ef091f37dd3f9135f9fe9d31ef112
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: b6e9f8c810ab0588ba1b1d201cc3acb4d08d5c22
https://github.com/Perl/perl5/commit/b6e9f8c810ab0588ba1b1d201cc3acb4d08d5c22
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: efe434610d1f3a55d25211071e3c9d5dcc8e01f5
https://github.com/Perl/perl5/commit/efe434610d1f3a55d25211071e3c9d5dcc8e01f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: b958494c876625f73e49132ca0fe9eae94345910
https://github.com/Perl/perl5/commit/b958494c876625f73e49132ca0fe9eae94345910
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 6efa9503a8a631990266d3729f8f4eaf79d48210
https://github.com/Perl/perl5/commit/6efa9503a8a631990266d3729f8f4eaf79d48210
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 477a557809e71923739bffe5fc723b2af043d586
https://github.com/Perl/perl5/commit/477a557809e71923739bffe5fc723b2af043d586
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: c9137e492c74f331aa160ec1f575713c9d043a85
https://github.com/Perl/perl5/commit/c9137e492c74f331aa160ec1f575713c9d043a85
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 415e5a4bc42bb403c44ac8e5fcca59f694da0bc2
https://github.com/Perl/perl5/commit/415e5a4bc42bb403c44ac8e5fcca59f694da0bc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 7ae827ffb209588534babcf922dfe7ccec27491a
https://github.com/Perl/perl5/commit/7ae827ffb209588534babcf922dfe7ccec27491a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 26949055a340878a537fc1c8750e56cbc997eedd
https://github.com/Perl/perl5/commit/26949055a340878a537fc1c8750e56cbc997eedd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: e7f83de6ac68f5e701d4a46bfcb217f111b1d0e8
https://github.com/Perl/perl5/commit/e7f83de6ac68f5e701d4a46bfcb217f111b1d0e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: b84b32bbbc35dfbbd12315673de1d6c46e07c341
https://github.com/Perl/perl5/commit/b84b32bbbc35dfbbd12315673de1d6c46e07c341
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: ca1ac91ad21afe87552deea45d95e1e6ffbb8204
https://github.com/Perl/perl5/commit/ca1ac91ad21afe87552deea45d95e1e6ffbb8204
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 6cce9daa4b296db15b569de2f0c733f6dc36be74
https://github.com/Perl/perl5/commit/6cce9daa4b296db15b569de2f0c733f6dc36be74
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 84cc8360f684537faeb9380923dea89527651538
https://github.com/Perl/perl5/commit/84cc8360f684537faeb9380923dea89527651538
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 344b5b6dc3faa698984c7520ae197f8a7fe3ade5
https://github.com/Perl/perl5/commit/344b5b6dc3faa698984c7520ae197f8a7fe3ade5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 4cc8f9a99f43e700dffa2c5df9aeda44ad5067cf
https://github.com/Perl/perl5/commit/4cc8f9a99f43e700dffa2c5df9aeda44ad5067cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: b4870975a92afdd4b4124ed59a6d2648a7a054c3
https://github.com/Perl/perl5/commit/b4870975a92afdd4b4124ed59a6d2648a7a054c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 726dfca2899690562c05bc7a034d01465d3a9d24
https://github.com/Perl/perl5/commit/726dfca2899690562c05bc7a034d01465d3a9d24
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: e3b4a99bcc04bfd4c3ac77642ad3cb3fed69707f
https://github.com/Perl/perl5/commit/e3b4a99bcc04bfd4c3ac77642ad3cb3fed69707f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 4fdb2a1b1ed28569e608e2503fded48f114f8781
https://github.com/Perl/perl5/commit/4fdb2a1b1ed28569e608e2503fded48f114f8781
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: e155afade44d06340d4ac63ab2ae54dc1cf06ebd
https://github.com/Perl/perl5/commit/e155afade44d06340d4ac63ab2ae54dc1cf06ebd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 58c2b4903ba0fff8713dcf7441224ba261c037ab
https://github.com/Perl/perl5/commit/58c2b4903ba0fff8713dcf7441224ba261c037ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 751a14d2e8ad8a7ae7da96fac1f01a0c1bbf757a
https://github.com/Perl/perl5/commit/751a14d2e8ad8a7ae7da96fac1f01a0c1bbf757a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 124b65fc7ff6db7aeeed509a0c121c636a3daaf8
https://github.com/Perl/perl5/commit/124b65fc7ff6db7aeeed509a0c121c636a3daaf8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 321082439b6c3271cb710daf8cdd48c4bb652a51
https://github.com/Perl/perl5/commit/321082439b6c3271cb710daf8cdd48c4bb652a51
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 5f6cdcf961899ac4b6a6acb4e935a4d08304f7c8
https://github.com/Perl/perl5/commit/5f6cdcf961899ac4b6a6acb4e935a4d08304f7c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: ebbf8cac428c462495933478e99d0147a78e2169
https://github.com/Perl/perl5/commit/ebbf8cac428c462495933478e99d0147a78e2169
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 3c76d5ec5b4bb215557c3d7a88b620b778003d24
https://github.com/Perl/perl5/commit/3c76d5ec5b4bb215557c3d7a88b620b778003d24
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: f9661104e4c6abbe83c6a0ceabd70b549e41ac04
https://github.com/Perl/perl5/commit/f9661104e4c6abbe83c6a0ceabd70b549e41ac04
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: bfe1a4dfa444b81ac0b717e1a1bd3f32104c5f98
https://github.com/Perl/perl5/commit/bfe1a4dfa444b81ac0b717e1a1bd3f32104c5f98
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 6fc15152b0a80e5b0b704c390a77e799a0ef1c8f
https://github.com/Perl/perl5/commit/6fc15152b0a80e5b0b704c390a77e799a0ef1c8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: ebfdcb1a3a675a8d645aa55030d8592405b76347
https://github.com/Perl/perl5/commit/ebfdcb1a3a675a8d645aa55030d8592405b76347
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 677fd05827e22f4ff9f69b2e5dc3150b2846c4d2
https://github.com/Perl/perl5/commit/677fd05827e22f4ff9f69b2e5dc3150b2846c4d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 43a1cdbfd4574a25df36ceb93f8b9858e75c4965
https://github.com/Perl/perl5/commit/43a1cdbfd4574a25df36ceb93f8b9858e75c4965
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: da06df06454a482661dcddc1db1d58bee1fac29b
https://github.com/Perl/perl5/commit/da06df06454a482661dcddc1db1d58bee1fac29b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 412c3eebae607cd64a33c2a703e6ee0f6f075608
https://github.com/Perl/perl5/commit/412c3eebae607cd64a33c2a703e6ee0f6f075608
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: d9da1fac025bc137fd1ad6c17974400cf107133f
https://github.com/Perl/perl5/commit/d9da1fac025bc137fd1ad6c17974400cf107133f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 12a64942119fa1bdb9c3c9e2d3f6298822a45314
https://github.com/Perl/perl5/commit/12a64942119fa1bdb9c3c9e2d3f6298822a45314
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 0ddf6e644fcef0d57d2ebd1a2e751e51e41dd15c
https://github.com/Perl/perl5/commit/0ddf6e644fcef0d57d2ebd1a2e751e51e41dd15c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 14f81c67531e299e6c064562dd896d53082cd631
https://github.com/Perl/perl5/commit/14f81c67531e299e6c064562dd896d53082cd631
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 4cacb7d46619ade42abd31ab97d9e587f6a95122
https://github.com/Perl/perl5/commit/4cacb7d46619ade42abd31ab97d9e587f6a95122
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: f2a3b99f18ac1bcc295066c2045027a5d880557a
https://github.com/Perl/perl5/commit/f2a3b99f18ac1bcc295066c2045027a5d880557a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 27020a903a57d79003df19bf4b5d11c5c390acc8
https://github.com/Perl/perl5/commit/27020a903a57d79003df19bf4b5d11c5c390acc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 727da6adaea82441ea4487c6d6afbd863e4e7714
https://github.com/Perl/perl5/commit/727da6adaea82441ea4487c6d6afbd863e4e7714
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: c8fd94353c6df7719d075f108672022c20025933
https://github.com/Perl/perl5/commit/c8fd94353c6df7719d075f108672022c20025933
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: d67bf383cfdf6f2230141c8ca13a665be6e9f36e
https://github.com/Perl/perl5/commit/d67bf383cfdf6f2230141c8ca13a665be6e9f36e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 4a0d5a2a13f0d3293c971fd6f4ecf2da6d78512c
https://github.com/Perl/perl5/commit/4a0d5a2a13f0d3293c971fd6f4ecf2da6d78512c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 30c2f00a32669bee3dd6abb35265240e083ecb30
https://github.com/Perl/perl5/commit/30c2f00a32669bee3dd6abb35265240e083ecb30
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 6e068cb1fe94b65216b9132701298bfc1d0b2f92
https://github.com/Perl/perl5/commit/6e068cb1fe94b65216b9132701298bfc1d0b2f92
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 0ae231cfd74e06b0aa73fca1493090be2ee90fe4
https://github.com/Perl/perl5/commit/0ae231cfd74e06b0aa73fca1493090be2ee90fe4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: b27865e898dce7c5245fb22bbee924a7e6818b8f
https://github.com/Perl/perl5/commit/b27865e898dce7c5245fb22bbee924a7e6818b8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 4773900580a8bb7df76978cfeb8c0cdb7e5b4ef6
https://github.com/Perl/perl5/commit/4773900580a8bb7df76978cfeb8c0cdb7e5b4ef6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 1f2ac9db3fc64617ff303f791a2fb732fee1c510
https://github.com/Perl/perl5/commit/1f2ac9db3fc64617ff303f791a2fb732fee1c510
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 1055fd3bff3c7687237671071a91db302c2f4cc4
https://github.com/Perl/perl5/commit/1055fd3bff3c7687237671071a91db302c2f4cc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: ab44bc79b01b2d076c4dd929130214bd7af0e873
https://github.com/Perl/perl5/commit/ab44bc79b01b2d076c4dd929130214bd7af0e873
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: c6ebf2f513c7352055cb6e51a838d764d380e4f4
https://github.com/Perl/perl5/commit/c6ebf2f513c7352055cb6e51a838d764d380e4f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: f22c1a6760d4ec7ebd2463a67ec007db4c14ed43
https://github.com/Perl/perl5/commit/f22c1a6760d4ec7ebd2463a67ec007db4c14ed43
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: f0b951fe8c0bc5f34683602c3d6ede0ee7bc6a05
https://github.com/Perl/perl5/commit/f0b951fe8c0bc5f34683602c3d6ede0ee7bc6a05
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 08ce6000f2976633ebc1ced7736e415b1f805c0a
https://github.com/Perl/perl5/commit/08ce6000f2976633ebc1ced7736e415b1f805c0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: eeb21edcfdb7dd7ca37963dbdbe6e23d834eb2a6
https://github.com/Perl/perl5/commit/eeb21edcfdb7dd7ca37963dbdbe6e23d834eb2a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 7cd48be6909ab0a31d06bd778065f5d82de04d01
https://github.com/Perl/perl5/commit/7cd48be6909ab0a31d06bd778065f5d82de04d01
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: dc4f4b58a450594eaa60afe078af709494574ebf
https://github.com/Perl/perl5/commit/dc4f4b58a450594eaa60afe078af709494574ebf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 386ccc610ef876294bf350499c8e5014b6279082
https://github.com/Perl/perl5/commit/386ccc610ef876294bf350499c8e5014b6279082
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 9551f6c10e0aa4a0f1a49a49965e24c0a74fd0b4
https://github.com/Perl/perl5/commit/9551f6c10e0aa4a0f1a49a49965e24c0a74fd0b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 741f481dc863b98de7abed1aade8e353381ea6b6
https://github.com/Perl/perl5/commit/741f481dc863b98de7abed1aade8e353381ea6b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 6e779931ed16f9668214cd0e2e491104c0b134ef
https://github.com/Perl/perl5/commit/6e779931ed16f9668214cd0e2e491104c0b134ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 21bfe27e44ded327d079a0a93c915132755139e1
https://github.com/Perl/perl5/commit/21bfe27e44ded327d079a0a93c915132755139e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 293ba158ea92d187cb06730edc306e7ce901409a
https://github.com/Perl/perl5/commit/293ba158ea92d187cb06730edc306e7ce901409a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 75e994a4b8e8540b466cc8cff177bb7a601203cf
https://github.com/Perl/perl5/commit/75e994a4b8e8540b466cc8cff177bb7a601203cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 4677264b07b6bc77541edeaa690fc89fe3f3818e
https://github.com/Perl/perl5/commit/4677264b07b6bc77541edeaa690fc89fe3f3818e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 7ab15812aa8ed6226876cd4a96b57e9511cea280
https://github.com/Perl/perl5/commit/7ab15812aa8ed6226876cd4a96b57e9511cea280
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 684c29a1eba05da5426c6241d3ec0c2040c89216
https://github.com/Perl/perl5/commit/684c29a1eba05da5426c6241d3ec0c2040c89216
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 954e878fd7eb37ea061f9d6af3d3897d604d29dd
https://github.com/Perl/perl5/commit/954e878fd7eb37ea061f9d6af3d3897d604d29dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: dc1fac4d45f3b8b3ca34a30f40f37a5bfb90766c
https://github.com/Perl/perl5/commit/dc1fac4d45f3b8b3ca34a30f40f37a5bfb90766c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 9ebbc95ee2d51d96be20e28f45719fc5c8acc779
https://github.com/Perl/perl5/commit/9ebbc95ee2d51d96be20e28f45719fc5c8acc779
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: ab7f5848e1c0218e459941bc9c5522a7c04848b2
https://github.com/Perl/perl5/commit/ab7f5848e1c0218e459941bc9c5522a7c04848b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 431977b1d37f14434635aba2967a987fd605d439
https://github.com/Perl/perl5/commit/431977b1d37f14434635aba2967a987fd605d439
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 0a7f24f19e1785653362c9995f2c927bf8df7eec
https://github.com/Perl/perl5/commit/0a7f24f19e1785653362c9995f2c927bf8df7eec
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: b0c983f158a15a669b31f9c5c1991431a15744ff
https://github.com/Perl/perl5/commit/b0c983f158a15a669b31f9c5c1991431a15744ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: a763f87520f95907c88916a46b43a2cb9089adcc
https://github.com/Perl/perl5/commit/a763f87520f95907c88916a46b43a2cb9089adcc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 336cfadb5a88399e1d3ee7745edb61aa4fe646c0
https://github.com/Perl/perl5/commit/336cfadb5a88399e1d3ee7745edb61aa4fe646c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 82bf86c492e62ed95a9c3aa9f38a63b4e28a509b
https://github.com/Perl/perl5/commit/82bf86c492e62ed95a9c3aa9f38a63b4e28a509b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 2b8dc471faab466295a2c2fd7ef3588e24312126
https://github.com/Perl/perl5/commit/2b8dc471faab466295a2c2fd7ef3588e24312126
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 7f403af58440054dc182ed9bb17f80bf21fe0a8f
https://github.com/Perl/perl5/commit/7f403af58440054dc182ed9bb17f80bf21fe0a8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 7ea0c5db91a54746af3958e2c1e18e821c9f8def
https://github.com/Perl/perl5/commit/7ea0c5db91a54746af3958e2c1e18e821c9f8def
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 612782a88fbc49cc347b6cf6da887ebb97fd19f7
https://github.com/Perl/perl5/commit/612782a88fbc49cc347b6cf6da887ebb97fd19f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: af11bbfe7ba3a52a6cd8e1d0569b7925fb2f36f1
https://github.com/Perl/perl5/commit/af11bbfe7ba3a52a6cd8e1d0569b7925fb2f36f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 2221c168e1ccb304ff1b3fd3101c9f88470fa834
https://github.com/Perl/perl5/commit/2221c168e1ccb304ff1b3fd3101c9f88470fa834
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 1105ec682dba45530169b1ee8cc22c6ff3713694
https://github.com/Perl/perl5/commit/1105ec682dba45530169b1ee8cc22c6ff3713694
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: cb9d4f3ca2f201ba08f8eb5797ac6d3776a6b032
https://github.com/Perl/perl5/commit/cb9d4f3ca2f201ba08f8eb5797ac6d3776a6b032
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: b7e88091f9dc9c8f1eb4c5ce4a61e9152e21ccd1
https://github.com/Perl/perl5/commit/b7e88091f9dc9c8f1eb4c5ce4a61e9152e21ccd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: f59bc0f3292b16f3a77e222f658d8e3443b0997e
https://github.com/Perl/perl5/commit/f59bc0f3292b16f3a77e222f658d8e3443b0997e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: ac1bf4ceded1a6f74a5987e1f7520cdeb02fed6d
https://github.com/Perl/perl5/commit/ac1bf4ceded1a6f74a5987e1f7520cdeb02fed6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: cfe6da3b9435c25da137b7817e2ed749ae1899e8
https://github.com/Perl/perl5/commit/cfe6da3b9435c25da137b7817e2ed749ae1899e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: efa9bed581d42983d32b37b571ced5f2e7d755fa
https://github.com/Perl/perl5/commit/efa9bed581d42983d32b37b571ced5f2e7d755fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 452a216f9ed6655b42a3438adfff44b4054452e9
https://github.com/Perl/perl5/commit/452a216f9ed6655b42a3438adfff44b4054452e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 43309dce1f4e5072c6e0149f8f3dc5211336735e
https://github.com/Perl/perl5/commit/43309dce1f4e5072c6e0149f8f3dc5211336735e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 37bfb0f7c9bf36fb3f320559531fbcef282f573f
https://github.com/Perl/perl5/commit/37bfb0f7c9bf36fb3f320559531fbcef282f573f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 1715e64e2d4768dc658f495fdb3207394a2d711e
https://github.com/Perl/perl5/commit/1715e64e2d4768dc658f495fdb3207394a2d711e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 964cea13f5efdcf3abeec24ece23b414d74cb474
https://github.com/Perl/perl5/commit/964cea13f5efdcf3abeec24ece23b414d74cb474
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 0f914ff97a087bad0039e8e47077ab7f236c32ef
https://github.com/Perl/perl5/commit/0f914ff97a087bad0039e8e47077ab7f236c32ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 35d622b233cd83cb871d82d777367494acd7c08b
https://github.com/Perl/perl5/commit/35d622b233cd83cb871d82d777367494acd7c08b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: e133afb610012784c1f1d5b0de6f9b652be409cc
https://github.com/Perl/perl5/commit/e133afb610012784c1f1d5b0de6f9b652be409cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 60c563133f62306e043c3d2609a20a59513336f6
https://github.com/Perl/perl5/commit/60c563133f62306e043c3d2609a20a59513336f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 20998030aefc7a8ac8456adc7b1d5c914b1aed0f
https://github.com/Perl/perl5/commit/20998030aefc7a8ac8456adc7b1d5c914b1aed0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 2598fe982689697e7e29539ae70e435fdd088f98
https://github.com/Perl/perl5/commit/2598fe982689697e7e29539ae70e435fdd088f98
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: cfeb709dce174d54b9e7142df2b3fa94441576fb
https://github.com/Perl/perl5/commit/cfeb709dce174d54b9e7142df2b3fa94441576fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 4b15ce5fda84c698e0362ed037dc0daf5d441264
https://github.com/Perl/perl5/commit/4b15ce5fda84c698e0362ed037dc0daf5d441264
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 2da8eb83f6cf0a3346a4b21aed1c7631d9a1ef26
https://github.com/Perl/perl5/commit/2da8eb83f6cf0a3346a4b21aed1c7631d9a1ef26
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 61d352f01a4f791091de3c51d94f1ba1beb1e83d
https://github.com/Perl/perl5/commit/61d352f01a4f791091de3c51d94f1ba1beb1e83d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fde2397fe19a5e5a27e6c591b59e60df1acbcdd9
https://github.com/Perl/perl5/commit/fde2397fe19a5e5a27e6c591b59e60df1acbcdd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: a8fd9d461445a4301507b20f9015085cae5f8487
https://github.com/Perl/perl5/commit/a8fd9d461445a4301507b20f9015085cae5f8487
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: 01968ec24cb7e9d0bfc0f15ca680880a46365aef
https://github.com/Perl/perl5/commit/01968ec24cb7e9d0bfc0f15ca680880a46365aef
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 741d21d37ff6fefca9e564161a851975af4ca9ec
https://github.com/Perl/perl5/commit/741d21d37ff6fefca9e564161a851975af4ca9ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: aa26100a2c160e76cd92de607e3096840869cc0a
https://github.com/Perl/perl5/commit/aa26100a2c160e76cd92de607e3096840869cc0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 981e0a0ce764281315ed0d1dd558781fdab95915
https://github.com/Perl/perl5/commit/981e0a0ce764281315ed0d1dd558781fdab95915
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.c
M proto.h
M t/loc_tools.pl
Log Message:
-----------
more7
Compare: https://github.com/Perl/perl5/compare/dbdd0e1d9309...981e0a0ce764
