Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 779ae3acb08367fa0974010878533bcb7bdbda4d
https://github.com/Perl/perl5/commit/779ae3acb08367fa0974010878533bcb7bdbda4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 7ec7458b33ea8ba8e4c072a23cb64382fd07c792
https://github.com/Perl/perl5/commit/7ec7458b33ea8ba8e4c072a23cb64382fd07c792
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 4b3669e1a16f843e766f4e636607f75968b66108
https://github.com/Perl/perl5/commit/4b3669e1a16f843e766f4e636607f75968b66108
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: b5d2fa9ad7b107a83ef75c4e0237f01428e075ac
https://github.com/Perl/perl5/commit/b5d2fa9ad7b107a83ef75c4e0237f01428e075ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 696fcd6bc369b3debce05ac425c80130fda54d9d
https://github.com/Perl/perl5/commit/696fcd6bc369b3debce05ac425c80130fda54d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 21982bd5cc198fbfe849a4eabb02ed9f2385db79
https://github.com/Perl/perl5/commit/21982bd5cc198fbfe849a4eabb02ed9f2385db79
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 05816dd94190a35dc62cf6bd896a29602ec121b2
https://github.com/Perl/perl5/commit/05816dd94190a35dc62cf6bd896a29602ec121b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: ce778f296b7da17f0419367fd1321d047f2ffb91
https://github.com/Perl/perl5/commit/ce778f296b7da17f0419367fd1321d047f2ffb91
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 6e6a574697fd3fdbe867a6818782cd320afd9580
https://github.com/Perl/perl5/commit/6e6a574697fd3fdbe867a6818782cd320afd9580
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: f80a111c42939e1ef2926d69fe3f2fc169abc8f0
https://github.com/Perl/perl5/commit/f80a111c42939e1ef2926d69fe3f2fc169abc8f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 40a7bb50b2399e3c6630ec2a310fd54ed04967b5
https://github.com/Perl/perl5/commit/40a7bb50b2399e3c6630ec2a310fd54ed04967b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: f7ff15501b06aacf9812be2ddfb681c8fd66a44c
https://github.com/Perl/perl5/commit/f7ff15501b06aacf9812be2ddfb681c8fd66a44c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 4e59a376001683932cd9054ada016b08703b0b28
https://github.com/Perl/perl5/commit/4e59a376001683932cd9054ada016b08703b0b28
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 9b56297d7e41d9b335a8c7f6363b83618f562c68
https://github.com/Perl/perl5/commit/9b56297d7e41d9b335a8c7f6363b83618f562c68
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 836d253f73be1915115dfdcee0121bf5da409402
https://github.com/Perl/perl5/commit/836d253f73be1915115dfdcee0121bf5da409402
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 006c9bbb0736ec320380a07453642b9942ea1e6a
https://github.com/Perl/perl5/commit/006c9bbb0736ec320380a07453642b9942ea1e6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: f1a720fe49e229a9858ea898363abee1e92a641a
https://github.com/Perl/perl5/commit/f1a720fe49e229a9858ea898363abee1e92a641a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 47547c39d5bfe6804ec81d04cc8ad471c480e4e6
https://github.com/Perl/perl5/commit/47547c39d5bfe6804ec81d04cc8ad471c480e4e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 53c3bf249071caa1e06cd75865f66fc88e75edbe
https://github.com/Perl/perl5/commit/53c3bf249071caa1e06cd75865f66fc88e75edbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 0d9efe14ecfc4375a20a8943348c10e42aab9f73
https://github.com/Perl/perl5/commit/0d9efe14ecfc4375a20a8943348c10e42aab9f73
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: c6df81f4338cd7b60ee9b6ac5125b54e49fecf4b
https://github.com/Perl/perl5/commit/c6df81f4338cd7b60ee9b6ac5125b54e49fecf4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 808981dfad965c5f662dc21aa60275e6bcbc697e
https://github.com/Perl/perl5/commit/808981dfad965c5f662dc21aa60275e6bcbc697e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 4809a161266c2671014e09bcc4ace3732a98f08b
https://github.com/Perl/perl5/commit/4809a161266c2671014e09bcc4ace3732a98f08b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: aff66ba658b922d878e909bcf10802d14fca3b39
https://github.com/Perl/perl5/commit/aff66ba658b922d878e909bcf10802d14fca3b39
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: dc19a2670c37a964fcc240cefc4c807bd29a7ed9
https://github.com/Perl/perl5/commit/dc19a2670c37a964fcc240cefc4c807bd29a7ed9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: f2faf5d08e0e33a16b418e2cd3971048d3802cd2
https://github.com/Perl/perl5/commit/f2faf5d08e0e33a16b418e2cd3971048d3802cd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 5ab8fa81db7e3221b6bd186cea3e47378b3ca57d
https://github.com/Perl/perl5/commit/5ab8fa81db7e3221b6bd186cea3e47378b3ca57d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: c6bf18bfd2eb366a2fb6b57e48843224ea839197
https://github.com/Perl/perl5/commit/c6bf18bfd2eb366a2fb6b57e48843224ea839197
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 74184241aa15d3085c59ab95512599703ba412c5
https://github.com/Perl/perl5/commit/74184241aa15d3085c59ab95512599703ba412c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 95a3f045cf37dbcec41b38436f9ba13fdf3d3e81
https://github.com/Perl/perl5/commit/95a3f045cf37dbcec41b38436f9ba13fdf3d3e81
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: a51b906774244dafcd7206a57d30039f18e8f4d6
https://github.com/Perl/perl5/commit/a51b906774244dafcd7206a57d30039f18e8f4d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 7b23cb97184d91513d9607f506372e918459093a
https://github.com/Perl/perl5/commit/7b23cb97184d91513d9607f506372e918459093a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: b200b3798e1d5dcb0ac78e1031f8808b449e7293
https://github.com/Perl/perl5/commit/b200b3798e1d5dcb0ac78e1031f8808b449e7293
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 05cd6486e11a443ec713b19db5ece54440861341
https://github.com/Perl/perl5/commit/05cd6486e11a443ec713b19db5ece54440861341
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: b3b9f2c8e21c614b21463b9db9639bd1d44233d0
https://github.com/Perl/perl5/commit/b3b9f2c8e21c614b21463b9db9639bd1d44233d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: cfec77169fe47efc8e95dc1e8e6b96ec5ba96bc1
https://github.com/Perl/perl5/commit/cfec77169fe47efc8e95dc1e8e6b96ec5ba96bc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 76857973634afc0075498347fa5431c25163b92f
https://github.com/Perl/perl5/commit/76857973634afc0075498347fa5431c25163b92f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 9bf7444f4c30d478a0262e111cfdb9806ed90a1b
https://github.com/Perl/perl5/commit/9bf7444f4c30d478a0262e111cfdb9806ed90a1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: fea4e100b73fdf5860229651d7542de9647460fd
https://github.com/Perl/perl5/commit/fea4e100b73fdf5860229651d7542de9647460fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: d89b44490751c14e625a0c8a2681e1ce739a420a
https://github.com/Perl/perl5/commit/d89b44490751c14e625a0c8a2681e1ce739a420a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: efe93501b61e64258425d4e4d9b0d245575dbb2e
https://github.com/Perl/perl5/commit/efe93501b61e64258425d4e4d9b0d245575dbb2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 97c8fef5ef2ad91da741e95d153a7ef38cb5ea0c
https://github.com/Perl/perl5/commit/97c8fef5ef2ad91da741e95d153a7ef38cb5ea0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 1ce5486cd1bda85b703fec7d27c623fe2a87cdf3
https://github.com/Perl/perl5/commit/1ce5486cd1bda85b703fec7d27c623fe2a87cdf3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 014dd0031632cd19a4100b8555ee2befaa5ff1db
https://github.com/Perl/perl5/commit/014dd0031632cd19a4100b8555ee2befaa5ff1db
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: c8dadd16e3100a1abdc13faa247b08d8f8efa542
https://github.com/Perl/perl5/commit/c8dadd16e3100a1abdc13faa247b08d8f8efa542
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 82e51b3a2f2897eafd4d1deeab1110dfdbf47a7c
https://github.com/Perl/perl5/commit/82e51b3a2f2897eafd4d1deeab1110dfdbf47a7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 2cf0c0fb0ec1ad840bc33e8057416d6c395d8a89
https://github.com/Perl/perl5/commit/2cf0c0fb0ec1ad840bc33e8057416d6c395d8a89
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: f7d608eee8c9d77c7b46a7ba7ed60e8cf00ac68a
https://github.com/Perl/perl5/commit/f7d608eee8c9d77c7b46a7ba7ed60e8cf00ac68a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: ba8dfd3ca5b47ec75ca4493e35b19f4cf1fd4bf2
https://github.com/Perl/perl5/commit/ba8dfd3ca5b47ec75ca4493e35b19f4cf1fd4bf2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 4fff1f99d0e7c805de8d27cae65d76679036b5a8
https://github.com/Perl/perl5/commit/4fff1f99d0e7c805de8d27cae65d76679036b5a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: a53e38657d74fa10a7552725bc7be22737016e27
https://github.com/Perl/perl5/commit/a53e38657d74fa10a7552725bc7be22737016e27
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 5f6799f99ef4d404163098357bedffb91cc227d9
https://github.com/Perl/perl5/commit/5f6799f99ef4d404163098357bedffb91cc227d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 5211ac4db8936fd98c050764dfe7b3c922b82af6
https://github.com/Perl/perl5/commit/5211ac4db8936fd98c050764dfe7b3c922b82af6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: b0ccccb27a12feb010422ecce70fa695404c6d8a
https://github.com/Perl/perl5/commit/b0ccccb27a12feb010422ecce70fa695404c6d8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: db307c0a162953906eb0054e83d1b6ed8347aebb
https://github.com/Perl/perl5/commit/db307c0a162953906eb0054e83d1b6ed8347aebb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: c043aaf68b16dfa0892493ebf938ac2711dbd0bb
https://github.com/Perl/perl5/commit/c043aaf68b16dfa0892493ebf938ac2711dbd0bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 5904d60464fdac744afa6070bd5e7e5767be929b
https://github.com/Perl/perl5/commit/5904d60464fdac744afa6070bd5e7e5767be929b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 1deed27aa04d06deb758c8fc0deefd4ea59a4703
https://github.com/Perl/perl5/commit/1deed27aa04d06deb758c8fc0deefd4ea59a4703
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: e72dde4aab3b9a155806a33f02de9a2b24e00246
https://github.com/Perl/perl5/commit/e72dde4aab3b9a155806a33f02de9a2b24e00246
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 7065f0fefbe9aa752e653181af1d59110ac47a6b
https://github.com/Perl/perl5/commit/7065f0fefbe9aa752e653181af1d59110ac47a6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: e7343b1508fb644742354d9b85f9f9ef5bb3ad22
https://github.com/Perl/perl5/commit/e7343b1508fb644742354d9b85f9f9ef5bb3ad22
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 3ec461a76a666ff83cedb890f82211d71096f6ed
https://github.com/Perl/perl5/commit/3ec461a76a666ff83cedb890f82211d71096f6ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 1d320da8416437e139e4d2e39dd6db5ce38c1f8b
https://github.com/Perl/perl5/commit/1d320da8416437e139e4d2e39dd6db5ce38c1f8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 4315e7f7cb167145ce10d32fad7348199b0377b4
https://github.com/Perl/perl5/commit/4315e7f7cb167145ce10d32fad7348199b0377b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 868d71f8628fa251b30a0afd714f63fd2a50e797
https://github.com/Perl/perl5/commit/868d71f8628fa251b30a0afd714f63fd2a50e797
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 44c2be40accdcc3cd5ffb6008c455b21fb1df8c7
https://github.com/Perl/perl5/commit/44c2be40accdcc3cd5ffb6008c455b21fb1df8c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: b9659537844b4220518209f25c336ac1b0ac0b7a
https://github.com/Perl/perl5/commit/b9659537844b4220518209f25c336ac1b0ac0b7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: e831233797a7cb4585cefc964f0c205db4eaf8e9
https://github.com/Perl/perl5/commit/e831233797a7cb4585cefc964f0c205db4eaf8e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: c32d928c56be4fd60a6d961cb12020d5dbfcb909
https://github.com/Perl/perl5/commit/c32d928c56be4fd60a6d961cb12020d5dbfcb909
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: b57fa489e0542c62077e2f8847946ed8a5d94c3c
https://github.com/Perl/perl5/commit/b57fa489e0542c62077e2f8847946ed8a5d94c3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: a4e8d85910a388777e37826bc24d582f825b00d9
https://github.com/Perl/perl5/commit/a4e8d85910a388777e37826bc24d582f825b00d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 05cd3a80d128fb09b924749e2b714d3aab69ab73
https://github.com/Perl/perl5/commit/05cd3a80d128fb09b924749e2b714d3aab69ab73
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: ee189f09bd9e8011b63008de381ce9f65383e07d
https://github.com/Perl/perl5/commit/ee189f09bd9e8011b63008de381ce9f65383e07d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: ae6611a21a8a5e78f68550bcea240552ff400778
https://github.com/Perl/perl5/commit/ae6611a21a8a5e78f68550bcea240552ff400778
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 516acc72358a861a37f0f19333b1d3523483b30b
https://github.com/Perl/perl5/commit/516acc72358a861a37f0f19333b1d3523483b30b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: a62b5550f2941a4ccd61181a07f8bf49a92b7611
https://github.com/Perl/perl5/commit/a62b5550f2941a4ccd61181a07f8bf49a92b7611
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 19d2698f411ef3b4a43544e991961361e54f1212
https://github.com/Perl/perl5/commit/19d2698f411ef3b4a43544e991961361e54f1212
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 276f4c82a6e6eb452f2fd70f99510f3eec7aa342
https://github.com/Perl/perl5/commit/276f4c82a6e6eb452f2fd70f99510f3eec7aa342
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: cdb8b731e0c13e0fcc4e3a15f29a4c303a5f41e5
https://github.com/Perl/perl5/commit/cdb8b731e0c13e0fcc4e3a15f29a4c303a5f41e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 3964c600445236a6e2ca1067c13a40e6961e9c4d
https://github.com/Perl/perl5/commit/3964c600445236a6e2ca1067c13a40e6961e9c4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: bc192b5d70e7a2738590b200592a1e4c5bf2aff2
https://github.com/Perl/perl5/commit/bc192b5d70e7a2738590b200592a1e4c5bf2aff2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: b75fcc1ce032270759be11f82fc2150b035cf521
https://github.com/Perl/perl5/commit/b75fcc1ce032270759be11f82fc2150b035cf521
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e9a473e9a0a66b0985a9b25a8089de668d829ab4
https://github.com/Perl/perl5/commit/e9a473e9a0a66b0985a9b25a8089de668d829ab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 58cb47d3c5effcc755ccf02a91e2459d39fe60ff
https://github.com/Perl/perl5/commit/58cb47d3c5effcc755ccf02a91e2459d39fe60ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: fa086c4f420f450648cb4500b5a41cacf252bb93
https://github.com/Perl/perl5/commit/fa086c4f420f450648cb4500b5a41cacf252bb93
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 8b0b2856a219f954f99adf28856d69966496ce9a
https://github.com/Perl/perl5/commit/8b0b2856a219f954f99adf28856d69966496ce9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: ae029945b4c422782aec9144ee90a73bb83a855d
https://github.com/Perl/perl5/commit/ae029945b4c422782aec9144ee90a73bb83a855d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 62417f2dc3b2ad07f4969720d619515d61b377c1
https://github.com/Perl/perl5/commit/62417f2dc3b2ad07f4969720d619515d61b377c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 8802f79bc410dafe1f6fcb2aeb4892375cbc6174
https://github.com/Perl/perl5/commit/8802f79bc410dafe1f6fcb2aeb4892375cbc6174
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 7c319f59ec6e88f1341feb89d081f6dc1a8714d4
https://github.com/Perl/perl5/commit/7c319f59ec6e88f1341feb89d081f6dc1a8714d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: b2e8dac8c5deee24c9c06f2bd7cbf15ce55ff463
https://github.com/Perl/perl5/commit/b2e8dac8c5deee24c9c06f2bd7cbf15ce55ff463
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 24bebff9f6302186617aa21b696122ea14637d9a
https://github.com/Perl/perl5/commit/24bebff9f6302186617aa21b696122ea14637d9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 47d5e18155c74610bd540d08166642ee740a5edc
https://github.com/Perl/perl5/commit/47d5e18155c74610bd540d08166642ee740a5edc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 49a2b94663ec6a6e7eb61eec06b5e434110b8f7c
https://github.com/Perl/perl5/commit/49a2b94663ec6a6e7eb61eec06b5e434110b8f7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 2d649c6a7d9e158a4849b36fbd354288315e9017
https://github.com/Perl/perl5/commit/2d649c6a7d9e158a4849b36fbd354288315e9017
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 7ad2a8bdb059572b6d3364c2d036cc08abc59491
https://github.com/Perl/perl5/commit/7ad2a8bdb059572b6d3364c2d036cc08abc59491
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: a2c865ed4ad4911608aef6d793c63a9ecb22c495
https://github.com/Perl/perl5/commit/a2c865ed4ad4911608aef6d793c63a9ecb22c495
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 51b6203f6db9ce3d5c13e46bfa79f9fded17a64c
https://github.com/Perl/perl5/commit/51b6203f6db9ce3d5c13e46bfa79f9fded17a64c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 800eb44cdd21fda0fd5b9f3a007249670ca2e742
https://github.com/Perl/perl5/commit/800eb44cdd21fda0fd5b9f3a007249670ca2e742
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: ea2ffcdce055abce739e0f59378481f2b3d2f0a7
https://github.com/Perl/perl5/commit/ea2ffcdce055abce739e0f59378481f2b3d2f0a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: da6111f6adeb9d0cbbafa52a7617f6a4f218cd56
https://github.com/Perl/perl5/commit/da6111f6adeb9d0cbbafa52a7617f6a4f218cd56
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 28ece74ee6208c841d23c75b09540dc0232bd2d9
https://github.com/Perl/perl5/commit/28ece74ee6208c841d23c75b09540dc0232bd2d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 35980ded60233053ad5b5b1b199ef1a3218bf626
https://github.com/Perl/perl5/commit/35980ded60233053ad5b5b1b199ef1a3218bf626
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: b8ec35c85660194e92d6df61e48505a44b637b4d
https://github.com/Perl/perl5/commit/b8ec35c85660194e92d6df61e48505a44b637b4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: d11953df1182b907e690095afe653af57b7f6299
https://github.com/Perl/perl5/commit/d11953df1182b907e690095afe653af57b7f6299
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 4488fd57dac9ac16f2093fabb1397624dac621d5
https://github.com/Perl/perl5/commit/4488fd57dac9ac16f2093fabb1397624dac621d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: f9a78c8cbc972ffa792f873cc17d619d85e676f3
https://github.com/Perl/perl5/commit/f9a78c8cbc972ffa792f873cc17d619d85e676f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 5855f2d31dd8e6f250e8cae90745a345c613e254
https://github.com/Perl/perl5/commit/5855f2d31dd8e6f250e8cae90745a345c613e254
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 1d859fb4e78ead6a01583b8f5e654811b3c02c5a
https://github.com/Perl/perl5/commit/1d859fb4e78ead6a01583b8f5e654811b3c02c5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 453592c5394bb0cd27cf0f6bfe9af2dfe33bc039
https://github.com/Perl/perl5/commit/453592c5394bb0cd27cf0f6bfe9af2dfe33bc039
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: ece3eb3ebfc7962ac8b93f008004868c7a58c078
https://github.com/Perl/perl5/commit/ece3eb3ebfc7962ac8b93f008004868c7a58c078
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 4a5a5c1667473e2f065e94e31832b1fb8153df01
https://github.com/Perl/perl5/commit/4a5a5c1667473e2f065e94e31832b1fb8153df01
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: aeed09db545f691febc29934b0a011c78f7da2da
https://github.com/Perl/perl5/commit/aeed09db545f691febc29934b0a011c78f7da2da
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: aff76925753e24abc11e6fce53afeb4ced5ed47c
https://github.com/Perl/perl5/commit/aff76925753e24abc11e6fce53afeb4ced5ed47c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: f3018be9ed5dfe44d8a5462a4a8d7656e14f3e42
https://github.com/Perl/perl5/commit/f3018be9ed5dfe44d8a5462a4a8d7656e14f3e42
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 3bc86a25c4de9bde0789ce9a31c39e878ab9fd7e
https://github.com/Perl/perl5/commit/3bc86a25c4de9bde0789ce9a31c39e878ab9fd7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 3a0ab9b6a21e8be2a4582684e28bda020dc11a35
https://github.com/Perl/perl5/commit/3a0ab9b6a21e8be2a4582684e28bda020dc11a35
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: d96b4666546953bd8b66b251d3a6ccdbea1206db
https://github.com/Perl/perl5/commit/d96b4666546953bd8b66b251d3a6ccdbea1206db
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: c061ab71db5851e244b252d3dfefa1cb93c0ab91
https://github.com/Perl/perl5/commit/c061ab71db5851e244b252d3dfefa1cb93c0ab91
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: e1bf56ab67344fc3db1505dfce796b122c6fd6df
https://github.com/Perl/perl5/commit/e1bf56ab67344fc3db1505dfce796b122c6fd6df
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 135f5cf5fdcbb0b54494171fc9cbecb650321906
https://github.com/Perl/perl5/commit/135f5cf5fdcbb0b54494171fc9cbecb650321906
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 3d54c82db1313a4031a5b988a9f1b58ba3fd817a
https://github.com/Perl/perl5/commit/3d54c82db1313a4031a5b988a9f1b58ba3fd817a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: b198ddaf89842433917d4466ac9c23196ea3db51
https://github.com/Perl/perl5/commit/b198ddaf89842433917d4466ac9c23196ea3db51
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 6a8d7f68b0a11780a4c15f77b3fac567abd3fa21
https://github.com/Perl/perl5/commit/6a8d7f68b0a11780a4c15f77b3fac567abd3fa21
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: b86bb6fc86aee0af888f6fe645455042757b58e1
https://github.com/Perl/perl5/commit/b86bb6fc86aee0af888f6fe645455042757b58e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 2c431f88f840dc82c20466e6d51321b6c7dc5219
https://github.com/Perl/perl5/commit/2c431f88f840dc82c20466e6d51321b6c7dc5219
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 9cf4dd5529dde6fe5c8a6d766a895825738a2fe0
https://github.com/Perl/perl5/commit/9cf4dd5529dde6fe5c8a6d766a895825738a2fe0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: c08f8a27a871c4a7145d27c12923bb5073004efd
https://github.com/Perl/perl5/commit/c08f8a27a871c4a7145d27c12923bb5073004efd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 3cd8acaa82077a8e5b6fdbedb86bfec12b63277b
https://github.com/Perl/perl5/commit/3cd8acaa82077a8e5b6fdbedb86bfec12b63277b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: ada301fa716b4696a40d47181b825c3b402820bf
https://github.com/Perl/perl5/commit/ada301fa716b4696a40d47181b825c3b402820bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: b214a0c743a31899fac872bfc0fcd7919fa6fe52
https://github.com/Perl/perl5/commit/b214a0c743a31899fac872bfc0fcd7919fa6fe52
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 2b99e1d0d3cfd0f3e8ed6420a02f3a0352fb13df
https://github.com/Perl/perl5/commit/2b99e1d0d3cfd0f3e8ed6420a02f3a0352fb13df
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: b4a39541b50d107aadb35a32fdcc54eef1af42bb
https://github.com/Perl/perl5/commit/b4a39541b50d107aadb35a32fdcc54eef1af42bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 814cc5b307c5c3885f68f863c30092fc1e482380
https://github.com/Perl/perl5/commit/814cc5b307c5c3885f68f863c30092fc1e482380
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: bee2e6c9f3e0f8db05579c4ccdf3f2cdde1761c0
https://github.com/Perl/perl5/commit/bee2e6c9f3e0f8db05579c4ccdf3f2cdde1761c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 1c6e58900f3f2bbc8d9bfc91c260428530601782
https://github.com/Perl/perl5/commit/1c6e58900f3f2bbc8d9bfc91c260428530601782
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 7e3690955a67b2e5bc0267e8195254bd11484fe9
https://github.com/Perl/perl5/commit/7e3690955a67b2e5bc0267e8195254bd11484fe9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: eb21ff4bafb206adb58bc6456ba86e2871fb9414
https://github.com/Perl/perl5/commit/eb21ff4bafb206adb58bc6456ba86e2871fb9414
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: d02f3192990b8310fe2839661c0f058568799d50
https://github.com/Perl/perl5/commit/d02f3192990b8310fe2839661c0f058568799d50
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: a61de65a8f456b01836a32d085611890a3287d01
https://github.com/Perl/perl5/commit/a61de65a8f456b01836a32d085611890a3287d01
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 74f4f9925bcfb6289bd863430de928a49e7d5db5
https://github.com/Perl/perl5/commit/74f4f9925bcfb6289bd863430de928a49e7d5db5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: f0aa2124d9887a12cf065a4b6109804e9a15d5da
https://github.com/Perl/perl5/commit/f0aa2124d9887a12cf065a4b6109804e9a15d5da
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: a2c32d189bf3c26902ed4df87646ce7a8db662ae
https://github.com/Perl/perl5/commit/a2c32d189bf3c26902ed4df87646ce7a8db662ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 9c356f781b462127662a7c3b1d2cf052088bb567
https://github.com/Perl/perl5/commit/9c356f781b462127662a7c3b1d2cf052088bb567
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 019f43b88c2f4a087b9eae23c87d081556bde7e0
https://github.com/Perl/perl5/commit/019f43b88c2f4a087b9eae23c87d081556bde7e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: d1353c41cc335ff0b4c26603768f9aa1203f4688
https://github.com/Perl/perl5/commit/d1353c41cc335ff0b4c26603768f9aa1203f4688
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 473c21673f9a9f9f52a49b056757f571123e15b0
https://github.com/Perl/perl5/commit/473c21673f9a9f9f52a49b056757f571123e15b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: a3e1bf29f81c78dd268b6b3f1211711c946d02ff
https://github.com/Perl/perl5/commit/a3e1bf29f81c78dd268b6b3f1211711c946d02ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 934757a7061665589871eb5a628b5681e9b688e2
https://github.com/Perl/perl5/commit/934757a7061665589871eb5a628b5681e9b688e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 7eb45d6e7e048f24f4448e9c13dba88662e15365
https://github.com/Perl/perl5/commit/7eb45d6e7e048f24f4448e9c13dba88662e15365
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: a32de8a5d38c680aee75a8a723b47e7d2d437117
https://github.com/Perl/perl5/commit/a32de8a5d38c680aee75a8a723b47e7d2d437117
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: a5df1dba3fb313d9a4db0c1acf2d37746a5ff5fc
https://github.com/Perl/perl5/commit/a5df1dba3fb313d9a4db0c1acf2d37746a5ff5fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 0ea4ae785f6a918705f3c4e227f3e17d84afc4e1
https://github.com/Perl/perl5/commit/0ea4ae785f6a918705f3c4e227f3e17d84afc4e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 07641171478b0d3a619b3eababcb62662bc37137
https://github.com/Perl/perl5/commit/07641171478b0d3a619b3eababcb62662bc37137
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: af054e8095e8b3aa6398e43ed9e5304422a78724
https://github.com/Perl/perl5/commit/af054e8095e8b3aa6398e43ed9e5304422a78724
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: ed51accc886041330a2227ddf695d8a0ab5ecaf6
https://github.com/Perl/perl5/commit/ed51accc886041330a2227ddf695d8a0ab5ecaf6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 4a162c4b7ddb46715fbb0562fac01838fce53948
https://github.com/Perl/perl5/commit/4a162c4b7ddb46715fbb0562fac01838fce53948
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 499071d3cef5b983f05c245aa6cb7a1626a6b772
https://github.com/Perl/perl5/commit/499071d3cef5b983f05c245aa6cb7a1626a6b772
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 3a554def54b001709b9a3ca1b65875433daca59c
https://github.com/Perl/perl5/commit/3a554def54b001709b9a3ca1b65875433daca59c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 2d830c79396a4391c897c34b23378d65c09a1306
https://github.com/Perl/perl5/commit/2d830c79396a4391c897c34b23378d65c09a1306
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: b0770babacb358949a11e6926e0f8bc6029cd860
https://github.com/Perl/perl5/commit/b0770babacb358949a11e6926e0f8bc6029cd860
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: b23cfaea5b3b6ffc9a7762e69bf4cabae73391de
https://github.com/Perl/perl5/commit/b23cfaea5b3b6ffc9a7762e69bf4cabae73391de
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 380207afbcf4738540c613baddf4542cd3eaede7
https://github.com/Perl/perl5/commit/380207afbcf4738540c613baddf4542cd3eaede7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 57c381f802fcbc968acfa2c3fd3a87d05d98899d
https://github.com/Perl/perl5/commit/57c381f802fcbc968acfa2c3fd3a87d05d98899d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: a816f74bcff2f7787515babf7056eef21413d63e
https://github.com/Perl/perl5/commit/a816f74bcff2f7787515babf7056eef21413d63e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: f1b83c75fdf2e5b4271f04bfe1a4db3f1dc79280
https://github.com/Perl/perl5/commit/f1b83c75fdf2e5b4271f04bfe1a4db3f1dc79280
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: ea9a2fec3536a59b4a3a10ecda52a493105dbbc1
https://github.com/Perl/perl5/commit/ea9a2fec3536a59b4a3a10ecda52a493105dbbc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 67349d2fc4d499dc0f972a99d79879e6a13ebe9e
https://github.com/Perl/perl5/commit/67349d2fc4d499dc0f972a99d79879e6a13ebe9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 3d475b45f1993e091cbe6078766b9747b24a483c
https://github.com/Perl/perl5/commit/3d475b45f1993e091cbe6078766b9747b24a483c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 4c3f2e0c1b1fadf04cfefe60e8c790c31fff38fe
https://github.com/Perl/perl5/commit/4c3f2e0c1b1fadf04cfefe60e8c790c31fff38fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 909340b9ea73acb506ffe3e1e65a11373fa653df
https://github.com/Perl/perl5/commit/909340b9ea73acb506ffe3e1e65a11373fa653df
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 0931a6843e3fcba1eb25855e3946976cd6c37fef
https://github.com/Perl/perl5/commit/0931a6843e3fcba1eb25855e3946976cd6c37fef
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: bdfc5e37644dc69ad4c8c29d4ca90e6ffba45afd
https://github.com/Perl/perl5/commit/bdfc5e37644dc69ad4c8c29d4ca90e6ffba45afd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 8c2125dfb5d477f5cdd0f616c264862a23137edb
https://github.com/Perl/perl5/commit/8c2125dfb5d477f5cdd0f616c264862a23137edb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e7e71d637cf9af1880137e9cf6436203dfc071a2
https://github.com/Perl/perl5/commit/e7e71d637cf9af1880137e9cf6436203dfc071a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: dc82716106ddfc63c637e415db125264c84a4cf6
https://github.com/Perl/perl5/commit/dc82716106ddfc63c637e415db125264c84a4cf6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 4c075edd8c95dac7238cd8cac256c419fbf6612c
https://github.com/Perl/perl5/commit/4c075edd8c95dac7238cd8cac256c419fbf6612c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: fcbc664e344d22929413e8565d4ee82059721e6d
https://github.com/Perl/perl5/commit/fcbc664e344d22929413e8565d4ee82059721e6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 7df9b0b155dcc59ad963ca29f2305359d784a412
https://github.com/Perl/perl5/commit/7df9b0b155dcc59ad963ca29f2305359d784a412
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 2805b15f9fa72bf2094a1a634d3c5782e04d2859
https://github.com/Perl/perl5/commit/2805b15f9fa72bf2094a1a634d3c5782e04d2859
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 85af6ec0550203d9ee40074f67913fa3a55967ae
https://github.com/Perl/perl5/commit/85af6ec0550203d9ee40074f67913fa3a55967ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: abb4c223d2b72e6f636e6b4b9870e2b1814ea522
https://github.com/Perl/perl5/commit/abb4c223d2b72e6f636e6b4b9870e2b1814ea522
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 424c0fff1bbb0b802e13cb2b8f3036eedc903655
https://github.com/Perl/perl5/commit/424c0fff1bbb0b802e13cb2b8f3036eedc903655
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: b035cc77f4f1877c0f73a9aa4090d727a248d6d8
https://github.com/Perl/perl5/commit/b035cc77f4f1877c0f73a9aa4090d727a248d6d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 5ad5a4e727bdf7806b3c025bc9a92a0c3c7f3b2e
https://github.com/Perl/perl5/commit/5ad5a4e727bdf7806b3c025bc9a92a0c3c7f3b2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: f1f80a1895f42336e15ef2cb98876eb9ec944528
https://github.com/Perl/perl5/commit/f1f80a1895f42336e15ef2cb98876eb9ec944528
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: d3461c7094ef3ab60dedfabb1af05916295c50e1
https://github.com/Perl/perl5/commit/d3461c7094ef3ab60dedfabb1af05916295c50e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: e306d50084fe566e6ced49274577b09a4339e374
https://github.com/Perl/perl5/commit/e306d50084fe566e6ced49274577b09a4339e374
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: f0eb3d0620c0429bddf24a2536c943f890f4c178
https://github.com/Perl/perl5/commit/f0eb3d0620c0429bddf24a2536c943f890f4c178
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: e2f4c6ce8041da20b8be80a9a8eec3b1518f3e50
https://github.com/Perl/perl5/commit/e2f4c6ce8041da20b8be80a9a8eec3b1518f3e50
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: c59bc9f6da2524bcf3df0514321b4e94471a4450
https://github.com/Perl/perl5/commit/c59bc9f6da2524bcf3df0514321b4e94471a4450
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 29f6e966552a986d2bb693a2eea95cbd970a3e0a
https://github.com/Perl/perl5/commit/29f6e966552a986d2bb693a2eea95cbd970a3e0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 542129c196f2e2baad8a0440452cb1594eeaefcb
https://github.com/Perl/perl5/commit/542129c196f2e2baad8a0440452cb1594eeaefcb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 8b6d7e177237d4c912d22625b2a4a32e4cb648d0
https://github.com/Perl/perl5/commit/8b6d7e177237d4c912d22625b2a4a32e4cb648d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: aceb2e220bdd462261f2ef7c0e44eeb742e1a63a
https://github.com/Perl/perl5/commit/aceb2e220bdd462261f2ef7c0e44eeb742e1a63a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 24e52402e48b3495e19ca0a3aa20e63670f25b3f
https://github.com/Perl/perl5/commit/24e52402e48b3495e19ca0a3aa20e63670f25b3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: b2db1d8cf8295bf2a199d5c8c391b2561db0655b
https://github.com/Perl/perl5/commit/b2db1d8cf8295bf2a199d5c8c391b2561db0655b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 5bcedaff9b6923bff6d860ded7125ebaa72ec123
https://github.com/Perl/perl5/commit/5bcedaff9b6923bff6d860ded7125ebaa72ec123
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: cc3dfa596ea05f36d40747c82d92207c2c7f1ef6
https://github.com/Perl/perl5/commit/cc3dfa596ea05f36d40747c82d92207c2c7f1ef6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: c41d787153cf1ad9eb7e96fad3b24de8d81901a7
https://github.com/Perl/perl5/commit/c41d787153cf1ad9eb7e96fad3b24de8d81901a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 78696efd34def7d97bc3aa487d754211a3fa0368
https://github.com/Perl/perl5/commit/78696efd34def7d97bc3aa487d754211a3fa0368
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 978fc0a3be11cffb86bb66790306a3d6c5bb595d
https://github.com/Perl/perl5/commit/978fc0a3be11cffb86bb66790306a3d6c5bb595d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 8f9f09bbbc6d05b3fbdb975feb5104f41ecb9908
https://github.com/Perl/perl5/commit/8f9f09bbbc6d05b3fbdb975feb5104f41ecb9908
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 5a193bf770ee87edecbf6aa2c9567104fc6082c7
https://github.com/Perl/perl5/commit/5a193bf770ee87edecbf6aa2c9567104fc6082c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: fdc779c2bdda845e275c656242de212ffe019d55
https://github.com/Perl/perl5/commit/fdc779c2bdda845e275c656242de212ffe019d55
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 96f3c094f67f7534c445c23f0d0d2c6bf30440f9
https://github.com/Perl/perl5/commit/96f3c094f67f7534c445c23f0d0d2c6bf30440f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 808cfd9ea2a5fb7d8c978baf2a0dbe223f9d7891
https://github.com/Perl/perl5/commit/808cfd9ea2a5fb7d8c978baf2a0dbe223f9d7891
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: a8c7f8c8b28b3f5f52d565b3e55571f02a5dfe47
https://github.com/Perl/perl5/commit/a8c7f8c8b28b3f5f52d565b3e55571f02a5dfe47
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 58f168758766d85e53f4c827be03b743bdc897a7
https://github.com/Perl/perl5/commit/58f168758766d85e53f4c827be03b743bdc897a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: fc41d890c4345380aec576312dcc5089e6b794bb
https://github.com/Perl/perl5/commit/fc41d890c4345380aec576312dcc5089e6b794bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: b116aa0d2839fb111d9d9b91a3d942673c806240
https://github.com/Perl/perl5/commit/b116aa0d2839fb111d9d9b91a3d942673c806240
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M patchlevel.h
M perl.h
M t/loc_tools.pl
Log Message:
-----------
more8
Compare: https://github.com/Perl/perl5/compare/981e0a0ce764...b116aa0d2839
