Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 0ddecbfa1e0bb43ec137ef91aad50effcd6def07
https://github.com/Perl/perl5/commit/0ddecbfa1e0bb43ec137ef91aad50effcd6def07
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: f2c716a3a3d8356711fada85670d0e755e55ff42
https://github.com/Perl/perl5/commit/f2c716a3a3d8356711fada85670d0e755e55ff42
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: cafbaf79c05db3edd971659cd43a7a091f75f944
https://github.com/Perl/perl5/commit/cafbaf79c05db3edd971659cd43a7a091f75f944
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 1324d388b2ab3af4fd2ccdeba51e859c7afb9536
https://github.com/Perl/perl5/commit/1324d388b2ab3af4fd2ccdeba51e859c7afb9536
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 785aad2a4831a9584ed58a0e3ccf41393950ec5b
https://github.com/Perl/perl5/commit/785aad2a4831a9584ed58a0e3ccf41393950ec5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 73f29cce154e084f69d9cf87874533e05f782519
https://github.com/Perl/perl5/commit/73f29cce154e084f69d9cf87874533e05f782519
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 51be2b7e61adadebc79df8f89e152c9439611dae
https://github.com/Perl/perl5/commit/51be2b7e61adadebc79df8f89e152c9439611dae
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: dc4121f75e88d1000ca902a7043c5d9214c449d8
https://github.com/Perl/perl5/commit/dc4121f75e88d1000ca902a7043c5d9214c449d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: e30529ee77b74c1ea0b0ea2e0e6fedf05eedd4c8
https://github.com/Perl/perl5/commit/e30529ee77b74c1ea0b0ea2e0e6fedf05eedd4c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 31e6941c256e2463d0378c8085e5e6dab29810b6
https://github.com/Perl/perl5/commit/31e6941c256e2463d0378c8085e5e6dab29810b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 3f09599d3cc9732dabb1f807586f3341f5b579ab
https://github.com/Perl/perl5/commit/3f09599d3cc9732dabb1f807586f3341f5b579ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 2076a922119c9a66c769bd076717ebea72d33804
https://github.com/Perl/perl5/commit/2076a922119c9a66c769bd076717ebea72d33804
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 6f9d16955fb701bba80dc49da8711b33af7561f4
https://github.com/Perl/perl5/commit/6f9d16955fb701bba80dc49da8711b33af7561f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 0c5691634b5364e7503072eae486e15bf64d24f5
https://github.com/Perl/perl5/commit/0c5691634b5364e7503072eae486e15bf64d24f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 71a6600d2de925e2f1b7591650773482d4908bc9
https://github.com/Perl/perl5/commit/71a6600d2de925e2f1b7591650773482d4908bc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 21d7b41549e5597d9f92930e6f401ad8beca8bfd
https://github.com/Perl/perl5/commit/21d7b41549e5597d9f92930e6f401ad8beca8bfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 458a2e5800b170180f5fad89443da498e776a3fe
https://github.com/Perl/perl5/commit/458a2e5800b170180f5fad89443da498e776a3fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: c8faf2c069abb9225d31f72cd8f3cac9f6ddec47
https://github.com/Perl/perl5/commit/c8faf2c069abb9225d31f72cd8f3cac9f6ddec47
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 638313226640576628c071576e379ca919c2d7ca
https://github.com/Perl/perl5/commit/638313226640576628c071576e379ca919c2d7ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: be1e3b5376d3e1dd6129904bee2955e27ac319bc
https://github.com/Perl/perl5/commit/be1e3b5376d3e1dd6129904bee2955e27ac319bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: cd93c49412de29dce28c3d200a8b2d322be214aa
https://github.com/Perl/perl5/commit/cd93c49412de29dce28c3d200a8b2d322be214aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: f75a6c01fb6e166025837aa2275d4733303ae24e
https://github.com/Perl/perl5/commit/f75a6c01fb6e166025837aa2275d4733303ae24e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 194c020dd2fe5d97922db08f3eb28e7ae7dd2639
https://github.com/Perl/perl5/commit/194c020dd2fe5d97922db08f3eb28e7ae7dd2639
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 7b5294eaa3d6c19aff9259035332c72d752e4eb0
https://github.com/Perl/perl5/commit/7b5294eaa3d6c19aff9259035332c72d752e4eb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 5b2e563bab45fe7dd076319998e801d36061181f
https://github.com/Perl/perl5/commit/5b2e563bab45fe7dd076319998e801d36061181f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 8f45ee9158f39060b2e64996475872c8db4bd994
https://github.com/Perl/perl5/commit/8f45ee9158f39060b2e64996475872c8db4bd994
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 8513a146cbafa0612d4d41c7468eb8cfe3dd81f1
https://github.com/Perl/perl5/commit/8513a146cbafa0612d4d41c7468eb8cfe3dd81f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 0a77be126bcc869333deb90724e13d20c2ffe4d4
https://github.com/Perl/perl5/commit/0a77be126bcc869333deb90724e13d20c2ffe4d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 638da305899592c7530018f939c8c407e33542f9
https://github.com/Perl/perl5/commit/638da305899592c7530018f939c8c407e33542f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: bdb0479ae232ce695250912807bb598ca02646cc
https://github.com/Perl/perl5/commit/bdb0479ae232ce695250912807bb598ca02646cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 8e92bf952803941ad7bee443ec5df3aebc0a2f54
https://github.com/Perl/perl5/commit/8e92bf952803941ad7bee443ec5df3aebc0a2f54
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: e177dc4fd6181e9c056296aab42aa2d5da33fb57
https://github.com/Perl/perl5/commit/e177dc4fd6181e9c056296aab42aa2d5da33fb57
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 073bc2f2e4c5d51f0df77f38c0f71484d650cbab
https://github.com/Perl/perl5/commit/073bc2f2e4c5d51f0df77f38c0f71484d650cbab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 3011b170cdc7e703b4337188ea9ce7b3b8b90a7e
https://github.com/Perl/perl5/commit/3011b170cdc7e703b4337188ea9ce7b3b8b90a7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 23f9064b58885e1d06789c3db4eb5423030aad5b
https://github.com/Perl/perl5/commit/23f9064b58885e1d06789c3db4eb5423030aad5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 9db5ed16ae5ce49a5fb733c01c8f824f475c6e20
https://github.com/Perl/perl5/commit/9db5ed16ae5ce49a5fb733c01c8f824f475c6e20
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 0ecb6548ec89e75c0a827f52696919d87cd92d29
https://github.com/Perl/perl5/commit/0ecb6548ec89e75c0a827f52696919d87cd92d29
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 0c3ad1500cbcb4d3663e2f337142e7a7434bbc33
https://github.com/Perl/perl5/commit/0c3ad1500cbcb4d3663e2f337142e7a7434bbc33
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 18323ef461c00c12db8e5b7af9f29421661e5d9e
https://github.com/Perl/perl5/commit/18323ef461c00c12db8e5b7af9f29421661e5d9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 9ba8f0455db86cdfe5d6c63ad0645ae3a07931ef
https://github.com/Perl/perl5/commit/9ba8f0455db86cdfe5d6c63ad0645ae3a07931ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 27900761bd50aac3cdc5d7bba2a8ac1b98ec769b
https://github.com/Perl/perl5/commit/27900761bd50aac3cdc5d7bba2a8ac1b98ec769b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: e3d8558aad1db05341c78e0ef2795a90d61d09f4
https://github.com/Perl/perl5/commit/e3d8558aad1db05341c78e0ef2795a90d61d09f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: f068d371a9b8e6a2d21775f1089f5f53a64edaf3
https://github.com/Perl/perl5/commit/f068d371a9b8e6a2d21775f1089f5f53a64edaf3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 2adb476231819eaaf3c9aaa39470f80dd2b02cfd
https://github.com/Perl/perl5/commit/2adb476231819eaaf3c9aaa39470f80dd2b02cfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 6f3ae5a1f9c2c74f4d7f4c43d1eed6833af62038
https://github.com/Perl/perl5/commit/6f3ae5a1f9c2c74f4d7f4c43d1eed6833af62038
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: e6cf769fe3176046abb863bbe7c4793588368704
https://github.com/Perl/perl5/commit/e6cf769fe3176046abb863bbe7c4793588368704
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 975883780c29d79f692293519d91c36ae885e27d
https://github.com/Perl/perl5/commit/975883780c29d79f692293519d91c36ae885e27d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 1ff536a52833040671730c663f91d7e24923a6fb
https://github.com/Perl/perl5/commit/1ff536a52833040671730c663f91d7e24923a6fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 1b9f3248f0ab727f5a2761f95945f82639555175
https://github.com/Perl/perl5/commit/1b9f3248f0ab727f5a2761f95945f82639555175
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 38fb63c690735ef2bc5d359abd0855afbeffe98e
https://github.com/Perl/perl5/commit/38fb63c690735ef2bc5d359abd0855afbeffe98e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 852c539fc7a8e1b2d887eaf0154cedf4302c74cf
https://github.com/Perl/perl5/commit/852c539fc7a8e1b2d887eaf0154cedf4302c74cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: aaa34985f81fc482930f626a3f86de67ba4ff590
https://github.com/Perl/perl5/commit/aaa34985f81fc482930f626a3f86de67ba4ff590
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: c9a11b466a9e86bf05b0fb23a12dc96c70f85372
https://github.com/Perl/perl5/commit/c9a11b466a9e86bf05b0fb23a12dc96c70f85372
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: efe0bd4a4e2c7a06377159daf82c0827deacd706
https://github.com/Perl/perl5/commit/efe0bd4a4e2c7a06377159daf82c0827deacd706
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: f881a93eab61bf37b4cb389cda9904437c736167
https://github.com/Perl/perl5/commit/f881a93eab61bf37b4cb389cda9904437c736167
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 9fa9c70284f1f083c1868283ae6fb1313d956b9e
https://github.com/Perl/perl5/commit/9fa9c70284f1f083c1868283ae6fb1313d956b9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: f0201b277cd26802987db446c71af8f755ef96dc
https://github.com/Perl/perl5/commit/f0201b277cd26802987db446c71af8f755ef96dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: be39393e6ba5656f0bf9692bafc835bc2dfafbc1
https://github.com/Perl/perl5/commit/be39393e6ba5656f0bf9692bafc835bc2dfafbc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 0abc021a7372a64af6d1a8e1d5ebc1f7364bc89d
https://github.com/Perl/perl5/commit/0abc021a7372a64af6d1a8e1d5ebc1f7364bc89d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 1cb8bf1765e9b603aa1d436889886f167a15a375
https://github.com/Perl/perl5/commit/1cb8bf1765e9b603aa1d436889886f167a15a375
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: a949ec4de543f46e75a403c8f303602a44c5fc70
https://github.com/Perl/perl5/commit/a949ec4de543f46e75a403c8f303602a44c5fc70
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 6f4a988c721ca10ad447481796585e7dd08d3f12
https://github.com/Perl/perl5/commit/6f4a988c721ca10ad447481796585e7dd08d3f12
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 89c24fd501fe658b73ce8c0747e3e70c0ba3882d
https://github.com/Perl/perl5/commit/89c24fd501fe658b73ce8c0747e3e70c0ba3882d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: f56be306876b695e6996ef3f31ea44beeb472364
https://github.com/Perl/perl5/commit/f56be306876b695e6996ef3f31ea44beeb472364
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 75de1227e9610cf771769c755318f2e0be825c39
https://github.com/Perl/perl5/commit/75de1227e9610cf771769c755318f2e0be825c39
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: b4ffa4a85e08cc6c8c3a3fae05de6134ba76d5c6
https://github.com/Perl/perl5/commit/b4ffa4a85e08cc6c8c3a3fae05de6134ba76d5c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 0cd59270f5f58c579431fc3bd84e58b5590ca711
https://github.com/Perl/perl5/commit/0cd59270f5f58c579431fc3bd84e58b5590ca711
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: cf95a71957b34c9b7f1fed3cbff25e48a85cca46
https://github.com/Perl/perl5/commit/cf95a71957b34c9b7f1fed3cbff25e48a85cca46
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 9a8504a2096110d71aeb530add2fb1e1ce0afdbb
https://github.com/Perl/perl5/commit/9a8504a2096110d71aeb530add2fb1e1ce0afdbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 5a11dc0853d6fa911014a23d342d2734f6d7ca35
https://github.com/Perl/perl5/commit/5a11dc0853d6fa911014a23d342d2734f6d7ca35
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: ce041d060337c5d7fcf941836b8cfc350984b7ba
https://github.com/Perl/perl5/commit/ce041d060337c5d7fcf941836b8cfc350984b7ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 34e61d00fe0f4e86285a9156c53db75b767313d3
https://github.com/Perl/perl5/commit/34e61d00fe0f4e86285a9156c53db75b767313d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: a2ddced8faa0903e894388f3eb70441742603f46
https://github.com/Perl/perl5/commit/a2ddced8faa0903e894388f3eb70441742603f46
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: a52cc874a8c3e6b083462f0aefaa6ce378eddfb8
https://github.com/Perl/perl5/commit/a52cc874a8c3e6b083462f0aefaa6ce378eddfb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 0fe17d19577927d27128bc282d4794d72cc4a2db
https://github.com/Perl/perl5/commit/0fe17d19577927d27128bc282d4794d72cc4a2db
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 51e02018e1404d1eafc45c70071507610b465ab4
https://github.com/Perl/perl5/commit/51e02018e1404d1eafc45c70071507610b465ab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 483432e30bbe2194767233a07a0ba7b5d065a767
https://github.com/Perl/perl5/commit/483432e30bbe2194767233a07a0ba7b5d065a767
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: a49d2516b0481832fb4fa6bf063e15a8f0850e89
https://github.com/Perl/perl5/commit/a49d2516b0481832fb4fa6bf063e15a8f0850e89
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 197b126ddc588f46bfcf22f78013916fedea939f
https://github.com/Perl/perl5/commit/197b126ddc588f46bfcf22f78013916fedea939f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 83f8ceab2ac2627a726cc203895778edb159f7b5
https://github.com/Perl/perl5/commit/83f8ceab2ac2627a726cc203895778edb159f7b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 3ca85f7593f280d911a1b6386ff7d5fe6a239964
https://github.com/Perl/perl5/commit/3ca85f7593f280d911a1b6386ff7d5fe6a239964
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: d55a2c0326e0b6537b3d6ee21494b3ea685f1588
https://github.com/Perl/perl5/commit/d55a2c0326e0b6537b3d6ee21494b3ea685f1588
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e1b9afd170e1a3554d6f7285ab26fff8e8dc12cf
https://github.com/Perl/perl5/commit/e1b9afd170e1a3554d6f7285ab26fff8e8dc12cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 82301d3de381ca71acdb832f07825856833fb052
https://github.com/Perl/perl5/commit/82301d3de381ca71acdb832f07825856833fb052
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 89c67c3d91ae10fe94bba9b8c30f20e4a4bdae4d
https://github.com/Perl/perl5/commit/89c67c3d91ae10fe94bba9b8c30f20e4a4bdae4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: f05e660ccc93f27961e44472e6bd5e5830c4f1f5
https://github.com/Perl/perl5/commit/f05e660ccc93f27961e44472e6bd5e5830c4f1f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 639f669590e43e676c973fdb869ccc75e333dd77
https://github.com/Perl/perl5/commit/639f669590e43e676c973fdb869ccc75e333dd77
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 8483cc02fd8b6fc97734bf5cbea7012a7a09eeee
https://github.com/Perl/perl5/commit/8483cc02fd8b6fc97734bf5cbea7012a7a09eeee
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 3ff9d90e18a3bcc7dd7a5122715b4fc617257d7a
https://github.com/Perl/perl5/commit/3ff9d90e18a3bcc7dd7a5122715b4fc617257d7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 76a25b2133a146c9af42f867c3b339ad9fa720d6
https://github.com/Perl/perl5/commit/76a25b2133a146c9af42f867c3b339ad9fa720d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: d0707753573e7e5eb1027d7a9c95a6c30e92cd63
https://github.com/Perl/perl5/commit/d0707753573e7e5eb1027d7a9c95a6c30e92cd63
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 0cc92741526fb65b81f40fe623911ceb34c08393
https://github.com/Perl/perl5/commit/0cc92741526fb65b81f40fe623911ceb34c08393
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: dc12c67e7601e5e32c47c188f41238cbe8e0f98f
https://github.com/Perl/perl5/commit/dc12c67e7601e5e32c47c188f41238cbe8e0f98f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: dbe320c545542e0650a6888c5aaedeef719d97d5
https://github.com/Perl/perl5/commit/dbe320c545542e0650a6888c5aaedeef719d97d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: d0b013ae761198346d64c3dda1b5f810867d8ca7
https://github.com/Perl/perl5/commit/d0b013ae761198346d64c3dda1b5f810867d8ca7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 93bfa9560efc3332fb71c3135d5a540ab3add910
https://github.com/Perl/perl5/commit/93bfa9560efc3332fb71c3135d5a540ab3add910
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: c71ef344ac095076dd6dca9ff19fba9bac493173
https://github.com/Perl/perl5/commit/c71ef344ac095076dd6dca9ff19fba9bac493173
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 15d93a75304067c71ed35724ec336335d079cfdf
https://github.com/Perl/perl5/commit/15d93a75304067c71ed35724ec336335d079cfdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 625a4f3284ee139cee88f0bf4cb876e36cea5199
https://github.com/Perl/perl5/commit/625a4f3284ee139cee88f0bf4cb876e36cea5199
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 33406359c65d6752ca7e4802543d1cfaa0920442
https://github.com/Perl/perl5/commit/33406359c65d6752ca7e4802543d1cfaa0920442
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 5aa5f77236f7edf54630fa5f4efc49308f83a461
https://github.com/Perl/perl5/commit/5aa5f77236f7edf54630fa5f4efc49308f83a461
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: d8a4057075c91989a9df8d81307a5ea921b0baa8
https://github.com/Perl/perl5/commit/d8a4057075c91989a9df8d81307a5ea921b0baa8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: da8ef2dcb2864e73d06af1353fdd7d5cd93a23e7
https://github.com/Perl/perl5/commit/da8ef2dcb2864e73d06af1353fdd7d5cd93a23e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: ab1832e1496e68d90ed423962fea761a1674a606
https://github.com/Perl/perl5/commit/ab1832e1496e68d90ed423962fea761a1674a606
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 5aa6f948861e4a38a4f785fe00d3ed7e2cde8a8a
https://github.com/Perl/perl5/commit/5aa6f948861e4a38a4f785fe00d3ed7e2cde8a8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 918e4096d047bad87724113ead4a5cb5d8dedcc1
https://github.com/Perl/perl5/commit/918e4096d047bad87724113ead4a5cb5d8dedcc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 17c7f462cba2f4138d8d75cd957279e812f65c11
https://github.com/Perl/perl5/commit/17c7f462cba2f4138d8d75cd957279e812f65c11
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 9d8ae6ac3b9afcdcdbb626d1caeedd42524c5a54
https://github.com/Perl/perl5/commit/9d8ae6ac3b9afcdcdbb626d1caeedd42524c5a54
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 42eff0c6e5d4c1f849e92fcc5711193ed55fc81b
https://github.com/Perl/perl5/commit/42eff0c6e5d4c1f849e92fcc5711193ed55fc81b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: c50f3579c548093e8f9b33641d59e85386aaceed
https://github.com/Perl/perl5/commit/c50f3579c548093e8f9b33641d59e85386aaceed
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 42e90c9bb7d1a0350fbe4926c391f0c9588c9b58
https://github.com/Perl/perl5/commit/42e90c9bb7d1a0350fbe4926c391f0c9588c9b58
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 74aacaa94913563d43089af8650deec9be75ecff
https://github.com/Perl/perl5/commit/74aacaa94913563d43089af8650deec9be75ecff
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: cc19732123525429a3d1d8c57735aabc97789a98
https://github.com/Perl/perl5/commit/cc19732123525429a3d1d8c57735aabc97789a98
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 27d7f919dec58918e91b26b7ffa35cfa21aeb89f
https://github.com/Perl/perl5/commit/27d7f919dec58918e91b26b7ffa35cfa21aeb89f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 3d7d4619d1687e9eb7b22521ffdcd0e031eda4f3
https://github.com/Perl/perl5/commit/3d7d4619d1687e9eb7b22521ffdcd0e031eda4f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 35d2a22a80f07aad79d955831de818216f103880
https://github.com/Perl/perl5/commit/35d2a22a80f07aad79d955831de818216f103880
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 528c1e5c5432452e9a43e0d2f6249bf7ad2d5528
https://github.com/Perl/perl5/commit/528c1e5c5432452e9a43e0d2f6249bf7ad2d5528
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: b5080ffeeea96c1e5039d40cb64406c93e5bdc2e
https://github.com/Perl/perl5/commit/b5080ffeeea96c1e5039d40cb64406c93e5bdc2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 4fc1b191d4882d670f6ea10eed7a90fbafa16002
https://github.com/Perl/perl5/commit/4fc1b191d4882d670f6ea10eed7a90fbafa16002
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 8aba416a15972c5fdaaf12c2c9553a0541f5c1d6
https://github.com/Perl/perl5/commit/8aba416a15972c5fdaaf12c2c9553a0541f5c1d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 3dc589fe40fe19d72b36a0f8db98e88dec042cfa
https://github.com/Perl/perl5/commit/3dc589fe40fe19d72b36a0f8db98e88dec042cfa
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 2deb9dd1315b7ca28e871ebb50b62c85a221d81f
https://github.com/Perl/perl5/commit/2deb9dd1315b7ca28e871ebb50b62c85a221d81f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: feb8fc2a6bf1714f04893f0e8e267c528c47b221
https://github.com/Perl/perl5/commit/feb8fc2a6bf1714f04893f0e8e267c528c47b221
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 6766012be26a8961c9e629c4948e57a5bb2f89cf
https://github.com/Perl/perl5/commit/6766012be26a8961c9e629c4948e57a5bb2f89cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 3190b8f2cccaf933e217194f5af28d1f6bd188e1
https://github.com/Perl/perl5/commit/3190b8f2cccaf933e217194f5af28d1f6bd188e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: c7af300e81347799861cbadad1744e0cad051f6f
https://github.com/Perl/perl5/commit/c7af300e81347799861cbadad1744e0cad051f6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 40b33f8024b503add4a4bd034a0ace40133474e4
https://github.com/Perl/perl5/commit/40b33f8024b503add4a4bd034a0ace40133474e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: d4d7cd0041357db7907a6813ba41496a9570ae60
https://github.com/Perl/perl5/commit/d4d7cd0041357db7907a6813ba41496a9570ae60
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: c182d46147d8b69e405b32210e3b15ff10094442
https://github.com/Perl/perl5/commit/c182d46147d8b69e405b32210e3b15ff10094442
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 082259912b0fc42e8108ff3b0a43cf07e3a58dab
https://github.com/Perl/perl5/commit/082259912b0fc42e8108ff3b0a43cf07e3a58dab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 786c3fa2f2469379cd6211408ae359c0a8f5a50f
https://github.com/Perl/perl5/commit/786c3fa2f2469379cd6211408ae359c0a8f5a50f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 21f26dedf258dc29ab12d752b3b592bdeeb791bd
https://github.com/Perl/perl5/commit/21f26dedf258dc29ab12d752b3b592bdeeb791bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: bf226bdeef288e80f573b15a1f3d4991bc51b52f
https://github.com/Perl/perl5/commit/bf226bdeef288e80f573b15a1f3d4991bc51b52f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: cb80f6d449b907d709ed401cc89db614b0c3c2b8
https://github.com/Perl/perl5/commit/cb80f6d449b907d709ed401cc89db614b0c3c2b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 1fd9e1ea3fba657a2d44e862b26c400219a7dd4b
https://github.com/Perl/perl5/commit/1fd9e1ea3fba657a2d44e862b26c400219a7dd4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 2aa067e1e0ea65cb63e7b08ee1229315188a8e78
https://github.com/Perl/perl5/commit/2aa067e1e0ea65cb63e7b08ee1229315188a8e78
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: db4a384d60970d4cc5753a6b71eaec1c971c694b
https://github.com/Perl/perl5/commit/db4a384d60970d4cc5753a6b71eaec1c971c694b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 2900841027bbd8a1e4db731a6a06293e155a78b4
https://github.com/Perl/perl5/commit/2900841027bbd8a1e4db731a6a06293e155a78b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: b78b25dc7e103c72c3365d3d47c96c982ee15b8f
https://github.com/Perl/perl5/commit/b78b25dc7e103c72c3365d3d47c96c982ee15b8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: eb42abce883e2fe3c2a2df04d27ba75d0d23949f
https://github.com/Perl/perl5/commit/eb42abce883e2fe3c2a2df04d27ba75d0d23949f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: e788ee9bfc8d292a387d2678fc97c3b99c46791c
https://github.com/Perl/perl5/commit/e788ee9bfc8d292a387d2678fc97c3b99c46791c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: e586af0427b986f9e1669f61ce0c75afc3c10fe7
https://github.com/Perl/perl5/commit/e586af0427b986f9e1669f61ce0c75afc3c10fe7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 37e6a653edb023c29f22cab32912dea343acbe20
https://github.com/Perl/perl5/commit/37e6a653edb023c29f22cab32912dea343acbe20
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 2217e6a63551637b69d3eb70cac998f90b0384ec
https://github.com/Perl/perl5/commit/2217e6a63551637b69d3eb70cac998f90b0384ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 83982f4aba6e3ffaa58d8c68e18286f1146b6a56
https://github.com/Perl/perl5/commit/83982f4aba6e3ffaa58d8c68e18286f1146b6a56
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: eef0f6caae95cc23e66f2e60368797bf1f7db188
https://github.com/Perl/perl5/commit/eef0f6caae95cc23e66f2e60368797bf1f7db188
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: be1af10b1de06ce16aac7d3c36d198b3a9309026
https://github.com/Perl/perl5/commit/be1af10b1de06ce16aac7d3c36d198b3a9309026
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: db775337c9e0959df09efd30845a69300a12ba04
https://github.com/Perl/perl5/commit/db775337c9e0959df09efd30845a69300a12ba04
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 4bbba6faebf08460a16106c8b92b41d833fee9b4
https://github.com/Perl/perl5/commit/4bbba6faebf08460a16106c8b92b41d833fee9b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 053df6edf386538711ac6a5f18528a54ddcf0fc7
https://github.com/Perl/perl5/commit/053df6edf386538711ac6a5f18528a54ddcf0fc7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 4ae62f429e6f1267b61f316b6779dfd99c87c8e4
https://github.com/Perl/perl5/commit/4ae62f429e6f1267b61f316b6779dfd99c87c8e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: f3d6e835142dcf57c440ac21fdd407c8235f294d
https://github.com/Perl/perl5/commit/f3d6e835142dcf57c440ac21fdd407c8235f294d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 775fa1e91d0fce6dc98fcd5388aed52797d23b25
https://github.com/Perl/perl5/commit/775fa1e91d0fce6dc98fcd5388aed52797d23b25
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 179660b220fcc21d8d9455add66da42133c7d9bd
https://github.com/Perl/perl5/commit/179660b220fcc21d8d9455add66da42133c7d9bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: ea648a8812ea7926831b761daef0c5ab14945e8a
https://github.com/Perl/perl5/commit/ea648a8812ea7926831b761daef0c5ab14945e8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 7cc337ab85b07ed4ce9687109885bf77ee625054
https://github.com/Perl/perl5/commit/7cc337ab85b07ed4ce9687109885bf77ee625054
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 285fb2b67fbddef33d54585ea437c5fe2d47702a
https://github.com/Perl/perl5/commit/285fb2b67fbddef33d54585ea437c5fe2d47702a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 343cae2faafbc4911551dbff1c1d801fb04ce85a
https://github.com/Perl/perl5/commit/343cae2faafbc4911551dbff1c1d801fb04ce85a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: bec3bd2fe0af9049a528d1c67e286bdd6be00583
https://github.com/Perl/perl5/commit/bec3bd2fe0af9049a528d1c67e286bdd6be00583
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 44dea024e5767c6e02e4d7d389a6c495d20f09da
https://github.com/Perl/perl5/commit/44dea024e5767c6e02e4d7d389a6c495d20f09da
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 0a6c0d9ef226bf35ef3dd6132cdf54520df40ffa
https://github.com/Perl/perl5/commit/0a6c0d9ef226bf35ef3dd6132cdf54520df40ffa
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: fa9933d32067a5b04768c3c1c845367024b7aa26
https://github.com/Perl/perl5/commit/fa9933d32067a5b04768c3c1c845367024b7aa26
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 09959d69e949dfdaddba26aca234308b8184f154
https://github.com/Perl/perl5/commit/09959d69e949dfdaddba26aca234308b8184f154
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 2efc3b914d36d04702a927af7f23d622b48440fe
https://github.com/Perl/perl5/commit/2efc3b914d36d04702a927af7f23d622b48440fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: c9655e170d30a28a4d7209d0d218e808e509722e
https://github.com/Perl/perl5/commit/c9655e170d30a28a4d7209d0d218e808e509722e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 58d310bebd09a2084f04896d3e742c1ec2fb0f99
https://github.com/Perl/perl5/commit/58d310bebd09a2084f04896d3e742c1ec2fb0f99
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: deb83a4cacc860d1059be4f81d5907382cdd18f9
https://github.com/Perl/perl5/commit/deb83a4cacc860d1059be4f81d5907382cdd18f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 669c34ab5e6c6a818aa90f8d09c56ce990b84993
https://github.com/Perl/perl5/commit/669c34ab5e6c6a818aa90f8d09c56ce990b84993
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: eb0ac7ad0111fcf1958fcbd0edba4a1d10e5f340
https://github.com/Perl/perl5/commit/eb0ac7ad0111fcf1958fcbd0edba4a1d10e5f340
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 60aed350395545287dd1be9860fed80b651ce295
https://github.com/Perl/perl5/commit/60aed350395545287dd1be9860fed80b651ce295
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: eec76a8d81127251e9baf65999f2947919ec0c71
https://github.com/Perl/perl5/commit/eec76a8d81127251e9baf65999f2947919ec0c71
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: dfb50dfde25700e5c6022f3e081de5f47cf8a93c
https://github.com/Perl/perl5/commit/dfb50dfde25700e5c6022f3e081de5f47cf8a93c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 5993ee1f0470fb5fb0ad66047a531a1d6d531973
https://github.com/Perl/perl5/commit/5993ee1f0470fb5fb0ad66047a531a1d6d531973
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 6021532be4661fb3acb295a98b50157c34174d7f
https://github.com/Perl/perl5/commit/6021532be4661fb3acb295a98b50157c34174d7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d23502ce04c7c17ecab4b4183ea864c13da34237
https://github.com/Perl/perl5/commit/d23502ce04c7c17ecab4b4183ea864c13da34237
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 9fb80d7b83da8eb5eab32febc05a6b9d6bb00977
https://github.com/Perl/perl5/commit/9fb80d7b83da8eb5eab32febc05a6b9d6bb00977
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 95527584a3e6b075ab96216e57c5d06241cce8e4
https://github.com/Perl/perl5/commit/95527584a3e6b075ab96216e57c5d06241cce8e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 238f41b88dea3d59be40534ef8e987b233f95d83
https://github.com/Perl/perl5/commit/238f41b88dea3d59be40534ef8e987b233f95d83
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: d145e61c13283640155325e9026bfdb5505ce2e0
https://github.com/Perl/perl5/commit/d145e61c13283640155325e9026bfdb5505ce2e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 639d7686e6e53178b354a3293adfc55f5bd05dc6
https://github.com/Perl/perl5/commit/639d7686e6e53178b354a3293adfc55f5bd05dc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: a99cb973db2d76276940b602ee727b028a74de0e
https://github.com/Perl/perl5/commit/a99cb973db2d76276940b602ee727b028a74de0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 5e01b1b627bc0ca0f95589c905df624882e36bc4
https://github.com/Perl/perl5/commit/5e01b1b627bc0ca0f95589c905df624882e36bc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0713a80434dd17e2008af4daf15487812d5604c0
https://github.com/Perl/perl5/commit/0713a80434dd17e2008af4daf15487812d5604c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 372a66bdc1241685a751ec7ae619744ff0be7d79
https://github.com/Perl/perl5/commit/372a66bdc1241685a751ec7ae619744ff0be7d79
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 014c3a8b26d1c1d06873129a9e96c394ebac92ab
https://github.com/Perl/perl5/commit/014c3a8b26d1c1d06873129a9e96c394ebac92ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: d4a1dc61a44a581eff6a84dd71cd5d5712a9b184
https://github.com/Perl/perl5/commit/d4a1dc61a44a581eff6a84dd71cd5d5712a9b184
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 402ce6775f917cf84e74aef2f59d88531a799782
https://github.com/Perl/perl5/commit/402ce6775f917cf84e74aef2f59d88531a799782
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 31ee90ab22d71bc0e5251c450cf139a6f4afee24
https://github.com/Perl/perl5/commit/31ee90ab22d71bc0e5251c450cf139a6f4afee24
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 18124f8b1e6ce185b89ff5d962bd17577571d3d6
https://github.com/Perl/perl5/commit/18124f8b1e6ce185b89ff5d962bd17577571d3d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 694093d3eee5958f900d1559518a22c58ad88fd8
https://github.com/Perl/perl5/commit/694093d3eee5958f900d1559518a22c58ad88fd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 70cf15b1daef7256073de21e4d02b4e9ff2b6a03
https://github.com/Perl/perl5/commit/70cf15b1daef7256073de21e4d02b4e9ff2b6a03
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 169aa291c6574783d5dcc1d987ab273eda2237de
https://github.com/Perl/perl5/commit/169aa291c6574783d5dcc1d987ab273eda2237de
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 0c9a3b1c4a895b96543415508d913f35739aa3d6
https://github.com/Perl/perl5/commit/0c9a3b1c4a895b96543415508d913f35739aa3d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 2fe44829cb67e8f85648139c8836c1e4dfd64414
https://github.com/Perl/perl5/commit/2fe44829cb67e8f85648139c8836c1e4dfd64414
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 691e3666a269d15ab4a0b4b50ae0d548791076f2
https://github.com/Perl/perl5/commit/691e3666a269d15ab4a0b4b50ae0d548791076f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 24f31f9f4b0e0df2df02981db68e7dd8f5639c14
https://github.com/Perl/perl5/commit/24f31f9f4b0e0df2df02981db68e7dd8f5639c14
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 732b25e757fa8551a5a02a6e2f05a7db86a7ee91
https://github.com/Perl/perl5/commit/732b25e757fa8551a5a02a6e2f05a7db86a7ee91
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: fc051c2bac34172ce27e41f566a1702c4baf9e0a
https://github.com/Perl/perl5/commit/fc051c2bac34172ce27e41f566a1702c4baf9e0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: b61b3426703f8cc155ab23ddd506106bccd4f421
https://github.com/Perl/perl5/commit/b61b3426703f8cc155ab23ddd506106bccd4f421
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 0dce71cf525fd44595c9d4548cf831025abaff7c
https://github.com/Perl/perl5/commit/0dce71cf525fd44595c9d4548cf831025abaff7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 805d095065902f21726c2f34c9396b40df689976
https://github.com/Perl/perl5/commit/805d095065902f21726c2f34c9396b40df689976
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: b1172c8b700d2b820e66c6cac4b70d146a845180
https://github.com/Perl/perl5/commit/b1172c8b700d2b820e66c6cac4b70d146a845180
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f5c2ae0e493f1a8324818c6ad8abdd01f3381e1d
https://github.com/Perl/perl5/commit/f5c2ae0e493f1a8324818c6ad8abdd01f3381e1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 09a664a964da08c626f188ff0867391f78e92f97
https://github.com/Perl/perl5/commit/09a664a964da08c626f188ff0867391f78e92f97
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 415895a4b9ca9a3bb8ed657c17fd3fc579d0f83a
https://github.com/Perl/perl5/commit/415895a4b9ca9a3bb8ed657c17fd3fc579d0f83a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: a51b4e8adddc3c5e4a35101e85a262b3503ee63a
https://github.com/Perl/perl5/commit/a51b4e8adddc3c5e4a35101e85a262b3503ee63a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 943529c56a805f2a759a08fb4d270ee1b8dc7167
https://github.com/Perl/perl5/commit/943529c56a805f2a759a08fb4d270ee1b8dc7167
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 04041fba2ea1f486a1837db2733a0ace35add65b
https://github.com/Perl/perl5/commit/04041fba2ea1f486a1837db2733a0ace35add65b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: de6b282a14709997efe3d7d4b9c3e616300b7e3e
https://github.com/Perl/perl5/commit/de6b282a14709997efe3d7d4b9c3e616300b7e3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 9f5a6accaacbf81fc2b035ee35db56d32d5f2ae5
https://github.com/Perl/perl5/commit/9f5a6accaacbf81fc2b035ee35db56d32d5f2ae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: ecf97553d70bb443ead469cb89c9de4218575602
https://github.com/Perl/perl5/commit/ecf97553d70bb443ead469cb89c9de4218575602
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M patchlevel.h
M perl.h
M t/loc_tools.pl
Log Message:
-----------
more9
Compare: https://github.com/Perl/perl5/compare/b116aa0d2839...ecf97553d70b
