Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 1e21a53f7bb5525a64c2f5ae6102a0385d40a818
https://github.com/Perl/perl5/commit/1e21a53f7bb5525a64c2f5ae6102a0385d40a818
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 7562fd26d3e05963e0af23d9dfc7cbed54703dd3
https://github.com/Perl/perl5/commit/7562fd26d3e05963e0af23d9dfc7cbed54703dd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 5be687095ae59f6cfff5145d37d6c4a732034173
https://github.com/Perl/perl5/commit/5be687095ae59f6cfff5145d37d6c4a732034173
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: b8a44780e26a3283161ad22ef2796087044ac099
https://github.com/Perl/perl5/commit/b8a44780e26a3283161ad22ef2796087044ac099
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 2f5125a9b038a27b6ec7e3cf83c75f2ef9b5eca0
https://github.com/Perl/perl5/commit/2f5125a9b038a27b6ec7e3cf83c75f2ef9b5eca0
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: fc6bff6b48a08e4e2f894fda128b1d2d85401abf
https://github.com/Perl/perl5/commit/fc6bff6b48a08e4e2f894fda128b1d2d85401abf
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 27c942f4d17f36276e7cc60f300eca580907a835
https://github.com/Perl/perl5/commit/27c942f4d17f36276e7cc60f300eca580907a835
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: aa4ed2a54a0aee0170beb16cdd18d39d30c67613
https://github.com/Perl/perl5/commit/aa4ed2a54a0aee0170beb16cdd18d39d30c67613
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 17dc0cf85b133d011a1fbe169ea757d87ae78b8c
https://github.com/Perl/perl5/commit/17dc0cf85b133d011a1fbe169ea757d87ae78b8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: b8e363f08eeb4b946584f4bec106ea7a5e3a63e5
https://github.com/Perl/perl5/commit/b8e363f08eeb4b946584f4bec106ea7a5e3a63e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: fc2450e7cedc044b01e80a08a473bfaad823e821
https://github.com/Perl/perl5/commit/fc2450e7cedc044b01e80a08a473bfaad823e821
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 57663af3375a0077645093492e417a320b9780d4
https://github.com/Perl/perl5/commit/57663af3375a0077645093492e417a320b9780d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 032ee7ccdebfe92d6b42e667807693ba4e35e92e
https://github.com/Perl/perl5/commit/032ee7ccdebfe92d6b42e667807693ba4e35e92e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: c4397805523cf09d182130dc97da57cf45638926
https://github.com/Perl/perl5/commit/c4397805523cf09d182130dc97da57cf45638926
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: ab9c0fc97e9332700676448ff1933c73e50346f7
https://github.com/Perl/perl5/commit/ab9c0fc97e9332700676448ff1933c73e50346f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: fc7f70b83c3aeba17ed39e8703ba977de51bdfd6
https://github.com/Perl/perl5/commit/fc7f70b83c3aeba17ed39e8703ba977de51bdfd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 1523985688fa22e53e79962a15ac43c1059bc966
https://github.com/Perl/perl5/commit/1523985688fa22e53e79962a15ac43c1059bc966
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 81c13a9f9b7c83e28966be670150cadccc06993c
https://github.com/Perl/perl5/commit/81c13a9f9b7c83e28966be670150cadccc06993c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 33b10d0a7739b835606375926e600d51c295ccef
https://github.com/Perl/perl5/commit/33b10d0a7739b835606375926e600d51c295ccef
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 2ec0e8ab6d9ea0f11a5ad73098ae9145bbdee4a4
https://github.com/Perl/perl5/commit/2ec0e8ab6d9ea0f11a5ad73098ae9145bbdee4a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 6371c87b467e6f52b7562efd80ccfdc9a6750aa9
https://github.com/Perl/perl5/commit/6371c87b467e6f52b7562efd80ccfdc9a6750aa9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 7825fa4bfdfd0459e542bdcac2e172ac8baee539
https://github.com/Perl/perl5/commit/7825fa4bfdfd0459e542bdcac2e172ac8baee539
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 01277424fb1754c567846268dadc4d08f5071634
https://github.com/Perl/perl5/commit/01277424fb1754c567846268dadc4d08f5071634
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: e9f1010a1aacb81abcd4647f47b6880013a857bc
https://github.com/Perl/perl5/commit/e9f1010a1aacb81abcd4647f47b6880013a857bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 2db6f03d08ce828cdf008b0c826451bed19240dd
https://github.com/Perl/perl5/commit/2db6f03d08ce828cdf008b0c826451bed19240dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 8610d285b72668d1462b38d5c12a0c922bcef135
https://github.com/Perl/perl5/commit/8610d285b72668d1462b38d5c12a0c922bcef135
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: f30649de879283bda4ccbf2c6b1eaae1b95c4417
https://github.com/Perl/perl5/commit/f30649de879283bda4ccbf2c6b1eaae1b95c4417
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: a0d26510a3f0d4881b9b9b29c41d04ca114e3e9a
https://github.com/Perl/perl5/commit/a0d26510a3f0d4881b9b9b29c41d04ca114e3e9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: d0cb912c80f1558c6febbe055623e86bd3d2cbbf
https://github.com/Perl/perl5/commit/d0cb912c80f1558c6febbe055623e86bd3d2cbbf
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 8f84ca47c3e3079a1a61d84b156dc64f61a901b1
https://github.com/Perl/perl5/commit/8f84ca47c3e3079a1a61d84b156dc64f61a901b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: d2a36925c4ee3370b506621bf1a7d71a8277a162
https://github.com/Perl/perl5/commit/d2a36925c4ee3370b506621bf1a7d71a8277a162
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 3ae499428c46c4ddfaee8c6cd6ee7503f94c65df
https://github.com/Perl/perl5/commit/3ae499428c46c4ddfaee8c6cd6ee7503f94c65df
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 4c747cc3b1b07d6333b06429e78f9b8b44502a54
https://github.com/Perl/perl5/commit/4c747cc3b1b07d6333b06429e78f9b8b44502a54
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 0fa5d1fdabb4eafe5d7d53a48c17958e0ca0c2f8
https://github.com/Perl/perl5/commit/0fa5d1fdabb4eafe5d7d53a48c17958e0ca0c2f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: bf824eb8adc9ce457f71f96359bf57e4d5e31dd8
https://github.com/Perl/perl5/commit/bf824eb8adc9ce457f71f96359bf57e4d5e31dd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 365631e32aaf13bf76a33d38bc0c789fa6beed5a
https://github.com/Perl/perl5/commit/365631e32aaf13bf76a33d38bc0c789fa6beed5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 04d456a914779cec3d8f373e7d4556c21a0386fd
https://github.com/Perl/perl5/commit/04d456a914779cec3d8f373e7d4556c21a0386fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 4e940cbb371f6d27ddd9c918e0083985e35bf0f3
https://github.com/Perl/perl5/commit/4e940cbb371f6d27ddd9c918e0083985e35bf0f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 761608c9b1d97b487c762031f6750069e65a713a
https://github.com/Perl/perl5/commit/761608c9b1d97b487c762031f6750069e65a713a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: bb912c9d50f4aefce2bd53beb9951a49fd091a86
https://github.com/Perl/perl5/commit/bb912c9d50f4aefce2bd53beb9951a49fd091a86
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 1ced50b1d303224077256307dee74eaa36a1ce39
https://github.com/Perl/perl5/commit/1ced50b1d303224077256307dee74eaa36a1ce39
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 66c3885f55159f3e33df704dc88f9ff2e58a4354
https://github.com/Perl/perl5/commit/66c3885f55159f3e33df704dc88f9ff2e58a4354
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: fb4e4096d55453765607c6d861de9e2c1fe102ef
https://github.com/Perl/perl5/commit/fb4e4096d55453765607c6d861de9e2c1fe102ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 928dd5ebbf372bb016c226332f8482e70b598c24
https://github.com/Perl/perl5/commit/928dd5ebbf372bb016c226332f8482e70b598c24
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: e6d7d638883d1af195823f85c8621c84aec753cb
https://github.com/Perl/perl5/commit/e6d7d638883d1af195823f85c8621c84aec753cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 8a7d85ea71ca37790730046c3633dd9c74144b79
https://github.com/Perl/perl5/commit/8a7d85ea71ca37790730046c3633dd9c74144b79
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: c3c091a3b5553ff62bb6d3974f3ffe3d84715eda
https://github.com/Perl/perl5/commit/c3c091a3b5553ff62bb6d3974f3ffe3d84715eda
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: ce19d40686aef8e955da0239a52328ded8141187
https://github.com/Perl/perl5/commit/ce19d40686aef8e955da0239a52328ded8141187
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 0f197f30af7fa7f0455d65da54c4bfdfcf5cd4f2
https://github.com/Perl/perl5/commit/0f197f30af7fa7f0455d65da54c4bfdfcf5cd4f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 78b0edfda53f8c9befa40a7df061b35035507551
https://github.com/Perl/perl5/commit/78b0edfda53f8c9befa40a7df061b35035507551
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: f2dcd10703d7f49c9a54bd4a4516084f0a16a701
https://github.com/Perl/perl5/commit/f2dcd10703d7f49c9a54bd4a4516084f0a16a701
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: a80295036a5774a56013d2298092e56ce07d18a8
https://github.com/Perl/perl5/commit/a80295036a5774a56013d2298092e56ce07d18a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 3046ad91dff6bc93bec1b0bd2e4df474039f37aa
https://github.com/Perl/perl5/commit/3046ad91dff6bc93bec1b0bd2e4df474039f37aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 4ad3a0e1bd99123e85acacccb880c0264c93c095
https://github.com/Perl/perl5/commit/4ad3a0e1bd99123e85acacccb880c0264c93c095
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 996179ca0882619836c1bad228525659162aefe5
https://github.com/Perl/perl5/commit/996179ca0882619836c1bad228525659162aefe5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 131c05eba9bf6dac2217ecd6897e54e2492ac183
https://github.com/Perl/perl5/commit/131c05eba9bf6dac2217ecd6897e54e2492ac183
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: e980411d2db7247a68ca4cb27534224ab8de6e4d
https://github.com/Perl/perl5/commit/e980411d2db7247a68ca4cb27534224ab8de6e4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 74012ad710d68276c0c1055f25437832dfe8137e
https://github.com/Perl/perl5/commit/74012ad710d68276c0c1055f25437832dfe8137e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 15a13ede16ac4012d1ead63207d01f7171d234e4
https://github.com/Perl/perl5/commit/15a13ede16ac4012d1ead63207d01f7171d234e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 5dd2e7e89207dd7655d4ab6116e7339120d894e4
https://github.com/Perl/perl5/commit/5dd2e7e89207dd7655d4ab6116e7339120d894e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 18d8e6e65995e4c88583a11941d89ea195d317bd
https://github.com/Perl/perl5/commit/18d8e6e65995e4c88583a11941d89ea195d317bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: afb501b79541ad088bc8eb5b631bda31102e9a8e
https://github.com/Perl/perl5/commit/afb501b79541ad088bc8eb5b631bda31102e9a8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: cfcc8a66f1d6a7d99e49ccc95dcab9d0afe1ed47
https://github.com/Perl/perl5/commit/cfcc8a66f1d6a7d99e49ccc95dcab9d0afe1ed47
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: e0aa9b7aee9e2bfd550487f99e1507001f2ce41f
https://github.com/Perl/perl5/commit/e0aa9b7aee9e2bfd550487f99e1507001f2ce41f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 881d657dc110431ae48bf8005eb5be372108e0fc
https://github.com/Perl/perl5/commit/881d657dc110431ae48bf8005eb5be372108e0fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 8fd3f16967254b443de0f0681ddb9ec338069156
https://github.com/Perl/perl5/commit/8fd3f16967254b443de0f0681ddb9ec338069156
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: db5d8e5399709b5399cb20f35cdd7e724541410c
https://github.com/Perl/perl5/commit/db5d8e5399709b5399cb20f35cdd7e724541410c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: b33da190cc4a09acde9d3bd57a9d4c9aabb51d00
https://github.com/Perl/perl5/commit/b33da190cc4a09acde9d3bd57a9d4c9aabb51d00
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: b6034a914762dd5299bcef716c02a5544e9ec337
https://github.com/Perl/perl5/commit/b6034a914762dd5299bcef716c02a5544e9ec337
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 1b080c7639b4361511a9e4e73787d8f8d8ee7c7a
https://github.com/Perl/perl5/commit/1b080c7639b4361511a9e4e73787d8f8d8ee7c7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 30ce3b5257b7ea2fda20ddf6771cffec6821ac2f
https://github.com/Perl/perl5/commit/30ce3b5257b7ea2fda20ddf6771cffec6821ac2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: ead8008f78acc4632ce3f2d2161debb11fe9f8f1
https://github.com/Perl/perl5/commit/ead8008f78acc4632ce3f2d2161debb11fe9f8f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: d8e71336b1756ae3bd57d1828ddcc2efce4c3c4b
https://github.com/Perl/perl5/commit/d8e71336b1756ae3bd57d1828ddcc2efce4c3c4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: c3927f3dd473a0ef39aa965085380da4a66548d5
https://github.com/Perl/perl5/commit/c3927f3dd473a0ef39aa965085380da4a66548d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: e3153c97611841e58a8a34d4576fde08656548cf
https://github.com/Perl/perl5/commit/e3153c97611841e58a8a34d4576fde08656548cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 449d6437455d9414214177b2c053fe0c5e2dc939
https://github.com/Perl/perl5/commit/449d6437455d9414214177b2c053fe0c5e2dc939
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 78b55a7941037b295afa21706632432f2628ef73
https://github.com/Perl/perl5/commit/78b55a7941037b295afa21706632432f2628ef73
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 80c86fbf80f0d71a60fa1c14c93f293e7366ab4a
https://github.com/Perl/perl5/commit/80c86fbf80f0d71a60fa1c14c93f293e7366ab4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 0d6fd2c340d205efc51021aab4b84446c1bc7e7a
https://github.com/Perl/perl5/commit/0d6fd2c340d205efc51021aab4b84446c1bc7e7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: c867dfca503e951de867efd9992eef5af91f31f0
https://github.com/Perl/perl5/commit/c867dfca503e951de867efd9992eef5af91f31f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 66c59a58dba0baf78d516047bef8fe5420882bee
https://github.com/Perl/perl5/commit/66c59a58dba0baf78d516047bef8fe5420882bee
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: f3e14c2dc7cd259d0ae0fa916424ec676e5b1d88
https://github.com/Perl/perl5/commit/f3e14c2dc7cd259d0ae0fa916424ec676e5b1d88
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: b2a7c4676e0ebb3c63da6da697166af093473d84
https://github.com/Perl/perl5/commit/b2a7c4676e0ebb3c63da6da697166af093473d84
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: d316ed84eabd66419866fdb346ec77024d23964d
https://github.com/Perl/perl5/commit/d316ed84eabd66419866fdb346ec77024d23964d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 119cdfc6356bc6da498662520718e02f5f6a7404
https://github.com/Perl/perl5/commit/119cdfc6356bc6da498662520718e02f5f6a7404
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: dfdc6e703331b2ee2e90b8f30968cbe7664382f5
https://github.com/Perl/perl5/commit/dfdc6e703331b2ee2e90b8f30968cbe7664382f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 9dc699b57bffc7d072f02dd1691e4536eb41a043
https://github.com/Perl/perl5/commit/9dc699b57bffc7d072f02dd1691e4536eb41a043
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 776a34ba52d30d2fdd9660f3005387dea7a05a7e
https://github.com/Perl/perl5/commit/776a34ba52d30d2fdd9660f3005387dea7a05a7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 75d9c88fb65aebe89c2f75c0115f78700947099c
https://github.com/Perl/perl5/commit/75d9c88fb65aebe89c2f75c0115f78700947099c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 7fb447bf53cfa3fb769550cdf25c17c6a44ce0e4
https://github.com/Perl/perl5/commit/7fb447bf53cfa3fb769550cdf25c17c6a44ce0e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: b4e9fcdcf1cf97f6735e8037f819c26415890b0d
https://github.com/Perl/perl5/commit/b4e9fcdcf1cf97f6735e8037f819c26415890b0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 252773174e3964a1b3c9879723d9796b52edbe02
https://github.com/Perl/perl5/commit/252773174e3964a1b3c9879723d9796b52edbe02
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: a52882b6ec8133bd344b6f74d8f26517587d425e
https://github.com/Perl/perl5/commit/a52882b6ec8133bd344b6f74d8f26517587d425e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: e630000798b3447b5964d2211d51206ecf99ee0e
https://github.com/Perl/perl5/commit/e630000798b3447b5964d2211d51206ecf99ee0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 6d0e96b3abc17b0307313aa635fcaf42ad008f2c
https://github.com/Perl/perl5/commit/6d0e96b3abc17b0307313aa635fcaf42ad008f2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 5e9aa79f8e33a3704342e7f3461a7ff856891a49
https://github.com/Perl/perl5/commit/5e9aa79f8e33a3704342e7f3461a7ff856891a49
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 9a55def84d7d5934f4a98ce99ab2861730df46d6
https://github.com/Perl/perl5/commit/9a55def84d7d5934f4a98ce99ab2861730df46d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 28c974410d8c77e690b394b1d82a57ee89f8282c
https://github.com/Perl/perl5/commit/28c974410d8c77e690b394b1d82a57ee89f8282c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 72d9c0ec21c1cb50ad0f8f2d6966f1f08eab034d
https://github.com/Perl/perl5/commit/72d9c0ec21c1cb50ad0f8f2d6966f1f08eab034d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: dacf7c095064a92ebb4a81d7360b3b2d5b39bc41
https://github.com/Perl/perl5/commit/dacf7c095064a92ebb4a81d7360b3b2d5b39bc41
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 3600c80764582c1eef847c3c2410c09afb4809e3
https://github.com/Perl/perl5/commit/3600c80764582c1eef847c3c2410c09afb4809e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 80b588c0881f39b2f0ee5f47e3e044f854eac15e
https://github.com/Perl/perl5/commit/80b588c0881f39b2f0ee5f47e3e044f854eac15e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 143d02304f9d511060eeadcc4f6b56128f04398d
https://github.com/Perl/perl5/commit/143d02304f9d511060eeadcc4f6b56128f04398d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 861b10bf25d861a189af8f47aa15691f053e119a
https://github.com/Perl/perl5/commit/861b10bf25d861a189af8f47aa15691f053e119a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 91765605eff8f3112c6a4dc9e97d3c7a810b4794
https://github.com/Perl/perl5/commit/91765605eff8f3112c6a4dc9e97d3c7a810b4794
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 51e16a185c29cad2f26ff480ee65b9eef1840e6f
https://github.com/Perl/perl5/commit/51e16a185c29cad2f26ff480ee65b9eef1840e6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: db14ade2597250f25f569b71c4c1b11226c2ca20
https://github.com/Perl/perl5/commit/db14ade2597250f25f569b71c4c1b11226c2ca20
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: e8a95c9166b897fefc68f03dfcb8cc40374258e7
https://github.com/Perl/perl5/commit/e8a95c9166b897fefc68f03dfcb8cc40374258e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 6185e11ca97c19d2665dec50fa732409e148cfeb
https://github.com/Perl/perl5/commit/6185e11ca97c19d2665dec50fa732409e148cfeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 74de229b27e87fa5c7bf661fe476e3286bf15b26
https://github.com/Perl/perl5/commit/74de229b27e87fa5c7bf661fe476e3286bf15b26
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: ba919d754d2c71334ba500b2c7aeffd5d1ead578
https://github.com/Perl/perl5/commit/ba919d754d2c71334ba500b2c7aeffd5d1ead578
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 40c608e8ef492a6fea6595aeda0d11d3a9964811
https://github.com/Perl/perl5/commit/40c608e8ef492a6fea6595aeda0d11d3a9964811
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 382bc15b18be4ebe5c28c71d75855378cc12a486
https://github.com/Perl/perl5/commit/382bc15b18be4ebe5c28c71d75855378cc12a486
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 374e96e1a2deb648a2fb98fec4e030c176d3579f
https://github.com/Perl/perl5/commit/374e96e1a2deb648a2fb98fec4e030c176d3579f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 76efa75a8a2521267a9ace900558ebbefe0dd88e
https://github.com/Perl/perl5/commit/76efa75a8a2521267a9ace900558ebbefe0dd88e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 3e1d141c12c8f94fb4dbdb1ab5a39aaa411f85c1
https://github.com/Perl/perl5/commit/3e1d141c12c8f94fb4dbdb1ab5a39aaa411f85c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 91737599fd6261a4293ceae4046df1b3ed75585f
https://github.com/Perl/perl5/commit/91737599fd6261a4293ceae4046df1b3ed75585f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 9d6eab454330b8424ccc434fdf905b3598ca6a61
https://github.com/Perl/perl5/commit/9d6eab454330b8424ccc434fdf905b3598ca6a61
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: b4eb2aab369a969a806b7324bcc7619be104d17d
https://github.com/Perl/perl5/commit/b4eb2aab369a969a806b7324bcc7619be104d17d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: c9caec975598cd441be5ba5a3ea4176244ea2f23
https://github.com/Perl/perl5/commit/c9caec975598cd441be5ba5a3ea4176244ea2f23
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 4d245b1978679a5dc077c146a4b00500c5f7203b
https://github.com/Perl/perl5/commit/4d245b1978679a5dc077c146a4b00500c5f7203b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 594f708769768b72973e24e2c62d4e5889abeedd
https://github.com/Perl/perl5/commit/594f708769768b72973e24e2c62d4e5889abeedd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: fd7166e2857ed50a415049bd978f936af8432e1e
https://github.com/Perl/perl5/commit/fd7166e2857ed50a415049bd978f936af8432e1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 156777071a44a305298687a7da16be88d8fc8b04
https://github.com/Perl/perl5/commit/156777071a44a305298687a7da16be88d8fc8b04
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 9dcc5427c417b269efd378a20450129dd634634f
https://github.com/Perl/perl5/commit/9dcc5427c417b269efd378a20450129dd634634f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 6b58524a5019979ce3ee83bb459bd33ccfcace38
https://github.com/Perl/perl5/commit/6b58524a5019979ce3ee83bb459bd33ccfcace38
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: c838a401db0c12421994317b6cb47c80f61af282
https://github.com/Perl/perl5/commit/c838a401db0c12421994317b6cb47c80f61af282
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 4bd9056b9934da2971e3a3bbf5cd22d861a6f769
https://github.com/Perl/perl5/commit/4bd9056b9934da2971e3a3bbf5cd22d861a6f769
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 5fe0020ab6939ec7126471347c1d4051973452ac
https://github.com/Perl/perl5/commit/5fe0020ab6939ec7126471347c1d4051973452ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 93b25e53e5c81649fc41db4f115a74abd1d64d7d
https://github.com/Perl/perl5/commit/93b25e53e5c81649fc41db4f115a74abd1d64d7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: fb2669e0555b4b1aeadf43ed09d28dca7489d7bb
https://github.com/Perl/perl5/commit/fb2669e0555b4b1aeadf43ed09d28dca7489d7bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 7ad3ba3332bc616bd8747ec4340558f7bc6a6ab4
https://github.com/Perl/perl5/commit/7ad3ba3332bc616bd8747ec4340558f7bc6a6ab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 504cf2e84d59603b40189eab7a4220af5d0598d6
https://github.com/Perl/perl5/commit/504cf2e84d59603b40189eab7a4220af5d0598d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 2e95bd4754788531c459e17f033c1dca0292d70b
https://github.com/Perl/perl5/commit/2e95bd4754788531c459e17f033c1dca0292d70b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 9711ef8f6419d5a8d1f815fdff7b8881be8834bc
https://github.com/Perl/perl5/commit/9711ef8f6419d5a8d1f815fdff7b8881be8834bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 59be9669163dc16f6b3c8b317d9f0a4ed1845cb1
https://github.com/Perl/perl5/commit/59be9669163dc16f6b3c8b317d9f0a4ed1845cb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 6599914908e5009c85195f3ebbc7e15e299437a0
https://github.com/Perl/perl5/commit/6599914908e5009c85195f3ebbc7e15e299437a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: c73930bde9ccafd1c1ebed861dcdd6ce914d2aea
https://github.com/Perl/perl5/commit/c73930bde9ccafd1c1ebed861dcdd6ce914d2aea
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: c05aea626b7d88655623ee704a1fba54bfab0ab7
https://github.com/Perl/perl5/commit/c05aea626b7d88655623ee704a1fba54bfab0ab7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 3377dfb2471a8bfcdc2161dea0ace7ca35d1cbaa
https://github.com/Perl/perl5/commit/3377dfb2471a8bfcdc2161dea0ace7ca35d1cbaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 891dec12514c0a8b9ecb413991824473e2935ee1
https://github.com/Perl/perl5/commit/891dec12514c0a8b9ecb413991824473e2935ee1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 98602c64d9b91849648551a2da8d0dc45da5f1a7
https://github.com/Perl/perl5/commit/98602c64d9b91849648551a2da8d0dc45da5f1a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 7cede9bd8f5036aaed6e0bfbe529c4167d502c25
https://github.com/Perl/perl5/commit/7cede9bd8f5036aaed6e0bfbe529c4167d502c25
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: d7d40dc4437cd85913c243a73fa5ccca6e6186c5
https://github.com/Perl/perl5/commit/d7d40dc4437cd85913c243a73fa5ccca6e6186c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 39c91640952da1a4d59cb069853c8ce2b546d39f
https://github.com/Perl/perl5/commit/39c91640952da1a4d59cb069853c8ce2b546d39f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 17115b4d9aabe1fe51996a9e9d8c6f9327305f85
https://github.com/Perl/perl5/commit/17115b4d9aabe1fe51996a9e9d8c6f9327305f85
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 62cd92079aeb6b983528bb34be985b908cf0ca11
https://github.com/Perl/perl5/commit/62cd92079aeb6b983528bb34be985b908cf0ca11
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 0825ccfb33727f347ec0fdcfa9bae1a0054aaf3c
https://github.com/Perl/perl5/commit/0825ccfb33727f347ec0fdcfa9bae1a0054aaf3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: b26a690f297d544edd638e1979bd93f620e0d4ac
https://github.com/Perl/perl5/commit/b26a690f297d544edd638e1979bd93f620e0d4ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 3f8254319a544df514d2418052ff1f076f0965e9
https://github.com/Perl/perl5/commit/3f8254319a544df514d2418052ff1f076f0965e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: fea6ecbc40557a7c13a2f80e1b66f52322be379d
https://github.com/Perl/perl5/commit/fea6ecbc40557a7c13a2f80e1b66f52322be379d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 9d32f7126931d609206edd32b445ba8383163406
https://github.com/Perl/perl5/commit/9d32f7126931d609206edd32b445ba8383163406
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: ac90e6aeeacaa16dedb91160fc091a9ae370854b
https://github.com/Perl/perl5/commit/ac90e6aeeacaa16dedb91160fc091a9ae370854b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: b6c10c8b1f2b74d9bbdb2256fd663ba08018ea75
https://github.com/Perl/perl5/commit/b6c10c8b1f2b74d9bbdb2256fd663ba08018ea75
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: f0ae530c13aaa9adf4c35a4b5ee52b9e5b78dc0f
https://github.com/Perl/perl5/commit/f0ae530c13aaa9adf4c35a4b5ee52b9e5b78dc0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: ab6360ce6e5c97ede6728db25a804b6ec61bcd5f
https://github.com/Perl/perl5/commit/ab6360ce6e5c97ede6728db25a804b6ec61bcd5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: d4fc91ade112a7f26a3ba56164f4695a862168b3
https://github.com/Perl/perl5/commit/d4fc91ade112a7f26a3ba56164f4695a862168b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: ecf6fcc42290ef3fc2ef16c0570d4d575de057d3
https://github.com/Perl/perl5/commit/ecf6fcc42290ef3fc2ef16c0570d4d575de057d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: ebd5ab985ffd58a473e9d9b81e2dee13bb2c8c27
https://github.com/Perl/perl5/commit/ebd5ab985ffd58a473e9d9b81e2dee13bb2c8c27
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: e83ca535d9e1779bbc26df0d3cf9a8b55574d99b
https://github.com/Perl/perl5/commit/e83ca535d9e1779bbc26df0d3cf9a8b55574d99b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: b839f978a1be01ed6c4266cdbc5b725e55a8f8c7
https://github.com/Perl/perl5/commit/b839f978a1be01ed6c4266cdbc5b725e55a8f8c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 7e16c7a25c96767863a3c7a0e4f6ce4b79cd04c1
https://github.com/Perl/perl5/commit/7e16c7a25c96767863a3c7a0e4f6ce4b79cd04c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: b45482a0dc14475968cea56c98052e55ffc0aea1
https://github.com/Perl/perl5/commit/b45482a0dc14475968cea56c98052e55ffc0aea1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: dfc48008f03f0798b930b4550bbd191440dd89a6
https://github.com/Perl/perl5/commit/dfc48008f03f0798b930b4550bbd191440dd89a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 5bf7d0d344139a32a9801c65edcf5c256313671c
https://github.com/Perl/perl5/commit/5bf7d0d344139a32a9801c65edcf5c256313671c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: fe51dd2a5da141b7e1f362bb04f1046047b82f68
https://github.com/Perl/perl5/commit/fe51dd2a5da141b7e1f362bb04f1046047b82f68
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: daf7751a5924de7d16e0900b02b23a954ad4d952
https://github.com/Perl/perl5/commit/daf7751a5924de7d16e0900b02b23a954ad4d952
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: ed2e49a3958cb8d571bcfb2ca55f6a1aa06ae52e
https://github.com/Perl/perl5/commit/ed2e49a3958cb8d571bcfb2ca55f6a1aa06ae52e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 391c91d25f4c515d242404072b793aab0ed56b0f
https://github.com/Perl/perl5/commit/391c91d25f4c515d242404072b793aab0ed56b0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: c974c132e12e69e001fe32febb0e497671a7811a
https://github.com/Perl/perl5/commit/c974c132e12e69e001fe32febb0e497671a7811a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 18d0c7ccf991187fd47f1acf3a300625c642e3de
https://github.com/Perl/perl5/commit/18d0c7ccf991187fd47f1acf3a300625c642e3de
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: d861e4649f4576c411339416a487c072c66417af
https://github.com/Perl/perl5/commit/d861e4649f4576c411339416a487c072c66417af
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 6b4a9eb7828320f72c5e01cdd9f971a2ed80ba3a
https://github.com/Perl/perl5/commit/6b4a9eb7828320f72c5e01cdd9f971a2ed80ba3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: cb4f47ef73b3d5df9de15d9c8ad2ebfb36b1deaf
https://github.com/Perl/perl5/commit/cb4f47ef73b3d5df9de15d9c8ad2ebfb36b1deaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5bee8e121eccfb379f75c2e10ae0ae17ff288e56
https://github.com/Perl/perl5/commit/5bee8e121eccfb379f75c2e10ae0ae17ff288e56
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 51f0c8b96976da38bee2760e31a84bd6b75082dc
https://github.com/Perl/perl5/commit/51f0c8b96976da38bee2760e31a84bd6b75082dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 19dcab8e4b03aee0fed71fecf767bd928b2c842d
https://github.com/Perl/perl5/commit/19dcab8e4b03aee0fed71fecf767bd928b2c842d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: ceee78937f095706fe71b56e36b18c3df7f1afbc
https://github.com/Perl/perl5/commit/ceee78937f095706fe71b56e36b18c3df7f1afbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: a6cb7285cbd0ec23f132054606b2f7cfbaad9b75
https://github.com/Perl/perl5/commit/a6cb7285cbd0ec23f132054606b2f7cfbaad9b75
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 41156d1bdb7ce9cd15136316885fcd810d96e7da
https://github.com/Perl/perl5/commit/41156d1bdb7ce9cd15136316885fcd810d96e7da
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 6eb1c2f945f775afcec0457a7800a41cac1e3b3b
https://github.com/Perl/perl5/commit/6eb1c2f945f775afcec0457a7800a41cac1e3b3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 33f382deead588986143a75f5149e459918a7fcd
https://github.com/Perl/perl5/commit/33f382deead588986143a75f5149e459918a7fcd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 264af11670e1257a23e65165b8feee2f39873468
https://github.com/Perl/perl5/commit/264af11670e1257a23e65165b8feee2f39873468
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 9cc6b5acf888972d78eacafbf980f6f6ade4eb7c
https://github.com/Perl/perl5/commit/9cc6b5acf888972d78eacafbf980f6f6ade4eb7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 8de0e7b76470ed4ac104243bdf3586d0527ab729
https://github.com/Perl/perl5/commit/8de0e7b76470ed4ac104243bdf3586d0527ab729
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: fd317d04569959739eb410f5f645999f92ced826
https://github.com/Perl/perl5/commit/fd317d04569959739eb410f5f645999f92ced826
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 21e48c0f5fcc9657d36cb56e679c9d8d420d41bb
https://github.com/Perl/perl5/commit/21e48c0f5fcc9657d36cb56e679c9d8d420d41bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 282eafb25646aa2579c85c0e34a9bcb9fb03c733
https://github.com/Perl/perl5/commit/282eafb25646aa2579c85c0e34a9bcb9fb03c733
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: f2454cf9b9cb8090aca5fce322636112da0bc0c0
https://github.com/Perl/perl5/commit/f2454cf9b9cb8090aca5fce322636112da0bc0c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 46e70a1e5e85823a543d8130b9f31d1e83d7e987
https://github.com/Perl/perl5/commit/46e70a1e5e85823a543d8130b9f31d1e83d7e987
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 1419897208197548147a08a69dda3ededd79a837
https://github.com/Perl/perl5/commit/1419897208197548147a08a69dda3ededd79a837
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 9346144614729a82fa83316d58d01157b743b2c2
https://github.com/Perl/perl5/commit/9346144614729a82fa83316d58d01157b743b2c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 9aff4d1f70c6c4c9896891685a348e051300be29
https://github.com/Perl/perl5/commit/9aff4d1f70c6c4c9896891685a348e051300be29
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: ea8bd4b695385f46bd788213535160bd1820b693
https://github.com/Perl/perl5/commit/ea8bd4b695385f46bd788213535160bd1820b693
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 83fcc09fba46281b6bfd613c1d2c672380a77b8f
https://github.com/Perl/perl5/commit/83fcc09fba46281b6bfd613c1d2c672380a77b8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 4b121650e4a43fc8eef11377516aaf97a8662469
https://github.com/Perl/perl5/commit/4b121650e4a43fc8eef11377516aaf97a8662469
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: d134ebf37f7d47236ca3b257e34456b543db45d1
https://github.com/Perl/perl5/commit/d134ebf37f7d47236ca3b257e34456b543db45d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 30bd093e77f643448d2b5d32e68565011eaa2ad4
https://github.com/Perl/perl5/commit/30bd093e77f643448d2b5d32e68565011eaa2ad4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: f71278f1df2cc2cf619d81208540c94b2e3f9f42
https://github.com/Perl/perl5/commit/f71278f1df2cc2cf619d81208540c94b2e3f9f42
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: b8eee0d509329081c9c26bc914949413ccf5a701
https://github.com/Perl/perl5/commit/b8eee0d509329081c9c26bc914949413ccf5a701
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 9ced9d7779e86c7af9398d551ef15ff383a94451
https://github.com/Perl/perl5/commit/9ced9d7779e86c7af9398d551ef15ff383a94451
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: fa9e840a574aa7272aa8e634d6e7be43aaf5db81
https://github.com/Perl/perl5/commit/fa9e840a574aa7272aa8e634d6e7be43aaf5db81
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 183357b17565d8ec041d6c3f1ba25f31974b4e0f
https://github.com/Perl/perl5/commit/183357b17565d8ec041d6c3f1ba25f31974b4e0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 09a2bac189b3e93ccb32240c000bedeb28cfb1ac
https://github.com/Perl/perl5/commit/09a2bac189b3e93ccb32240c000bedeb28cfb1ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: f860244a1cb18e42bbdc49a4ae52f8f8e34f0eca
https://github.com/Perl/perl5/commit/f860244a1cb18e42bbdc49a4ae52f8f8e34f0eca
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: e9a94a4993bbf137fad8761731ab268a260fcfc4
https://github.com/Perl/perl5/commit/e9a94a4993bbf137fad8761731ab268a260fcfc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: a9eb4999002e57499f298c0f02d91c95c39f62b5
https://github.com/Perl/perl5/commit/a9eb4999002e57499f298c0f02d91c95c39f62b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 10663bf3707aab6f98dbc63f345485d35e51548f
https://github.com/Perl/perl5/commit/10663bf3707aab6f98dbc63f345485d35e51548f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 97576fae08375efee340a7a822fd4866e55a7f57
https://github.com/Perl/perl5/commit/97576fae08375efee340a7a822fd4866e55a7f57
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 8575368b3b3a143ee827085683e488fc9f9a377a
https://github.com/Perl/perl5/commit/8575368b3b3a143ee827085683e488fc9f9a377a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: e984acc5338d4c2bf68d773b8600ab66c8cd50c7
https://github.com/Perl/perl5/commit/e984acc5338d4c2bf68d773b8600ab66c8cd50c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M patchlevel.h
M perl.h
M sv.c
M t/loc_tools.pl
Log Message:
-----------
more10
Compare: https://github.com/Perl/perl5/compare/ecf97553d70b...e984acc5338d
