Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: b0d5193d9b4a1b784f11ac8d578396be921e8758
https://github.com/Perl/perl5/commit/b0d5193d9b4a1b784f11ac8d578396be921e8758
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 02ebce08a3a180953c637f1a2a2e452d0da186da
https://github.com/Perl/perl5/commit/02ebce08a3a180953c637f1a2a2e452d0da186da
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 4aeaeaff5ff25c71351715307ba1ae366985ed89
https://github.com/Perl/perl5/commit/4aeaeaff5ff25c71351715307ba1ae366985ed89
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 53c80e12cd8c405bb3cf17de05ff987c07a40092
https://github.com/Perl/perl5/commit/53c80e12cd8c405bb3cf17de05ff987c07a40092
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 8d998101d628ceb3773165df8fc7ffa29b790c39
https://github.com/Perl/perl5/commit/8d998101d628ceb3773165df8fc7ffa29b790c39
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: df10cb8b93b545d58b34b0085e5308268bd81400
https://github.com/Perl/perl5/commit/df10cb8b93b545d58b34b0085e5308268bd81400
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 0b257e25fd4da16d3392396d4571cc1fb5fd9f33
https://github.com/Perl/perl5/commit/0b257e25fd4da16d3392396d4571cc1fb5fd9f33
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 056e4d0b0f66ca2fc3528e146b59b90861ae39ee
https://github.com/Perl/perl5/commit/056e4d0b0f66ca2fc3528e146b59b90861ae39ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 0ba1e58c5a81e7bb34aa824f1e56acd3f13e2f41
https://github.com/Perl/perl5/commit/0ba1e58c5a81e7bb34aa824f1e56acd3f13e2f41
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 324b6d82dc924443fbb780c05a13df36c08b658f
https://github.com/Perl/perl5/commit/324b6d82dc924443fbb780c05a13df36c08b658f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 7ad990cb24fa451895c5e253e8017d40c486f678
https://github.com/Perl/perl5/commit/7ad990cb24fa451895c5e253e8017d40c486f678
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 8513a0c2f2df84e52303e2862bbeb2aea689af53
https://github.com/Perl/perl5/commit/8513a0c2f2df84e52303e2862bbeb2aea689af53
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: ed8366e8d96b44ac5fdb163f55bb040b3e9b81c3
https://github.com/Perl/perl5/commit/ed8366e8d96b44ac5fdb163f55bb040b3e9b81c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 6da27466b95edb5975063b6a37ee7fa4b0a5d85b
https://github.com/Perl/perl5/commit/6da27466b95edb5975063b6a37ee7fa4b0a5d85b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 47c0b38523bfd02c77066836d38c91f8b8fad750
https://github.com/Perl/perl5/commit/47c0b38523bfd02c77066836d38c91f8b8fad750
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 8a736d39c9ab0461e4d65ed5f3e90a190976d55d
https://github.com/Perl/perl5/commit/8a736d39c9ab0461e4d65ed5f3e90a190976d55d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 4c1dfa73145ffeceda5a7ddec9266495435ce0e1
https://github.com/Perl/perl5/commit/4c1dfa73145ffeceda5a7ddec9266495435ce0e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 54637a500055ac15593d57d0a2a10f60414d061d
https://github.com/Perl/perl5/commit/54637a500055ac15593d57d0a2a10f60414d061d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 81981f0aba3da5f2b4f96350f5c296a35b8fff4e
https://github.com/Perl/perl5/commit/81981f0aba3da5f2b4f96350f5c296a35b8fff4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 03d4e417eb92d5e3a1ca0fe97521e57b53f86f39
https://github.com/Perl/perl5/commit/03d4e417eb92d5e3a1ca0fe97521e57b53f86f39
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: d486c6ebe66859f162bd9785a0453d6932c890f5
https://github.com/Perl/perl5/commit/d486c6ebe66859f162bd9785a0453d6932c890f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: bea9c54acec92779aac5ec78426b898e59d56e1e
https://github.com/Perl/perl5/commit/bea9c54acec92779aac5ec78426b898e59d56e1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 03245b5f697bb1ad1a7491d068861002d9b4d504
https://github.com/Perl/perl5/commit/03245b5f697bb1ad1a7491d068861002d9b4d504
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: e9cfcf2450767b94ce25b4ee11737104e0025fe9
https://github.com/Perl/perl5/commit/e9cfcf2450767b94ce25b4ee11737104e0025fe9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 28d3022ce73e3bff1f7726f4a6d9373410f1429e
https://github.com/Perl/perl5/commit/28d3022ce73e3bff1f7726f4a6d9373410f1429e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: f93c96449b22cd014ed3f5bbb7faf0717ae5a3ec
https://github.com/Perl/perl5/commit/f93c96449b22cd014ed3f5bbb7faf0717ae5a3ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 13ef59bdb78e41b13ada60da54fbbd92011671bb
https://github.com/Perl/perl5/commit/13ef59bdb78e41b13ada60da54fbbd92011671bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: b4aed1bccde29274c3bdce25a098a82265533ea9
https://github.com/Perl/perl5/commit/b4aed1bccde29274c3bdce25a098a82265533ea9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 6a047077cb859ac7b862b12d09f5f31e35582b89
https://github.com/Perl/perl5/commit/6a047077cb859ac7b862b12d09f5f31e35582b89
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 78c32139146e918e4b934190c772a9895f5883d6
https://github.com/Perl/perl5/commit/78c32139146e918e4b934190c772a9895f5883d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 1bacb334a7b0dccbefd425d8ef54b8d604ae39fb
https://github.com/Perl/perl5/commit/1bacb334a7b0dccbefd425d8ef54b8d604ae39fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: a89dd79501c7a75bfe5fe1466b8742d13baf7c9b
https://github.com/Perl/perl5/commit/a89dd79501c7a75bfe5fe1466b8742d13baf7c9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 1d86dce28726bb9d229cabc7eb92bb85527a0a48
https://github.com/Perl/perl5/commit/1d86dce28726bb9d229cabc7eb92bb85527a0a48
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: a947019da5689c8567dcace9abf296a1370a1e69
https://github.com/Perl/perl5/commit/a947019da5689c8567dcace9abf296a1370a1e69
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: d3a22ac104e8f4eb1a4f399112998020fae47b4c
https://github.com/Perl/perl5/commit/d3a22ac104e8f4eb1a4f399112998020fae47b4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: c8c616ef523cb109c3e8d9fb7035cc5316f0dd79
https://github.com/Perl/perl5/commit/c8c616ef523cb109c3e8d9fb7035cc5316f0dd79
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 50b1d6249cabf57be21cc3b0a83fb90d614a221a
https://github.com/Perl/perl5/commit/50b1d6249cabf57be21cc3b0a83fb90d614a221a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: f38d8de604a16d1a2f0592334222a671cb038b84
https://github.com/Perl/perl5/commit/f38d8de604a16d1a2f0592334222a671cb038b84
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: a6c0bf41ff2cd31a227233a3cfbb2e8106fddec4
https://github.com/Perl/perl5/commit/a6c0bf41ff2cd31a227233a3cfbb2e8106fddec4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 02e91a3a903acbebd966b7b2d3a3899797f8b845
https://github.com/Perl/perl5/commit/02e91a3a903acbebd966b7b2d3a3899797f8b845
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 815b94f2af95cc0aec73222739285730efa46adb
https://github.com/Perl/perl5/commit/815b94f2af95cc0aec73222739285730efa46adb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 53b8e2e956aff966dff8af1b7c0e73ddd10652a1
https://github.com/Perl/perl5/commit/53b8e2e956aff966dff8af1b7c0e73ddd10652a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 620996197706ca51ac869ed32b0a107111650cc8
https://github.com/Perl/perl5/commit/620996197706ca51ac869ed32b0a107111650cc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 805b4300ea5889d2075f097c50024d400c960650
https://github.com/Perl/perl5/commit/805b4300ea5889d2075f097c50024d400c960650
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 361738962f3f948d374134bec7d47ed5f399425a
https://github.com/Perl/perl5/commit/361738962f3f948d374134bec7d47ed5f399425a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 68e46e68d53c37d29fbea4f3a900f3fe30961460
https://github.com/Perl/perl5/commit/68e46e68d53c37d29fbea4f3a900f3fe30961460
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: cae5bff70af8a68fba559a8ba863b52765905161
https://github.com/Perl/perl5/commit/cae5bff70af8a68fba559a8ba863b52765905161
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 19a223be3704141e27d7c96ad6ce75528122cd55
https://github.com/Perl/perl5/commit/19a223be3704141e27d7c96ad6ce75528122cd55
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: af3bdc771d2a8a35d6a74f50fcb384886b64465f
https://github.com/Perl/perl5/commit/af3bdc771d2a8a35d6a74f50fcb384886b64465f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: c1dd342610820755850a94f4b79d6fef616a6838
https://github.com/Perl/perl5/commit/c1dd342610820755850a94f4b79d6fef616a6838
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 692dbe9ae1a310ad58f8bb612334a48ec5fb56ac
https://github.com/Perl/perl5/commit/692dbe9ae1a310ad58f8bb612334a48ec5fb56ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 0c9f0a1fb18cf896092b91c9f357b083275533c1
https://github.com/Perl/perl5/commit/0c9f0a1fb18cf896092b91c9f357b083275533c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 5f5582ec324571a29b4458ba55af9adff123391d
https://github.com/Perl/perl5/commit/5f5582ec324571a29b4458ba55af9adff123391d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 4284f57d20b1aab151e3d173bfbdb31a76619d7f
https://github.com/Perl/perl5/commit/4284f57d20b1aab151e3d173bfbdb31a76619d7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: cd9268d0316cf89c52e2c5035a0411d6dd68a00b
https://github.com/Perl/perl5/commit/cd9268d0316cf89c52e2c5035a0411d6dd68a00b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 248d93d89cbb8e96c76becdbc94a58e8c2388d04
https://github.com/Perl/perl5/commit/248d93d89cbb8e96c76becdbc94a58e8c2388d04
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 1f9eb9249ac68c6429282ed3615d109b81f78af4
https://github.com/Perl/perl5/commit/1f9eb9249ac68c6429282ed3615d109b81f78af4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: dd50acaf23092352cd5e006517ecf9c7a3b5702b
https://github.com/Perl/perl5/commit/dd50acaf23092352cd5e006517ecf9c7a3b5702b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 45b856a9e8c8541db52a41b51ea32cf48cdf66c5
https://github.com/Perl/perl5/commit/45b856a9e8c8541db52a41b51ea32cf48cdf66c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 8cb093062b881a0eb3bbcb818990f4ad97f7e5f1
https://github.com/Perl/perl5/commit/8cb093062b881a0eb3bbcb818990f4ad97f7e5f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 8f15de741969527f95bc668482e7b99e22b3828a
https://github.com/Perl/perl5/commit/8f15de741969527f95bc668482e7b99e22b3828a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 52c875d0bc43a08241f75e7402e454e56f77d68b
https://github.com/Perl/perl5/commit/52c875d0bc43a08241f75e7402e454e56f77d68b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 757ad4790f84eb66dad441eb1873b68336e66143
https://github.com/Perl/perl5/commit/757ad4790f84eb66dad441eb1873b68336e66143
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: e1d5f8d6cf55dfa846b1294df07d785b36123fcd
https://github.com/Perl/perl5/commit/e1d5f8d6cf55dfa846b1294df07d785b36123fcd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 493b3ca08226aa441ff62336de0867b438fd34cc
https://github.com/Perl/perl5/commit/493b3ca08226aa441ff62336de0867b438fd34cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 733e7e3ed5492a72e6b8fc0eced73b8ba9256a3c
https://github.com/Perl/perl5/commit/733e7e3ed5492a72e6b8fc0eced73b8ba9256a3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 222f7c6d73ccfe3c74df7c004fe7cc19995c7311
https://github.com/Perl/perl5/commit/222f7c6d73ccfe3c74df7c004fe7cc19995c7311
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 92cf69055f1b09e7619fd926a2fdbd2b05aabd82
https://github.com/Perl/perl5/commit/92cf69055f1b09e7619fd926a2fdbd2b05aabd82
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 415ef15f8324e6d00c094d27c882607187aadbd2
https://github.com/Perl/perl5/commit/415ef15f8324e6d00c094d27c882607187aadbd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 53fbdd7e6fdf38d6d64ad020cef51a0055181dd6
https://github.com/Perl/perl5/commit/53fbdd7e6fdf38d6d64ad020cef51a0055181dd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 626fbabd8748c4e4e16400ab6b477bc8e2709d80
https://github.com/Perl/perl5/commit/626fbabd8748c4e4e16400ab6b477bc8e2709d80
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 0e32d90ab7c0d0ec0ab164e15b7fb3451a047b96
https://github.com/Perl/perl5/commit/0e32d90ab7c0d0ec0ab164e15b7fb3451a047b96
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: db90257c934fcd586a1a136bc2002039ccb82d23
https://github.com/Perl/perl5/commit/db90257c934fcd586a1a136bc2002039ccb82d23
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 815613efd0d611e548bcb105d7288c896e9d3637
https://github.com/Perl/perl5/commit/815613efd0d611e548bcb105d7288c896e9d3637
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 394a72e381aa04408c0ee77de39a47d114145ade
https://github.com/Perl/perl5/commit/394a72e381aa04408c0ee77de39a47d114145ade
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 8002647db6236b31e28bcf4ba4e6e40a797e0b25
https://github.com/Perl/perl5/commit/8002647db6236b31e28bcf4ba4e6e40a797e0b25
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: b968445a65ebeea2ea3bb9f09cf6b934abb93889
https://github.com/Perl/perl5/commit/b968445a65ebeea2ea3bb9f09cf6b934abb93889
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: a1bcd5b7fc241583e799f4bf664acb7aea33c725
https://github.com/Perl/perl5/commit/a1bcd5b7fc241583e799f4bf664acb7aea33c725
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 76e9311feb058b12aba2fe9094417ee8b941f1c9
https://github.com/Perl/perl5/commit/76e9311feb058b12aba2fe9094417ee8b941f1c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: c2ee461f9975b7cc580742fa0c2c161f59ade7fb
https://github.com/Perl/perl5/commit/c2ee461f9975b7cc580742fa0c2c161f59ade7fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 0ad107ff2e4b7e9db11658538920449b47a7e08d
https://github.com/Perl/perl5/commit/0ad107ff2e4b7e9db11658538920449b47a7e08d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 2d1f570e3b9b7465c34a824e57ad553adc9f3594
https://github.com/Perl/perl5/commit/2d1f570e3b9b7465c34a824e57ad553adc9f3594
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 98e89f4cad9f4db2666adb7ddb7a698d5dfd713c
https://github.com/Perl/perl5/commit/98e89f4cad9f4db2666adb7ddb7a698d5dfd713c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: e4822a08de3ef8d62a6076aa0b161078534df1fd
https://github.com/Perl/perl5/commit/e4822a08de3ef8d62a6076aa0b161078534df1fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 412c967dd26b2b490286a827d3b1aa63eb012186
https://github.com/Perl/perl5/commit/412c967dd26b2b490286a827d3b1aa63eb012186
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: ad6c6ba9f94e5223c37f17504387d655e8cef732
https://github.com/Perl/perl5/commit/ad6c6ba9f94e5223c37f17504387d655e8cef732
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: d6d2bd76e2e8f6ec3b410463f56e6e166dafae16
https://github.com/Perl/perl5/commit/d6d2bd76e2e8f6ec3b410463f56e6e166dafae16
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 8145889227f180c4de517440d360e9ef6941db42
https://github.com/Perl/perl5/commit/8145889227f180c4de517440d360e9ef6941db42
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: a3f185e4315ebf23fad9927fe6614193cfe901d3
https://github.com/Perl/perl5/commit/a3f185e4315ebf23fad9927fe6614193cfe901d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 0a8abbfc24a2de7658f607be05b2ca16bb219be1
https://github.com/Perl/perl5/commit/0a8abbfc24a2de7658f607be05b2ca16bb219be1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 0e8dde003c342904ae0a74657265327ad4077f60
https://github.com/Perl/perl5/commit/0e8dde003c342904ae0a74657265327ad4077f60
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 1f3b4f8bdc7c1a6ac7c2273ff37c7f6f8b1cf24a
https://github.com/Perl/perl5/commit/1f3b4f8bdc7c1a6ac7c2273ff37c7f6f8b1cf24a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: b92a6800df2411edec5036ada8e7c17231e4c8ed
https://github.com/Perl/perl5/commit/b92a6800df2411edec5036ada8e7c17231e4c8ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: a177f509b3642e329ae8e6ae3d615f074b8f4c31
https://github.com/Perl/perl5/commit/a177f509b3642e329ae8e6ae3d615f074b8f4c31
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 0abf2cb99b60fae7544e54e9236f409e622222ef
https://github.com/Perl/perl5/commit/0abf2cb99b60fae7544e54e9236f409e622222ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: f7809d9f84fc6fce36fa57635cd0a1441d0b0f3a
https://github.com/Perl/perl5/commit/f7809d9f84fc6fce36fa57635cd0a1441d0b0f3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: e0a675a685231d6c723a3d8689826d615b576096
https://github.com/Perl/perl5/commit/e0a675a685231d6c723a3d8689826d615b576096
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 1e994561ef077f856dd597095e22c5d075059695
https://github.com/Perl/perl5/commit/1e994561ef077f856dd597095e22c5d075059695
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 9acaf58f941d5475bc4beb7585f52cf87d1a4e88
https://github.com/Perl/perl5/commit/9acaf58f941d5475bc4beb7585f52cf87d1a4e88
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: df65592582f19f66926f18f1327d7d60fd564f35
https://github.com/Perl/perl5/commit/df65592582f19f66926f18f1327d7d60fd564f35
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: b995111523fb2f0e34b0e3a37bb891acd5a10a60
https://github.com/Perl/perl5/commit/b995111523fb2f0e34b0e3a37bb891acd5a10a60
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 1f0b3857077b15b38c52953257a20700e5db3801
https://github.com/Perl/perl5/commit/1f0b3857077b15b38c52953257a20700e5db3801
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: b9c549234ccf5d4e5b2e6d82d25e9c137d295415
https://github.com/Perl/perl5/commit/b9c549234ccf5d4e5b2e6d82d25e9c137d295415
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: c8294320a0363533766d538d3feb3a4c62bfd972
https://github.com/Perl/perl5/commit/c8294320a0363533766d538d3feb3a4c62bfd972
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: c7e99cb4a72da3df5e7522947640aba9b27f6991
https://github.com/Perl/perl5/commit/c7e99cb4a72da3df5e7522947640aba9b27f6991
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 0b06de838556d48e6f17ae41ddb739d313adf84d
https://github.com/Perl/perl5/commit/0b06de838556d48e6f17ae41ddb739d313adf84d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: ebb674c74eb6f5fc485afc705883c5ff6a30f798
https://github.com/Perl/perl5/commit/ebb674c74eb6f5fc485afc705883c5ff6a30f798
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: f5d7aac487076f55ea1a22e764f6a593f7ad9a83
https://github.com/Perl/perl5/commit/f5d7aac487076f55ea1a22e764f6a593f7ad9a83
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 9113d555c71ef582cad826aa78d65b04beafe321
https://github.com/Perl/perl5/commit/9113d555c71ef582cad826aa78d65b04beafe321
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 0c61455f9becc7ed1d45184fa02b6b628f4c95c1
https://github.com/Perl/perl5/commit/0c61455f9becc7ed1d45184fa02b6b628f4c95c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 70247b3596b842d70b3e55020746176fc2b177fb
https://github.com/Perl/perl5/commit/70247b3596b842d70b3e55020746176fc2b177fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 92789c146b3517ff99c16bc28efab416edad47c1
https://github.com/Perl/perl5/commit/92789c146b3517ff99c16bc28efab416edad47c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: ccb55cdd2a7f12fc811c904a3b4b95925ce00e73
https://github.com/Perl/perl5/commit/ccb55cdd2a7f12fc811c904a3b4b95925ce00e73
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 8bede3ae344f6560e103f61aaf2c6d76b929fe25
https://github.com/Perl/perl5/commit/8bede3ae344f6560e103f61aaf2c6d76b929fe25
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 60eb82073ff48e0048f9615215db457a2ed50969
https://github.com/Perl/perl5/commit/60eb82073ff48e0048f9615215db457a2ed50969
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 291b8b331ea4f230581727c78e189de7ad38249d
https://github.com/Perl/perl5/commit/291b8b331ea4f230581727c78e189de7ad38249d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 49b2d8dea017ac6072108e281c2df368c9970908
https://github.com/Perl/perl5/commit/49b2d8dea017ac6072108e281c2df368c9970908
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: eface1379af451c2913b2094bf1a6de2cbee91f9
https://github.com/Perl/perl5/commit/eface1379af451c2913b2094bf1a6de2cbee91f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 1a2df52002275974616e2368f1ec452023a672ff
https://github.com/Perl/perl5/commit/1a2df52002275974616e2368f1ec452023a672ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: e0c2eebf2a64ebcdf76d18bcbd3cf362f34dcb30
https://github.com/Perl/perl5/commit/e0c2eebf2a64ebcdf76d18bcbd3cf362f34dcb30
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: f73a450f1189fc523c693be31a28016cf1d663e6
https://github.com/Perl/perl5/commit/f73a450f1189fc523c693be31a28016cf1d663e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 231141ee5b397aa9287fd948efcc9b038781c258
https://github.com/Perl/perl5/commit/231141ee5b397aa9287fd948efcc9b038781c258
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 879aa28cbab1ecf9a2ad12e2b89babd06af0e594
https://github.com/Perl/perl5/commit/879aa28cbab1ecf9a2ad12e2b89babd06af0e594
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: b97e847cf6c5b5d92635afa66974809110dd4374
https://github.com/Perl/perl5/commit/b97e847cf6c5b5d92635afa66974809110dd4374
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 7171291c742769c03a1e7664b62a11a943552e31
https://github.com/Perl/perl5/commit/7171291c742769c03a1e7664b62a11a943552e31
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 84df3171a378b755a87040b077981d66c604c665
https://github.com/Perl/perl5/commit/84df3171a378b755a87040b077981d66c604c665
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 6d4ea5aa3d7978e0f5415c12a4a52f125ccc8874
https://github.com/Perl/perl5/commit/6d4ea5aa3d7978e0f5415c12a4a52f125ccc8874
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 9deff1cbe0c77ac9c1366404fd909060467e60a5
https://github.com/Perl/perl5/commit/9deff1cbe0c77ac9c1366404fd909060467e60a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 500bf0fdc0487cbb4fb8cbfd910bf3f3d36755e5
https://github.com/Perl/perl5/commit/500bf0fdc0487cbb4fb8cbfd910bf3f3d36755e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: cf4d04a5eb11c637293d405817f594f09cc2c5cf
https://github.com/Perl/perl5/commit/cf4d04a5eb11c637293d405817f594f09cc2c5cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 5d14a8a422751cd39506a45ce1dfc86f828450f3
https://github.com/Perl/perl5/commit/5d14a8a422751cd39506a45ce1dfc86f828450f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 5335d7d28e67c1876ab0490cbac633500460cfae
https://github.com/Perl/perl5/commit/5335d7d28e67c1876ab0490cbac633500460cfae
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 5348d1f4ab200c9a343d6c7037b27f1ca49c4101
https://github.com/Perl/perl5/commit/5348d1f4ab200c9a343d6c7037b27f1ca49c4101
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: b79ecb9c9e799950659c97f2e5f366f0577b441f
https://github.com/Perl/perl5/commit/b79ecb9c9e799950659c97f2e5f366f0577b441f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: ec7b9b53882ed5bfcb32618730a58160310f06dc
https://github.com/Perl/perl5/commit/ec7b9b53882ed5bfcb32618730a58160310f06dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 757e103292199c1f861f1270a31dcaf13a265c59
https://github.com/Perl/perl5/commit/757e103292199c1f861f1270a31dcaf13a265c59
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: d9ba595fc317849baa0721be44a29039a2272352
https://github.com/Perl/perl5/commit/d9ba595fc317849baa0721be44a29039a2272352
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 5f821092fe2e784e379c50f1886dae77d92d2796
https://github.com/Perl/perl5/commit/5f821092fe2e784e379c50f1886dae77d92d2796
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 4d8b903a216103ec6327c0c5da92059f213c8b75
https://github.com/Perl/perl5/commit/4d8b903a216103ec6327c0c5da92059f213c8b75
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 7f83c0a5cba8dbc5a8400e8c75d803515ae60fc2
https://github.com/Perl/perl5/commit/7f83c0a5cba8dbc5a8400e8c75d803515ae60fc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 9b55b5df228de10635ef0452bf14ae262d580849
https://github.com/Perl/perl5/commit/9b55b5df228de10635ef0452bf14ae262d580849
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a5ebd16e443a03ded4b7f65814bc82e1e98397b5
https://github.com/Perl/perl5/commit/a5ebd16e443a03ded4b7f65814bc82e1e98397b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: d2e6d96ef2aad16fa79d167d3ef82f9375dc1c35
https://github.com/Perl/perl5/commit/d2e6d96ef2aad16fa79d167d3ef82f9375dc1c35
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 125b0f1d784b65a7a83239a6ade879b5e0b1bfb6
https://github.com/Perl/perl5/commit/125b0f1d784b65a7a83239a6ade879b5e0b1bfb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 6f90fd659e3e5428d34abe66f6cd943c9c5849ff
https://github.com/Perl/perl5/commit/6f90fd659e3e5428d34abe66f6cd943c9c5849ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 89536d5ee92256a20ad8b13654a8ec5bce04b424
https://github.com/Perl/perl5/commit/89536d5ee92256a20ad8b13654a8ec5bce04b424
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 33742e43c23a46b2344d22ce6fc45a3e88bf6c7b
https://github.com/Perl/perl5/commit/33742e43c23a46b2344d22ce6fc45a3e88bf6c7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: d2e6129634b1f32003cbecdc6e2f1aad1573707d
https://github.com/Perl/perl5/commit/d2e6129634b1f32003cbecdc6e2f1aad1573707d
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 4a568c5231a213b615b1a132afd2bb97cd04cffb
https://github.com/Perl/perl5/commit/4a568c5231a213b615b1a132afd2bb97cd04cffb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: ac8dac1476db8b73f404fe58cd717eda54b04f86
https://github.com/Perl/perl5/commit/ac8dac1476db8b73f404fe58cd717eda54b04f86
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: d9efca787d85241c291a6c34a0b5d2a109eea6f6
https://github.com/Perl/perl5/commit/d9efca787d85241c291a6c34a0b5d2a109eea6f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: cc82c85b696c158b623213b09af9b45e4c3c2827
https://github.com/Perl/perl5/commit/cc82c85b696c158b623213b09af9b45e4c3c2827
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: bb25fc275f290035d9ff5394c65a2b8bf9e0b8d9
https://github.com/Perl/perl5/commit/bb25fc275f290035d9ff5394c65a2b8bf9e0b8d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 0700f19e7c3f65ec1168ad4bdb658e1cadcfa0f7
https://github.com/Perl/perl5/commit/0700f19e7c3f65ec1168ad4bdb658e1cadcfa0f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 8929cb083ae8ce5b4b888ad965ba19062bb9de15
https://github.com/Perl/perl5/commit/8929cb083ae8ce5b4b888ad965ba19062bb9de15
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: aa60745fd4fe2d6b4b5877c4a0f5606b8a7c5c52
https://github.com/Perl/perl5/commit/aa60745fd4fe2d6b4b5877c4a0f5606b8a7c5c52
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 41cdf76e110231d45712007e911c4bb08976df06
https://github.com/Perl/perl5/commit/41cdf76e110231d45712007e911c4bb08976df06
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: f83e5a49910531a2614487f40d7bb8b4a306f0ea
https://github.com/Perl/perl5/commit/f83e5a49910531a2614487f40d7bb8b4a306f0ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 80b73d06976a29edcbf7c0e1195b050bd34ae312
https://github.com/Perl/perl5/commit/80b73d06976a29edcbf7c0e1195b050bd34ae312
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 6cf4dda6f87abef0d11798d9aaad0c295135e74f
https://github.com/Perl/perl5/commit/6cf4dda6f87abef0d11798d9aaad0c295135e74f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 85742717c2098e30d9fcb716b89f0389046ed6c3
https://github.com/Perl/perl5/commit/85742717c2098e30d9fcb716b89f0389046ed6c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 977990f7960d34224ae407b582325059dca21d8e
https://github.com/Perl/perl5/commit/977990f7960d34224ae407b582325059dca21d8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: d198f605c92b62aa4ca17215e211e6d9a6bd3177
https://github.com/Perl/perl5/commit/d198f605c92b62aa4ca17215e211e6d9a6bd3177
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: e6c5b31b8df565a75a16d9cfc70161250697f3c1
https://github.com/Perl/perl5/commit/e6c5b31b8df565a75a16d9cfc70161250697f3c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 9f2db1fd02bf6ee4b095978e3dd6e366b1982976
https://github.com/Perl/perl5/commit/9f2db1fd02bf6ee4b095978e3dd6e366b1982976
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: dd2fb1dad2ac7ea5f9c7465ac7b786dca0c51cf9
https://github.com/Perl/perl5/commit/dd2fb1dad2ac7ea5f9c7465ac7b786dca0c51cf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 13d29bfbf356e77402938c11737ce2cc6db7bc04
https://github.com/Perl/perl5/commit/13d29bfbf356e77402938c11737ce2cc6db7bc04
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 8e9e31aa7294ea0605e07daeab1c11650fcf8260
https://github.com/Perl/perl5/commit/8e9e31aa7294ea0605e07daeab1c11650fcf8260
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: a636ca6154cc078ebbc40a5b3336d492536f9870
https://github.com/Perl/perl5/commit/a636ca6154cc078ebbc40a5b3336d492536f9870
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 89fee08d5e0ef0dd66b33275f50e56ca230e0f61
https://github.com/Perl/perl5/commit/89fee08d5e0ef0dd66b33275f50e56ca230e0f61
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: e2dedc7d58fbb1d04b7c47014ab164dcac0679ec
https://github.com/Perl/perl5/commit/e2dedc7d58fbb1d04b7c47014ab164dcac0679ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: ff4521f0a7e23296831e3ede698bb43ec01f62d7
https://github.com/Perl/perl5/commit/ff4521f0a7e23296831e3ede698bb43ec01f62d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 5779b99b8e264606ab7610e007a9de7c7c54bc08
https://github.com/Perl/perl5/commit/5779b99b8e264606ab7610e007a9de7c7c54bc08
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 77a12061a3b71db7ec43d59ae05229f5ba73802b
https://github.com/Perl/perl5/commit/77a12061a3b71db7ec43d59ae05229f5ba73802b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 132a2a7e39c497d7af8d43f2478f0672baec3f44
https://github.com/Perl/perl5/commit/132a2a7e39c497d7af8d43f2478f0672baec3f44
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 219dc8f63c3340381c8c13be10c947df8b89cdb7
https://github.com/Perl/perl5/commit/219dc8f63c3340381c8c13be10c947df8b89cdb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cadf7af29a4ff1453bf8331254719665c0d36881
https://github.com/Perl/perl5/commit/cadf7af29a4ff1453bf8331254719665c0d36881
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: e70aaf0d582ccc0a668bcc98a61918a0005c1b5e
https://github.com/Perl/perl5/commit/e70aaf0d582ccc0a668bcc98a61918a0005c1b5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: e1ea9c8f94fae318bafe3687b59129651d71870b
https://github.com/Perl/perl5/commit/e1ea9c8f94fae318bafe3687b59129651d71870b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 15930101cff67e18614685b91c41a80ed427d64e
https://github.com/Perl/perl5/commit/15930101cff67e18614685b91c41a80ed427d64e
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 12b4cc47c86e95571ed80330e37226f20efe1279
https://github.com/Perl/perl5/commit/12b4cc47c86e95571ed80330e37226f20efe1279
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 6ceccd1da8e0db50f2047c9139cd98d55cdb88bb
https://github.com/Perl/perl5/commit/6ceccd1da8e0db50f2047c9139cd98d55cdb88bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 8d5046b3a7853163507d5192daa11d4cfac9c27c
https://github.com/Perl/perl5/commit/8d5046b3a7853163507d5192daa11d4cfac9c27c
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: e4eb0c7a6aa183991376396127b311c5cdbff544
https://github.com/Perl/perl5/commit/e4eb0c7a6aa183991376396127b311c5cdbff544
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: ab78b229a663bae9dbbdbcfdac7be344cf09d0e0
https://github.com/Perl/perl5/commit/ab78b229a663bae9dbbdbcfdac7be344cf09d0e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: d08df212353daaff33ba562480a2216d671a04a8
https://github.com/Perl/perl5/commit/d08df212353daaff33ba562480a2216d671a04a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 8107903bd3adc2b480770c61d635f8799cc2e770
https://github.com/Perl/perl5/commit/8107903bd3adc2b480770c61d635f8799cc2e770
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: afd8eb4e0fa10b1737c8325971166f41c2107d98
https://github.com/Perl/perl5/commit/afd8eb4e0fa10b1737c8325971166f41c2107d98
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b99e0f85204fb42847e3fa32f82b4e87dc87cc60
https://github.com/Perl/perl5/commit/b99e0f85204fb42847e3fa32f82b4e87dc87cc60
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 959e02ab19883b91c4077864a554a80ddc99c0bd
https://github.com/Perl/perl5/commit/959e02ab19883b91c4077864a554a80ddc99c0bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: ef68fda12d01bd3a06eb23ffc82ea3565a50d463
https://github.com/Perl/perl5/commit/ef68fda12d01bd3a06eb23ffc82ea3565a50d463
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: b12084a3ed4eaec62ce5557258720b81ae5086e1
https://github.com/Perl/perl5/commit/b12084a3ed4eaec62ce5557258720b81ae5086e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 32ae49930315113c1fc4bbe81c8d4bbbf000ef23
https://github.com/Perl/perl5/commit/32ae49930315113c1fc4bbe81c8d4bbbf000ef23
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 3758c8600d8bfb9e29b5fa304169c39f347b4c93
https://github.com/Perl/perl5/commit/3758c8600d8bfb9e29b5fa304169c39f347b4c93
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: a8a81bc5db11f2e92435eb50c1bebdc48dfe8da2
https://github.com/Perl/perl5/commit/a8a81bc5db11f2e92435eb50c1bebdc48dfe8da2
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: f2802effa28dd73828a330866fbde41767ac36b3
https://github.com/Perl/perl5/commit/f2802effa28dd73828a330866fbde41767ac36b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 9a326293d9641a1648b519fb15f2c85c795395f4
https://github.com/Perl/perl5/commit/9a326293d9641a1648b519fb15f2c85c795395f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: b87762f424ddd5d2dcd25a34fe2e4df6ad8d70eb
https://github.com/Perl/perl5/commit/b87762f424ddd5d2dcd25a34fe2e4df6ad8d70eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 93c61d642259c90872ed66f411c7dc15ca901330
https://github.com/Perl/perl5/commit/93c61d642259c90872ed66f411c7dc15ca901330
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 2cdfe2e30ade6302f4bfa3abd4438265ac3a8b4f
https://github.com/Perl/perl5/commit/2cdfe2e30ade6302f4bfa3abd4438265ac3a8b4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 7dfd4ebc1369dc249e80b133309cd2004982393b
https://github.com/Perl/perl5/commit/7dfd4ebc1369dc249e80b133309cd2004982393b
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 26b5b44add1700bc8b56d8a7568ebea500ecb2e4
https://github.com/Perl/perl5/commit/26b5b44add1700bc8b56d8a7568ebea500ecb2e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 03863d99cdf688caaf67854dca13bd1ccea14f65
https://github.com/Perl/perl5/commit/03863d99cdf688caaf67854dca13bd1ccea14f65
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 3f5568aca5b56d97a524e11c41adc7d8e7c8bfdc
https://github.com/Perl/perl5/commit/3f5568aca5b56d97a524e11c41adc7d8e7c8bfdc
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 6189ad7451ec25170b591984779dda4da693a2b1
https://github.com/Perl/perl5/commit/6189ad7451ec25170b591984779dda4da693a2b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 13824f5c484d2c9105c384f262a038b8631466b1
https://github.com/Perl/perl5/commit/13824f5c484d2c9105c384f262a038b8631466b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 0b7f6687411b224f6b6a7fec671643280ed78b1a
https://github.com/Perl/perl5/commit/0b7f6687411b224f6b6a7fec671643280ed78b1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: d076381e1bb46d09ff1a2a7f73f44aae88548f36
https://github.com/Perl/perl5/commit/d076381e1bb46d09ff1a2a7f73f44aae88548f36
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 2803007aee2c23336dd5c4e81a239a189b9fc6d9
https://github.com/Perl/perl5/commit/2803007aee2c23336dd5c4e81a239a189b9fc6d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: aca0da8fb724a42c6dde3dc572df88d9287a0560
https://github.com/Perl/perl5/commit/aca0da8fb724a42c6dde3dc572df88d9287a0560
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 010faf5ea03292ac9bb70dcbc55bb12ba66c5c2a
https://github.com/Perl/perl5/commit/010faf5ea03292ac9bb70dcbc55bb12ba66c5c2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-04 (Sun, 04 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M patchlevel.h
M perl.h
M proto.h
M sv.c
M t/loc_tools.pl
Log Message:
-----------
more11
Compare: https://github.com/Perl/perl5/compare/e984acc5338d...010faf5ea032
