Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 66731b7ccb45b1401a71976fa02e9610942bad02
https://github.com/Perl/perl5/commit/66731b7ccb45b1401a71976fa02e9610942bad02
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 961705dd46f38ab09b8018d0d60b9127120cc092
https://github.com/Perl/perl5/commit/961705dd46f38ab09b8018d0d60b9127120cc092
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 09e801191f91b5d9551abf01767650f6602b1873
https://github.com/Perl/perl5/commit/09e801191f91b5d9551abf01767650f6602b1873
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 8179b8886b1e8a2fbe9796bfdae2b63970c45bef
https://github.com/Perl/perl5/commit/8179b8886b1e8a2fbe9796bfdae2b63970c45bef
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: da6112ee66f657c9c911a4409e0fa1d2e1647b5d
https://github.com/Perl/perl5/commit/da6112ee66f657c9c911a4409e0fa1d2e1647b5d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 35195384cf4bd41647f580d61cee67fefc483ee9
https://github.com/Perl/perl5/commit/35195384cf4bd41647f580d61cee67fefc483ee9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: dee7816b94fc2737b8b9b5cd03ace90979e1e1cf
https://github.com/Perl/perl5/commit/dee7816b94fc2737b8b9b5cd03ace90979e1e1cf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 66503a4c3becc3b67a3d3e767f8907602fe53346
https://github.com/Perl/perl5/commit/66503a4c3becc3b67a3d3e767f8907602fe53346
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: c38420cf7df2d38097eea0618a1eb3a384cff426
https://github.com/Perl/perl5/commit/c38420cf7df2d38097eea0618a1eb3a384cff426
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 0ad095a6c7e52f3a55cbf4769b3ac722c2a32994
https://github.com/Perl/perl5/commit/0ad095a6c7e52f3a55cbf4769b3ac722c2a32994
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: f5ce6b9a5e0c89689abf941157009c4e540048e9
https://github.com/Perl/perl5/commit/f5ce6b9a5e0c89689abf941157009c4e540048e9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 1c0a8c30868541dcfcdb3334c5070eb9d8f56033
https://github.com/Perl/perl5/commit/1c0a8c30868541dcfcdb3334c5070eb9d8f56033
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: b0eba1643dac71c052b46016904e8a8a9850cff9
https://github.com/Perl/perl5/commit/b0eba1643dac71c052b46016904e8a8a9850cff9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 4d5f5ca6a30a1b3de504195c838d87af527a5f87
https://github.com/Perl/perl5/commit/4d5f5ca6a30a1b3de504195c838d87af527a5f87
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 5f2c6ace5ff136142b84e602e903cf720ce59996
https://github.com/Perl/perl5/commit/5f2c6ace5ff136142b84e602e903cf720ce59996
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 8d25c2357e48dbe313f502e6560c897cfdf0fd9e
https://github.com/Perl/perl5/commit/8d25c2357e48dbe313f502e6560c897cfdf0fd9e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: afaa267030d882cac871bb132a1e159b8251e5d2
https://github.com/Perl/perl5/commit/afaa267030d882cac871bb132a1e159b8251e5d2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5d73adb646a90a4f08066cc0075f01144be84b50
https://github.com/Perl/perl5/commit/5d73adb646a90a4f08066cc0075f01144be84b50
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: c42ae79067acce9564a1baeb80a3761dd6edb5a9
https://github.com/Perl/perl5/commit/c42ae79067acce9564a1baeb80a3761dd6edb5a9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: b64d2c5989276160f64bb29840cbe0ea1052b73b
https://github.com/Perl/perl5/commit/b64d2c5989276160f64bb29840cbe0ea1052b73b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: bad7ab5b3a23cafcfd706ca3a84e73bc0d14cb90
https://github.com/Perl/perl5/commit/bad7ab5b3a23cafcfd706ca3a84e73bc0d14cb90
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: bbf129ac5be813d3e6eec3805689a5c42a5a3eb7
https://github.com/Perl/perl5/commit/bbf129ac5be813d3e6eec3805689a5c42a5a3eb7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 622581e2c18b0ae34af7fe887d4daf89d176b921
https://github.com/Perl/perl5/commit/622581e2c18b0ae34af7fe887d4daf89d176b921
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: af10d199d26997d95e9ed71ac2e04ae0408d6278
https://github.com/Perl/perl5/commit/af10d199d26997d95e9ed71ac2e04ae0408d6278
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 78b8cb6971979194218122989c02ce9964ba0d99
https://github.com/Perl/perl5/commit/78b8cb6971979194218122989c02ce9964ba0d99
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: d6ba7e2ba7674788fa0c09879b30b914b9de1530
https://github.com/Perl/perl5/commit/d6ba7e2ba7674788fa0c09879b30b914b9de1530
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 987e052cb5c7564956f45d24c2cb2eca262e712f
https://github.com/Perl/perl5/commit/987e052cb5c7564956f45d24c2cb2eca262e712f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: fe514b98ac8734870f803a55e51468ec1e11f88c
https://github.com/Perl/perl5/commit/fe514b98ac8734870f803a55e51468ec1e11f88c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 598ce84b2400d7b040c1e16f7c3697a1210b9b24
https://github.com/Perl/perl5/commit/598ce84b2400d7b040c1e16f7c3697a1210b9b24
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: b8b84e5a796d2f3edee1ade9fb205eac13c41373
https://github.com/Perl/perl5/commit/b8b84e5a796d2f3edee1ade9fb205eac13c41373
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: e3b3ad647e339cdc8ae3612d7b7ab3e99c911121
https://github.com/Perl/perl5/commit/e3b3ad647e339cdc8ae3612d7b7ab3e99c911121
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: cd37662a376bfc5732f8236f78b206340e7d11e1
https://github.com/Perl/perl5/commit/cd37662a376bfc5732f8236f78b206340e7d11e1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 545945d3e437f8ebef6a39dcb87a9196e69eaede
https://github.com/Perl/perl5/commit/545945d3e437f8ebef6a39dcb87a9196e69eaede
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 48417fe5511ba5e830672c8dd9fcad4ebf14126e
https://github.com/Perl/perl5/commit/48417fe5511ba5e830672c8dd9fcad4ebf14126e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 468735560eca0c2c7ae6fe339448217654d67995
https://github.com/Perl/perl5/commit/468735560eca0c2c7ae6fe339448217654d67995
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: a23445067c15d1548445e5c1202dc62d53c6914a
https://github.com/Perl/perl5/commit/a23445067c15d1548445e5c1202dc62d53c6914a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: b3c7796b39da6281143ef13bd52242f07f93ae06
https://github.com/Perl/perl5/commit/b3c7796b39da6281143ef13bd52242f07f93ae06
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 918269e6b1d9a06ee7b0f3fb8323622d37c600c2
https://github.com/Perl/perl5/commit/918269e6b1d9a06ee7b0f3fb8323622d37c600c2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 03efc5c67c9d6d06107dad7bb072ac34a17716cb
https://github.com/Perl/perl5/commit/03efc5c67c9d6d06107dad7bb072ac34a17716cb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 19e9fbb4251cbe8c1d82e7954502c34a820d2a76
https://github.com/Perl/perl5/commit/19e9fbb4251cbe8c1d82e7954502c34a820d2a76
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 645a8872ff816a01f9d4aa3b7331efa5f25b9d4f
https://github.com/Perl/perl5/commit/645a8872ff816a01f9d4aa3b7331efa5f25b9d4f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: d4e3024a7c353346e7ab53c493f8974e816a1b01
https://github.com/Perl/perl5/commit/d4e3024a7c353346e7ab53c493f8974e816a1b01
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: f1a26ed215e1d831d5ec432d2c74f3fae6457694
https://github.com/Perl/perl5/commit/f1a26ed215e1d831d5ec432d2c74f3fae6457694
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 4a87b521655ccfe31ac1ec561a91e732c591e53b
https://github.com/Perl/perl5/commit/4a87b521655ccfe31ac1ec561a91e732c591e53b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 9fb9207de376862c927b48795b1fd0c0b2e0d756
https://github.com/Perl/perl5/commit/9fb9207de376862c927b48795b1fd0c0b2e0d756
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 93888df79b7b752f2dcf86ff743027461ed59c7d
https://github.com/Perl/perl5/commit/93888df79b7b752f2dcf86ff743027461ed59c7d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 383b5f4a11750361c318d9d98501f042cdca9467
https://github.com/Perl/perl5/commit/383b5f4a11750361c318d9d98501f042cdca9467
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: a4b2218e02cbdb5cbbe6128a7814129e3ab69202
https://github.com/Perl/perl5/commit/a4b2218e02cbdb5cbbe6128a7814129e3ab69202
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: dae31bb7090132361fe8dff3de02e3e81be78a87
https://github.com/Perl/perl5/commit/dae31bb7090132361fe8dff3de02e3e81be78a87
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 9b1f37f9596dd2696fa6ae4cacf30e41caac3e26
https://github.com/Perl/perl5/commit/9b1f37f9596dd2696fa6ae4cacf30e41caac3e26
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 31c162995b2f1d97b41f458672bc43d476fa4ba7
https://github.com/Perl/perl5/commit/31c162995b2f1d97b41f458672bc43d476fa4ba7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: a77c9ae66eae169e42b67dbefa5659bc037335ef
https://github.com/Perl/perl5/commit/a77c9ae66eae169e42b67dbefa5659bc037335ef
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 3781cab226c709b95b818e261aa4ac497f1b0e23
https://github.com/Perl/perl5/commit/3781cab226c709b95b818e261aa4ac497f1b0e23
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: c9602b989268ae5b78d1e4008cd9131f56201234
https://github.com/Perl/perl5/commit/c9602b989268ae5b78d1e4008cd9131f56201234
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: bb1e6b3019ef57a043db9fbd09fb6b2d445fc7f9
https://github.com/Perl/perl5/commit/bb1e6b3019ef57a043db9fbd09fb6b2d445fc7f9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 725a9f8ffdb667196195cac999dbc2ec6b30cc18
https://github.com/Perl/perl5/commit/725a9f8ffdb667196195cac999dbc2ec6b30cc18
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 336a7f7c8d0a0f878209d4a78f271f7512369ab2
https://github.com/Perl/perl5/commit/336a7f7c8d0a0f878209d4a78f271f7512369ab2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 7efdafc3bd7d70c4e473f913f16df7be7e62768f
https://github.com/Perl/perl5/commit/7efdafc3bd7d70c4e473f913f16df7be7e62768f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: a543d52cd0eae70deb2b528e3889cb699b70868a
https://github.com/Perl/perl5/commit/a543d52cd0eae70deb2b528e3889cb699b70868a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: f1e682f4e9cbae261adab5498601ee43dc4a003a
https://github.com/Perl/perl5/commit/f1e682f4e9cbae261adab5498601ee43dc4a003a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: c72418760b970df26cb5385688c56b9d98bda523
https://github.com/Perl/perl5/commit/c72418760b970df26cb5385688c56b9d98bda523
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 4c4dfb4860fb41f528d6a1d94a77862e29d97874
https://github.com/Perl/perl5/commit/4c4dfb4860fb41f528d6a1d94a77862e29d97874
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 7abfee05782b5ed1b82423d235b936134699f6bf
https://github.com/Perl/perl5/commit/7abfee05782b5ed1b82423d235b936134699f6bf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 88d4d8e97b01ab1710857180c3d35e5146a0848f
https://github.com/Perl/perl5/commit/88d4d8e97b01ab1710857180c3d35e5146a0848f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 8024dc35225cb49e61bf05044fc386f40264d2a7
https://github.com/Perl/perl5/commit/8024dc35225cb49e61bf05044fc386f40264d2a7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 06eeb210c53a5669e27951a1d41e303158c45b1d
https://github.com/Perl/perl5/commit/06eeb210c53a5669e27951a1d41e303158c45b1d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 013f67587da8aca22d8692ccb8616f88a36c9233
https://github.com/Perl/perl5/commit/013f67587da8aca22d8692ccb8616f88a36c9233
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: dd0062d062a1d37f89cc6c055879413e2f1d0de6
https://github.com/Perl/perl5/commit/dd0062d062a1d37f89cc6c055879413e2f1d0de6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 9f881830fd8bd85a36aa518d21d1f5f384dcbb96
https://github.com/Perl/perl5/commit/9f881830fd8bd85a36aa518d21d1f5f384dcbb96
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 8e1ae91a4854be2bb54876944613e0c4d2144c85
https://github.com/Perl/perl5/commit/8e1ae91a4854be2bb54876944613e0c4d2144c85
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 36edd6312f6219e08f52d1f6894f17c725e473c4
https://github.com/Perl/perl5/commit/36edd6312f6219e08f52d1f6894f17c725e473c4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: b751d5efb3ac9fab57b0c710c348b25bc61e0adb
https://github.com/Perl/perl5/commit/b751d5efb3ac9fab57b0c710c348b25bc61e0adb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: d977a9a6d1c70fe36d7ce9991e15eda5b6748740
https://github.com/Perl/perl5/commit/d977a9a6d1c70fe36d7ce9991e15eda5b6748740
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 8b37d2c79b45ceaac50c7cfb76e2a6c5ac166e1f
https://github.com/Perl/perl5/commit/8b37d2c79b45ceaac50c7cfb76e2a6c5ac166e1f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 6fcd3c509e544d03178822472bbb54cfcdd58d2a
https://github.com/Perl/perl5/commit/6fcd3c509e544d03178822472bbb54cfcdd58d2a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 15cf5b8f6269aa067a36de3e300ce2de02423630
https://github.com/Perl/perl5/commit/15cf5b8f6269aa067a36de3e300ce2de02423630
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 9cc0c62e64166285ddb90776929b3afc19719082
https://github.com/Perl/perl5/commit/9cc0c62e64166285ddb90776929b3afc19719082
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 6dd6a8f2f77b088bc5d25b5d78011be818b4c8f4
https://github.com/Perl/perl5/commit/6dd6a8f2f77b088bc5d25b5d78011be818b4c8f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 476fe3a68cd1d2fe3a041f262d266281e19ff404
https://github.com/Perl/perl5/commit/476fe3a68cd1d2fe3a041f262d266281e19ff404
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 54026036c294a7a00ec38aa30cde4543d0da2c10
https://github.com/Perl/perl5/commit/54026036c294a7a00ec38aa30cde4543d0da2c10
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 4e4b0114deb0ef1bb1912d15275ea06987adabd7
https://github.com/Perl/perl5/commit/4e4b0114deb0ef1bb1912d15275ea06987adabd7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 0e25c1a8db3ec49022757d844a4a0ee90a946df0
https://github.com/Perl/perl5/commit/0e25c1a8db3ec49022757d844a4a0ee90a946df0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 14c93b793241497b633f8986f95c6bbea5833827
https://github.com/Perl/perl5/commit/14c93b793241497b633f8986f95c6bbea5833827
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: f9fdcf63fcb53b23fab3ee58bc4ca122f27bdd96
https://github.com/Perl/perl5/commit/f9fdcf63fcb53b23fab3ee58bc4ca122f27bdd96
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: d2d28aa9110d4a0617a2899034fcc19cda1cd875
https://github.com/Perl/perl5/commit/d2d28aa9110d4a0617a2899034fcc19cda1cd875
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 40e605b0f12090f5af681bfa5959f34a25f97ac2
https://github.com/Perl/perl5/commit/40e605b0f12090f5af681bfa5959f34a25f97ac2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: a1171de5deb1e0c155ba323b6a7f4b66874d83d5
https://github.com/Perl/perl5/commit/a1171de5deb1e0c155ba323b6a7f4b66874d83d5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 3e4968af941e00a691e5c212881e48599dd8640b
https://github.com/Perl/perl5/commit/3e4968af941e00a691e5c212881e48599dd8640b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 108c8965e12d08ae845500b44779ac70131f1bdb
https://github.com/Perl/perl5/commit/108c8965e12d08ae845500b44779ac70131f1bdb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 5c00cb55f27c3ccba12bb78cb0ed0cd10dad27c6
https://github.com/Perl/perl5/commit/5c00cb55f27c3ccba12bb78cb0ed0cd10dad27c6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 66bde7e6be8739d2ab45870923c316afc5c1d912
https://github.com/Perl/perl5/commit/66bde7e6be8739d2ab45870923c316afc5c1d912
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: d42827d320eb01640dda6f2427420f62001e4574
https://github.com/Perl/perl5/commit/d42827d320eb01640dda6f2427420f62001e4574
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 1e57812b32ef3bae48c36f1beccc9e9735924d91
https://github.com/Perl/perl5/commit/1e57812b32ef3bae48c36f1beccc9e9735924d91
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 3c8a6738f15e4ade3c0fcf95f195b24481ef389f
https://github.com/Perl/perl5/commit/3c8a6738f15e4ade3c0fcf95f195b24481ef389f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 6dd1eb05ed62f8bc91f74fd82ff4b5474adcc6b8
https://github.com/Perl/perl5/commit/6dd1eb05ed62f8bc91f74fd82ff4b5474adcc6b8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: a7fd74fdeca8008dfdab1aced152fe63a393a8fc
https://github.com/Perl/perl5/commit/a7fd74fdeca8008dfdab1aced152fe63a393a8fc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 1e8ee7cd3d345ea363e9a4483c9c9bf8e1c14e6f
https://github.com/Perl/perl5/commit/1e8ee7cd3d345ea363e9a4483c9c9bf8e1c14e6f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 17241814c58a4b9f58d294457b8e00381863fefd
https://github.com/Perl/perl5/commit/17241814c58a4b9f58d294457b8e00381863fefd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 700a25876bfc594bcb71fd2581bc77b7e1b13945
https://github.com/Perl/perl5/commit/700a25876bfc594bcb71fd2581bc77b7e1b13945
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: c4766292d77c647a0263f0a6d6be257a469c0036
https://github.com/Perl/perl5/commit/c4766292d77c647a0263f0a6d6be257a469c0036
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: cf92ae41568df7b4ad3a0600ca32d73e0747b41f
https://github.com/Perl/perl5/commit/cf92ae41568df7b4ad3a0600ca32d73e0747b41f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 80e723794d38ebcb9923c5ecce27433284eacd6e
https://github.com/Perl/perl5/commit/80e723794d38ebcb9923c5ecce27433284eacd6e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 44eebf87ebe208f6b31c32fd3c6a4e8308748493
https://github.com/Perl/perl5/commit/44eebf87ebe208f6b31c32fd3c6a4e8308748493
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 77b38c39658d37afd3030d453eac1b95b96c873e
https://github.com/Perl/perl5/commit/77b38c39658d37afd3030d453eac1b95b96c873e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: e6b82ec5d8c12319d55325068406f3ccb60a860e
https://github.com/Perl/perl5/commit/e6b82ec5d8c12319d55325068406f3ccb60a860e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: ce4bd98c6b20b21ae5cdb62ea7bcc8181eaabcce
https://github.com/Perl/perl5/commit/ce4bd98c6b20b21ae5cdb62ea7bcc8181eaabcce
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: e67ab38959ba92fd0dc4f17a0435ef040dd15bbc
https://github.com/Perl/perl5/commit/e67ab38959ba92fd0dc4f17a0435ef040dd15bbc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 96ead2dc585fc3295ae39c2e6d2f6f4551c692fb
https://github.com/Perl/perl5/commit/96ead2dc585fc3295ae39c2e6d2f6f4551c692fb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 0cf932965a93fe06a3bc76158d0b143909f2321c
https://github.com/Perl/perl5/commit/0cf932965a93fe06a3bc76158d0b143909f2321c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 34c437be3b5b8be3590ca01b2afb295197d6d97e
https://github.com/Perl/perl5/commit/34c437be3b5b8be3590ca01b2afb295197d6d97e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: a41c4e0350fcab6541d4cc2051ddc6f44fefac89
https://github.com/Perl/perl5/commit/a41c4e0350fcab6541d4cc2051ddc6f44fefac89
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 4239e630c090ae24fb95adb2b18664736b8177f5
https://github.com/Perl/perl5/commit/4239e630c090ae24fb95adb2b18664736b8177f5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 0baed3de2841281a22a423fb88ef778b95022040
https://github.com/Perl/perl5/commit/0baed3de2841281a22a423fb88ef778b95022040
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 22ebf2bcc3ef85aa2034dc6c6baf3a97d5b05b5f
https://github.com/Perl/perl5/commit/22ebf2bcc3ef85aa2034dc6c6baf3a97d5b05b5f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 103dd059a7b769f3de4cba9036e0de8417e28db3
https://github.com/Perl/perl5/commit/103dd059a7b769f3de4cba9036e0de8417e28db3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 708dd2c4c46addb3ec864aaf90d9cd2729d94147
https://github.com/Perl/perl5/commit/708dd2c4c46addb3ec864aaf90d9cd2729d94147
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 8bc5e453f21fc555b5df92b750714156ed54d903
https://github.com/Perl/perl5/commit/8bc5e453f21fc555b5df92b750714156ed54d903
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: ab5466ad94d6dece297bc55983f1406fcf8022d1
https://github.com/Perl/perl5/commit/ab5466ad94d6dece297bc55983f1406fcf8022d1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: aad6f3319d02d3923c075fb65aad5ee2ef158ee3
https://github.com/Perl/perl5/commit/aad6f3319d02d3923c075fb65aad5ee2ef158ee3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 123daa11705884d13f0df2fdcf3a600d759f67e7
https://github.com/Perl/perl5/commit/123daa11705884d13f0df2fdcf3a600d759f67e7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: f261b00c7c7f3979b252f71e7490cbfa51cda358
https://github.com/Perl/perl5/commit/f261b00c7c7f3979b252f71e7490cbfa51cda358
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 2e7c8c3a1016e0fbbae2958f73d93a47c0e5b256
https://github.com/Perl/perl5/commit/2e7c8c3a1016e0fbbae2958f73d93a47c0e5b256
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 10a2b21e0a61cc572171250a068d048444412019
https://github.com/Perl/perl5/commit/10a2b21e0a61cc572171250a068d048444412019
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 4dd7d57ee3c8e1f95b9706d3b81c520c3e1eda01
https://github.com/Perl/perl5/commit/4dd7d57ee3c8e1f95b9706d3b81c520c3e1eda01
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: e806f21fc6f3906e41b36487d91a064ccf33a6cc
https://github.com/Perl/perl5/commit/e806f21fc6f3906e41b36487d91a064ccf33a6cc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 225b4bd062f4a3a0e10d1e550ead37244aa428b8
https://github.com/Perl/perl5/commit/225b4bd062f4a3a0e10d1e550ead37244aa428b8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: baf6833eaf64ab892040907222473cb55889d13e
https://github.com/Perl/perl5/commit/baf6833eaf64ab892040907222473cb55889d13e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: f29e1eb9ebeccdf5b98c6486e55257cd8c004bf3
https://github.com/Perl/perl5/commit/f29e1eb9ebeccdf5b98c6486e55257cd8c004bf3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: dcd7f54dadd551bf39a7bcf48706545e6fb2b94c
https://github.com/Perl/perl5/commit/dcd7f54dadd551bf39a7bcf48706545e6fb2b94c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 2c357652750adf5eeb1718a6917897091d66c6d1
https://github.com/Perl/perl5/commit/2c357652750adf5eeb1718a6917897091d66c6d1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 3781debb1e9913c00655965393c05bf155bd1635
https://github.com/Perl/perl5/commit/3781debb1e9913c00655965393c05bf155bd1635
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: b388b42fb14b3f72a4af4c3777da2eb6d8750ae7
https://github.com/Perl/perl5/commit/b388b42fb14b3f72a4af4c3777da2eb6d8750ae7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 735f7d3b9d73e8036ea641de56b75a7820bad1ca
https://github.com/Perl/perl5/commit/735f7d3b9d73e8036ea641de56b75a7820bad1ca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: ad1fc82f1037fa9e258a6a9c2421a6c8c09ca06c
https://github.com/Perl/perl5/commit/ad1fc82f1037fa9e258a6a9c2421a6c8c09ca06c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: ef67996e6704773b2fa1dc1ac43f5f4196a79960
https://github.com/Perl/perl5/commit/ef67996e6704773b2fa1dc1ac43f5f4196a79960
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: d12ee7b49593cd6923c0c70a7b1f241f77e15915
https://github.com/Perl/perl5/commit/d12ee7b49593cd6923c0c70a7b1f241f77e15915
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: b803b6d2c4fe9c1e920d16bb81c5085166661292
https://github.com/Perl/perl5/commit/b803b6d2c4fe9c1e920d16bb81c5085166661292
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: a2c8a72a7b22034e071f02b6acd3676fb3df2689
https://github.com/Perl/perl5/commit/a2c8a72a7b22034e071f02b6acd3676fb3df2689
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 4c0f1285e120ab16a5a8646a81042f4c21f8c673
https://github.com/Perl/perl5/commit/4c0f1285e120ab16a5a8646a81042f4c21f8c673
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: ee3ced86d75dbf67bbf3cb1b70f52140df075ec8
https://github.com/Perl/perl5/commit/ee3ced86d75dbf67bbf3cb1b70f52140df075ec8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 584e3095517b3b6bf4f20fdbdf721378d1caa5d6
https://github.com/Perl/perl5/commit/584e3095517b3b6bf4f20fdbdf721378d1caa5d6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a043be5d8aff1c2c39d7d6cb9e8f93e0520e37ba
https://github.com/Perl/perl5/commit/a043be5d8aff1c2c39d7d6cb9e8f93e0520e37ba
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: f3bcadd307a69d0bf363c3f2fc6fc3fe0a6dc214
https://github.com/Perl/perl5/commit/f3bcadd307a69d0bf363c3f2fc6fc3fe0a6dc214
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 5cf48dcbc85716ec38496ab83c1e4cc350bf3e79
https://github.com/Perl/perl5/commit/5cf48dcbc85716ec38496ab83c1e4cc350bf3e79
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 6b3e1c88a496eaf5572f7c556aed3d09f7564b10
https://github.com/Perl/perl5/commit/6b3e1c88a496eaf5572f7c556aed3d09f7564b10
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 92e89b469c7da9afdb9df466bf10ad04cc5a5135
https://github.com/Perl/perl5/commit/92e89b469c7da9afdb9df466bf10ad04cc5a5135
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: f975e35c4ccab06117a28cfcf216fd104351e904
https://github.com/Perl/perl5/commit/f975e35c4ccab06117a28cfcf216fd104351e904
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: f5bde51614d36d9674e025deaca7b013ad32c847
https://github.com/Perl/perl5/commit/f5bde51614d36d9674e025deaca7b013ad32c847
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 4b515f226def422c37c282dcf752583065b25e8a
https://github.com/Perl/perl5/commit/4b515f226def422c37c282dcf752583065b25e8a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 2475a37f515574e73073170122b7279fe63aa89d
https://github.com/Perl/perl5/commit/2475a37f515574e73073170122b7279fe63aa89d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 6ff875d8760f4b2d08782f6cdd54f19c152683cd
https://github.com/Perl/perl5/commit/6ff875d8760f4b2d08782f6cdd54f19c152683cd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: d797a454431fafac5500b5178175a12bd446f52e
https://github.com/Perl/perl5/commit/d797a454431fafac5500b5178175a12bd446f52e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 8ab1dc75f6283c8072b9af352e60c8e5556ce334
https://github.com/Perl/perl5/commit/8ab1dc75f6283c8072b9af352e60c8e5556ce334
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 8304de36776507dbd26ff3d3141b6c169efcd922
https://github.com/Perl/perl5/commit/8304de36776507dbd26ff3d3141b6c169efcd922
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 554dc6d0e64c8113f41cd019ef4679db20280531
https://github.com/Perl/perl5/commit/554dc6d0e64c8113f41cd019ef4679db20280531
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 6fe6adac4fb2fc13413f96e7094a0bed70cf56f8
https://github.com/Perl/perl5/commit/6fe6adac4fb2fc13413f96e7094a0bed70cf56f8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 5a5e1e12e5d0883c8b01ff2edb8db7bfd1e6fe3b
https://github.com/Perl/perl5/commit/5a5e1e12e5d0883c8b01ff2edb8db7bfd1e6fe3b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: ab83e86b3d78b51d626332b10874099f718ae770
https://github.com/Perl/perl5/commit/ab83e86b3d78b51d626332b10874099f718ae770
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: c19780d68a0f803b442a1646adbdbe17d7a95d75
https://github.com/Perl/perl5/commit/c19780d68a0f803b442a1646adbdbe17d7a95d75
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 15136188a299c0bc6ff1f7a155a9ae4ee8401436
https://github.com/Perl/perl5/commit/15136188a299c0bc6ff1f7a155a9ae4ee8401436
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 01c00af30b1fbf8ddb51c86efe6b0b7682864401
https://github.com/Perl/perl5/commit/01c00af30b1fbf8ddb51c86efe6b0b7682864401
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: b1df5495e91ab3f1b2434125aa9eef327d6d3d37
https://github.com/Perl/perl5/commit/b1df5495e91ab3f1b2434125aa9eef327d6d3d37
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 9421460ef3fd39797c1db311a05fceb9b5871108
https://github.com/Perl/perl5/commit/9421460ef3fd39797c1db311a05fceb9b5871108
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 0828428c2286b1441f0a542996969d4e9b7af8fd
https://github.com/Perl/perl5/commit/0828428c2286b1441f0a542996969d4e9b7af8fd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 3333ef63a8f58056681c348c5f416335ab4fd510
https://github.com/Perl/perl5/commit/3333ef63a8f58056681c348c5f416335ab4fd510
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: bb6d6b96af12edca3b805d355e396937828732cd
https://github.com/Perl/perl5/commit/bb6d6b96af12edca3b805d355e396937828732cd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 1c9f70762c4895a63177be64e6625924b7c527f0
https://github.com/Perl/perl5/commit/1c9f70762c4895a63177be64e6625924b7c527f0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: eb8846acb8fa2d8fc34f5a8f5c23fc575f5cdff9
https://github.com/Perl/perl5/commit/eb8846acb8fa2d8fc34f5a8f5c23fc575f5cdff9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 5fb6d65fcd250c5bf36c9bd97b70c99bf5964323
https://github.com/Perl/perl5/commit/5fb6d65fcd250c5bf36c9bd97b70c99bf5964323
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 20d3c0974444357326c0449c9ad5fcbaaf816e00
https://github.com/Perl/perl5/commit/20d3c0974444357326c0449c9ad5fcbaaf816e00
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 22d122f18080642f7e7b2d489bdbadca3a8eda65
https://github.com/Perl/perl5/commit/22d122f18080642f7e7b2d489bdbadca3a8eda65
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 3c659e3c9ed305e4aa68c859ae3d678cd2e234ac
https://github.com/Perl/perl5/commit/3c659e3c9ed305e4aa68c859ae3d678cd2e234ac
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 2698997ccbcc286b0c59227cea13c0184ed91e1b
https://github.com/Perl/perl5/commit/2698997ccbcc286b0c59227cea13c0184ed91e1b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 4ed24e5de8f1352bb57e88f02889bef1f041e175
https://github.com/Perl/perl5/commit/4ed24e5de8f1352bb57e88f02889bef1f041e175
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e4fbe0a8c4c314e0b9ca6a0c6514b2d855924877
https://github.com/Perl/perl5/commit/e4fbe0a8c4c314e0b9ca6a0c6514b2d855924877
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5e2942583c130728714da5b5f60de6b81809531a
https://github.com/Perl/perl5/commit/5e2942583c130728714da5b5f60de6b81809531a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 32aeb73437eebd66f3fe2aa588eb18b044a88569
https://github.com/Perl/perl5/commit/32aeb73437eebd66f3fe2aa588eb18b044a88569
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 7ef5e8369f54e6ea4336d7ba26102369109abe79
https://github.com/Perl/perl5/commit/7ef5e8369f54e6ea4336d7ba26102369109abe79
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: b219105cf95fbc73b7356736e3a690f1d92bbbcb
https://github.com/Perl/perl5/commit/b219105cf95fbc73b7356736e3a690f1d92bbbcb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 053788fb30b11c6ae912d8212a754e2bca8dce22
https://github.com/Perl/perl5/commit/053788fb30b11c6ae912d8212a754e2bca8dce22
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 3ea3023bb51eabd3b07a29b41d6db62fb846b642
https://github.com/Perl/perl5/commit/3ea3023bb51eabd3b07a29b41d6db62fb846b642
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2c8fb8b05306c4a7ec6b0d3c4742bf1698bf10ba
https://github.com/Perl/perl5/commit/2c8fb8b05306c4a7ec6b0d3c4742bf1698bf10ba
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 8a53f1f161c8a1e9b7be5ba14242541d2be3c100
https://github.com/Perl/perl5/commit/8a53f1f161c8a1e9b7be5ba14242541d2be3c100
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 3a5d486cd8a37cc89a14e7821a64294a6d5c9a09
https://github.com/Perl/perl5/commit/3a5d486cd8a37cc89a14e7821a64294a6d5c9a09
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: b1a0e783020f47a5c7f3696736a135a81c7f9c72
https://github.com/Perl/perl5/commit/b1a0e783020f47a5c7f3696736a135a81c7f9c72
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: f3c156af7452a159e884821adcf2ef5755568049
https://github.com/Perl/perl5/commit/f3c156af7452a159e884821adcf2ef5755568049
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: df62bd15e12f21469eeb21ba00b1f7052f79773f
https://github.com/Perl/perl5/commit/df62bd15e12f21469eeb21ba00b1f7052f79773f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 05f6ebf5ef9319088d93f0425328f58646bb7b0b
https://github.com/Perl/perl5/commit/05f6ebf5ef9319088d93f0425328f58646bb7b0b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b59542424fc453140129cb2fb088090728faf1c8
https://github.com/Perl/perl5/commit/b59542424fc453140129cb2fb088090728faf1c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 086247d7410e692db772d4489ca6d9b81a6e3436
https://github.com/Perl/perl5/commit/086247d7410e692db772d4489ca6d9b81a6e3436
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: ee777b8a1f944f5acfd77078aa934842d79dd9a3
https://github.com/Perl/perl5/commit/ee777b8a1f944f5acfd77078aa934842d79dd9a3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 2f33b4771452b043c03ec779c8eb49861719cfeb
https://github.com/Perl/perl5/commit/2f33b4771452b043c03ec779c8eb49861719cfeb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: ae782123f063407ba03cba04041598b6c2b030c5
https://github.com/Perl/perl5/commit/ae782123f063407ba03cba04041598b6c2b030c5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: ef10c642becaf5bffbd814064add85572cd6fa4d
https://github.com/Perl/perl5/commit/ef10c642becaf5bffbd814064add85572cd6fa4d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 364ba2e2d1ff6bc55248051fc218d39fa7dc67ac
https://github.com/Perl/perl5/commit/364ba2e2d1ff6bc55248051fc218d39fa7dc67ac
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fbeaa9e3ca9ae8e48b20347ef037244c4a4d0f96
https://github.com/Perl/perl5/commit/fbeaa9e3ca9ae8e48b20347ef037244c4a4d0f96
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 86bdd073254647567013250d5825c87c4ae61592
https://github.com/Perl/perl5/commit/86bdd073254647567013250d5825c87c4ae61592
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: bdc3ed0cc3d22b721c13856914b54b39121b513b
https://github.com/Perl/perl5/commit/bdc3ed0cc3d22b721c13856914b54b39121b513b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 549d7b66916a40351a751674b55b80c98594b5d7
https://github.com/Perl/perl5/commit/549d7b66916a40351a751674b55b80c98594b5d7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 0f1e1617f39a9a4e01b80d5199e3155503162bf4
https://github.com/Perl/perl5/commit/0f1e1617f39a9a4e01b80d5199e3155503162bf4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 73508f1d90c230ef62bc8da612ec04ca8181694f
https://github.com/Perl/perl5/commit/73508f1d90c230ef62bc8da612ec04ca8181694f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 6dcdc9244122c509ddc66cee78cdc99c1ccb0fc9
https://github.com/Perl/perl5/commit/6dcdc9244122c509ddc66cee78cdc99c1ccb0fc9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 8458a657cc9fa85f31f6dbc29de979ad70052277
https://github.com/Perl/perl5/commit/8458a657cc9fa85f31f6dbc29de979ad70052277
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 1a18ed433f960050d34d7029ac3d29208dc511fe
https://github.com/Perl/perl5/commit/1a18ed433f960050d34d7029ac3d29208dc511fe
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 9893c9609329d9d5c69120ba65aea63c0d603b54
https://github.com/Perl/perl5/commit/9893c9609329d9d5c69120ba65aea63c0d603b54
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: d1949c5f41ecda732a1cadb300a7375cea827443
https://github.com/Perl/perl5/commit/d1949c5f41ecda732a1cadb300a7375cea827443
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 0c39601ad4c5d674814f14b1060d9606e703049f
https://github.com/Perl/perl5/commit/0c39601ad4c5d674814f14b1060d9606e703049f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: a4f18d70b7769ae7ffc71547add7704d88048414
https://github.com/Perl/perl5/commit/a4f18d70b7769ae7ffc71547add7704d88048414
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 40f8b8bcb4008fd5258203bdc1b14ab470020a06
https://github.com/Perl/perl5/commit/40f8b8bcb4008fd5258203bdc1b14ab470020a06
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 5d69ec9e07ca1f6e860ee0be3fca08bcd27b50e0
https://github.com/Perl/perl5/commit/5d69ec9e07ca1f6e860ee0be3fca08bcd27b50e0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 41f4384b7246f3d577c13c5a8ffc13192e2fd408
https://github.com/Perl/perl5/commit/41f4384b7246f3d577c13c5a8ffc13192e2fd408
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 65ba8d84bbe11efcb60074c5258446091f2432f8
https://github.com/Perl/perl5/commit/65ba8d84bbe11efcb60074c5258446091f2432f8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 6ea4179f6b9b7aac57688aff567b62c1ee32c261
https://github.com/Perl/perl5/commit/6ea4179f6b9b7aac57688aff567b62c1ee32c261
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more15
Compare: https://github.com/Perl/perl5/compare/7fd5cc107973...6ea4179f6b9b
