Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 209da48877bc87689945596e3520e9ccbc0f754c
https://github.com/Perl/perl5/commit/209da48877bc87689945596e3520e9ccbc0f754c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 16f4e6077119df147de952205c34b3458d5402e7
https://github.com/Perl/perl5/commit/16f4e6077119df147de952205c34b3458d5402e7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 73eac203622d4ad8e47b7b401802d213984797b7
https://github.com/Perl/perl5/commit/73eac203622d4ad8e47b7b401802d213984797b7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 7a6fbfffe750169c8a149bfd371c54c091ac4d84
https://github.com/Perl/perl5/commit/7a6fbfffe750169c8a149bfd371c54c091ac4d84
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: bb51285f183abefad921f0299429abac76eebd22
https://github.com/Perl/perl5/commit/bb51285f183abefad921f0299429abac76eebd22
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 864335e7bc30cde003dcde344552d347223f6e39
https://github.com/Perl/perl5/commit/864335e7bc30cde003dcde344552d347223f6e39
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: e1da12e90fae3fb93d101442ef5cbc3cecfa6596
https://github.com/Perl/perl5/commit/e1da12e90fae3fb93d101442ef5cbc3cecfa6596
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 77bfb9d4278349763a32f0d20c238342ab29e280
https://github.com/Perl/perl5/commit/77bfb9d4278349763a32f0d20c238342ab29e280
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 490ca478a4c01c41588c3488c8df8f53a3bdbba2
https://github.com/Perl/perl5/commit/490ca478a4c01c41588c3488c8df8f53a3bdbba2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 009021d64b8b96d107494bfa238149566d6eb9dd
https://github.com/Perl/perl5/commit/009021d64b8b96d107494bfa238149566d6eb9dd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: d8a38ef1fb7af7f6c7e134d6c17d469faab31c3a
https://github.com/Perl/perl5/commit/d8a38ef1fb7af7f6c7e134d6c17d469faab31c3a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: e5bd17a9c74e30b36759076863def2888d3fdbb7
https://github.com/Perl/perl5/commit/e5bd17a9c74e30b36759076863def2888d3fdbb7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 2f85ad423ced889349611169654b4719883a8052
https://github.com/Perl/perl5/commit/2f85ad423ced889349611169654b4719883a8052
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: d7d2bdd52436be614227ff3715e9743920601c0a
https://github.com/Perl/perl5/commit/d7d2bdd52436be614227ff3715e9743920601c0a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 49d1b86bc737b6f73582e6182c2c57b0b9316c29
https://github.com/Perl/perl5/commit/49d1b86bc737b6f73582e6182c2c57b0b9316c29
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: f2bf6b969fdba266cba23c4a222f9e552ea2af5d
https://github.com/Perl/perl5/commit/f2bf6b969fdba266cba23c4a222f9e552ea2af5d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 991e802bdfe8eeb6baae36a18ea5b055d3f31597
https://github.com/Perl/perl5/commit/991e802bdfe8eeb6baae36a18ea5b055d3f31597
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5f38291ff643b6e94b91e951dea53067f4be283a
https://github.com/Perl/perl5/commit/5f38291ff643b6e94b91e951dea53067f4be283a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: ef0d322e3e10e180b877a316e368da3d35b5dc20
https://github.com/Perl/perl5/commit/ef0d322e3e10e180b877a316e368da3d35b5dc20
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: da54c998071e24a1b5774a61a632442c517695db
https://github.com/Perl/perl5/commit/da54c998071e24a1b5774a61a632442c517695db
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 601f6b13fb879859f9c8b7555f7bbe9e6701a1ca
https://github.com/Perl/perl5/commit/601f6b13fb879859f9c8b7555f7bbe9e6701a1ca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 61bc536e63d7e4e8038e6553e0fbb0b44386fdab
https://github.com/Perl/perl5/commit/61bc536e63d7e4e8038e6553e0fbb0b44386fdab
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 847889b3ce6589f6cacbbbb320a40bc049dbbce3
https://github.com/Perl/perl5/commit/847889b3ce6589f6cacbbbb320a40bc049dbbce3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 2ed0be3771a592f0187610f9debacfd3297a156f
https://github.com/Perl/perl5/commit/2ed0be3771a592f0187610f9debacfd3297a156f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 822471ea848340da30efd266eb1f10fc80373214
https://github.com/Perl/perl5/commit/822471ea848340da30efd266eb1f10fc80373214
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: ca253303e69256cc005a3fb915337a5477b6391d
https://github.com/Perl/perl5/commit/ca253303e69256cc005a3fb915337a5477b6391d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 25407ca38a0e7b388c1860fd0983ac2702bcdad9
https://github.com/Perl/perl5/commit/25407ca38a0e7b388c1860fd0983ac2702bcdad9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 1b353791f878bbf90b5cc57c8476cdce7e4c2075
https://github.com/Perl/perl5/commit/1b353791f878bbf90b5cc57c8476cdce7e4c2075
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: b61a13a12224c7730b0ba5d73e9b8706bacc18b2
https://github.com/Perl/perl5/commit/b61a13a12224c7730b0ba5d73e9b8706bacc18b2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: a4abe30c7fa329c8fe7b25ba8676b80b0f656743
https://github.com/Perl/perl5/commit/a4abe30c7fa329c8fe7b25ba8676b80b0f656743
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: ec05b10f6f19cda92d05ee929705018565a22d10
https://github.com/Perl/perl5/commit/ec05b10f6f19cda92d05ee929705018565a22d10
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: c8cac995f8aaa8554f86f6bbf058912c01d301e8
https://github.com/Perl/perl5/commit/c8cac995f8aaa8554f86f6bbf058912c01d301e8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 4620a8f8fca43da3855d79120761c69f08242af8
https://github.com/Perl/perl5/commit/4620a8f8fca43da3855d79120761c69f08242af8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 376a65b31b3c871f90d1926ec30b1a3e905bff5c
https://github.com/Perl/perl5/commit/376a65b31b3c871f90d1926ec30b1a3e905bff5c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 5d4f475c5a8d709817fb792d11a5ac89c3aad983
https://github.com/Perl/perl5/commit/5d4f475c5a8d709817fb792d11a5ac89c3aad983
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: d98be6ec40b054674db022033fec34d6f040ad6c
https://github.com/Perl/perl5/commit/d98be6ec40b054674db022033fec34d6f040ad6c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: cad6945b776d5614d1a8e0909b4b7120154e8581
https://github.com/Perl/perl5/commit/cad6945b776d5614d1a8e0909b4b7120154e8581
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 08bf47d4ca43562ee4220e9776d6afebb98e5b87
https://github.com/Perl/perl5/commit/08bf47d4ca43562ee4220e9776d6afebb98e5b87
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: af9ff61fc69dd25447864fd6798d1020fbfe2cff
https://github.com/Perl/perl5/commit/af9ff61fc69dd25447864fd6798d1020fbfe2cff
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: ebba258d2b7d8afc8e537da893bef7f483e66f6a
https://github.com/Perl/perl5/commit/ebba258d2b7d8afc8e537da893bef7f483e66f6a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 8f3dd1631e0fa58861ef4ed7d5ce77a3ae1b7ff5
https://github.com/Perl/perl5/commit/8f3dd1631e0fa58861ef4ed7d5ce77a3ae1b7ff5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: c142dfcda218bca26730109bf40862e7c180090c
https://github.com/Perl/perl5/commit/c142dfcda218bca26730109bf40862e7c180090c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: eca6a348fedabc0ab3efa789a08ad47956697648
https://github.com/Perl/perl5/commit/eca6a348fedabc0ab3efa789a08ad47956697648
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 674f38e6356aacff8040de4af03b0f448bfac806
https://github.com/Perl/perl5/commit/674f38e6356aacff8040de4af03b0f448bfac806
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 1cc10c43ab2d9b8132725447d66a03e44c370add
https://github.com/Perl/perl5/commit/1cc10c43ab2d9b8132725447d66a03e44c370add
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 06cd47e901a6ecd99074c39481d3b64e3c70471c
https://github.com/Perl/perl5/commit/06cd47e901a6ecd99074c39481d3b64e3c70471c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: a1d3515fa33e94e8507b8e182e448a72b4f1fdd6
https://github.com/Perl/perl5/commit/a1d3515fa33e94e8507b8e182e448a72b4f1fdd6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: c8247f2c4d2e04c4e798684d051975afc42fdd2e
https://github.com/Perl/perl5/commit/c8247f2c4d2e04c4e798684d051975afc42fdd2e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: c59b23007057e436013071a9b87c7c05bb791d4b
https://github.com/Perl/perl5/commit/c59b23007057e436013071a9b87c7c05bb791d4b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: c03293a930b9e6e001aa48c69c1ee3e48e56fb35
https://github.com/Perl/perl5/commit/c03293a930b9e6e001aa48c69c1ee3e48e56fb35
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: d0180733b8f60bc2569bcdc8cf784dafbfea3285
https://github.com/Perl/perl5/commit/d0180733b8f60bc2569bcdc8cf784dafbfea3285
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 503409dc433aed5d83c9aca9c0ac8f981c039fa0
https://github.com/Perl/perl5/commit/503409dc433aed5d83c9aca9c0ac8f981c039fa0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 489928d75eef89d16bf2dd53323871b36b7d7d68
https://github.com/Perl/perl5/commit/489928d75eef89d16bf2dd53323871b36b7d7d68
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 2f201c96d5e1833aeb543d01793b3f58393c5e7c
https://github.com/Perl/perl5/commit/2f201c96d5e1833aeb543d01793b3f58393c5e7c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: ed7b9c45809e7f5cdc637ec80c62ffd758d94f4d
https://github.com/Perl/perl5/commit/ed7b9c45809e7f5cdc637ec80c62ffd758d94f4d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: de8e4bf7036a034518fe0f8f0bfcd2471fefb9e9
https://github.com/Perl/perl5/commit/de8e4bf7036a034518fe0f8f0bfcd2471fefb9e9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 1d350a15ece48bf393d2fe55c8d080f98f3dc537
https://github.com/Perl/perl5/commit/1d350a15ece48bf393d2fe55c8d080f98f3dc537
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 99c1c2f78b09e3da93c1809a817d3e0a889d2602
https://github.com/Perl/perl5/commit/99c1c2f78b09e3da93c1809a817d3e0a889d2602
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: a3e68154f1bbb6741b875dc7a9a6bca4327546cb
https://github.com/Perl/perl5/commit/a3e68154f1bbb6741b875dc7a9a6bca4327546cb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: c994ff5c2315425aa8f415f85b33bfc0b20cc67d
https://github.com/Perl/perl5/commit/c994ff5c2315425aa8f415f85b33bfc0b20cc67d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: b3378e51c6a4b3b4e20bf5f0d39a9e52b3f13c36
https://github.com/Perl/perl5/commit/b3378e51c6a4b3b4e20bf5f0d39a9e52b3f13c36
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: d5b16e7e02e5b6a52f3a5c0b75db524ae436ef90
https://github.com/Perl/perl5/commit/d5b16e7e02e5b6a52f3a5c0b75db524ae436ef90
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 5f64785adcd70fc1115d3725ac09025a614246c8
https://github.com/Perl/perl5/commit/5f64785adcd70fc1115d3725ac09025a614246c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: d34cceecba5ded28197edecf1308123fa4a99eaf
https://github.com/Perl/perl5/commit/d34cceecba5ded28197edecf1308123fa4a99eaf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: f167b0e4a9cadd519d93045c49a6f759954a3c7c
https://github.com/Perl/perl5/commit/f167b0e4a9cadd519d93045c49a6f759954a3c7c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 48bf201fef341c318349d8b5be642481fb8a1499
https://github.com/Perl/perl5/commit/48bf201fef341c318349d8b5be642481fb8a1499
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 403d568e79c81ee1ae7d120cf3947ff93e261682
https://github.com/Perl/perl5/commit/403d568e79c81ee1ae7d120cf3947ff93e261682
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: ee2e71d89e8c34460097de965da8ac477ac44924
https://github.com/Perl/perl5/commit/ee2e71d89e8c34460097de965da8ac477ac44924
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 0fdc7efdfdbde59f5baf67af66a232a167dd0ca5
https://github.com/Perl/perl5/commit/0fdc7efdfdbde59f5baf67af66a232a167dd0ca5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 520e875530910a19b56f791658d800ab7a1422ba
https://github.com/Perl/perl5/commit/520e875530910a19b56f791658d800ab7a1422ba
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: cfcaa65e9d5f46f86a96ef3fafe87bbcb915f66a
https://github.com/Perl/perl5/commit/cfcaa65e9d5f46f86a96ef3fafe87bbcb915f66a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 72b64d07d279ed0b01a0adc8e6ec7f13a268f4f2
https://github.com/Perl/perl5/commit/72b64d07d279ed0b01a0adc8e6ec7f13a268f4f2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 505e46a93a7549b5374acf0ffac94232b10be12b
https://github.com/Perl/perl5/commit/505e46a93a7549b5374acf0ffac94232b10be12b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 11a2dc9fda0a8c8b856a06fec162840e26ccacca
https://github.com/Perl/perl5/commit/11a2dc9fda0a8c8b856a06fec162840e26ccacca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 33418733003ea578530a60000fc29630d3a6f4fa
https://github.com/Perl/perl5/commit/33418733003ea578530a60000fc29630d3a6f4fa
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 47227131c79f39711952e6c0e4f5a3945c26d472
https://github.com/Perl/perl5/commit/47227131c79f39711952e6c0e4f5a3945c26d472
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 9064e21d26236cf3d4db754cd672536c89c2f2b2
https://github.com/Perl/perl5/commit/9064e21d26236cf3d4db754cd672536c89c2f2b2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 82951125b8f5513bdf55de798039243bf906bce1
https://github.com/Perl/perl5/commit/82951125b8f5513bdf55de798039243bf906bce1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 29df20773c97d890bd3e486484de38f228d02f2f
https://github.com/Perl/perl5/commit/29df20773c97d890bd3e486484de38f228d02f2f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 71d91128d56eef96d6f595afac8fded194f420c8
https://github.com/Perl/perl5/commit/71d91128d56eef96d6f595afac8fded194f420c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: c4607cadeae36c5fe4c92032a2e361e634ef13bc
https://github.com/Perl/perl5/commit/c4607cadeae36c5fe4c92032a2e361e634ef13bc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 6466c46f5d605ab8ea941b9265e287e8af3a4c7c
https://github.com/Perl/perl5/commit/6466c46f5d605ab8ea941b9265e287e8af3a4c7c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 23f2bb9fa0481edce7a2e572a7fb97e6a5fe2824
https://github.com/Perl/perl5/commit/23f2bb9fa0481edce7a2e572a7fb97e6a5fe2824
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 12d933532e1c62f5bc279a05b705d12f9fba006b
https://github.com/Perl/perl5/commit/12d933532e1c62f5bc279a05b705d12f9fba006b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 7e075f66ba7cd551d9e4b41f85c175988833a92f
https://github.com/Perl/perl5/commit/7e075f66ba7cd551d9e4b41f85c175988833a92f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 0abab0ae7c3b7e0a440f918a14e39da356b8bd73
https://github.com/Perl/perl5/commit/0abab0ae7c3b7e0a440f918a14e39da356b8bd73
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: f29a8aaeb9f72375fc2a874369032a80b005106f
https://github.com/Perl/perl5/commit/f29a8aaeb9f72375fc2a874369032a80b005106f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: f3c4d01f0e7cd9ff30fab9cc816633dcf49b33ad
https://github.com/Perl/perl5/commit/f3c4d01f0e7cd9ff30fab9cc816633dcf49b33ad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: ab7105636f6b08d4b5d0fc3b1fdfd2ba36ae7970
https://github.com/Perl/perl5/commit/ab7105636f6b08d4b5d0fc3b1fdfd2ba36ae7970
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 5a9172aa601577a7da3b00d27ffd3dcee9b836c1
https://github.com/Perl/perl5/commit/5a9172aa601577a7da3b00d27ffd3dcee9b836c1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: f8d487ecdf32399f12931c63af19ed582e55d60f
https://github.com/Perl/perl5/commit/f8d487ecdf32399f12931c63af19ed582e55d60f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 15ec698186b014d4703d39d9dda40ee1048b16ec
https://github.com/Perl/perl5/commit/15ec698186b014d4703d39d9dda40ee1048b16ec
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 9ccdb9af4ad6fc4119c298cef436cb4ce1890ea1
https://github.com/Perl/perl5/commit/9ccdb9af4ad6fc4119c298cef436cb4ce1890ea1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 409a33b986a0565d085b8f71ca58f20d728fbb42
https://github.com/Perl/perl5/commit/409a33b986a0565d085b8f71ca58f20d728fbb42
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: e11e9e2c62dc334d7a25d727f255eb12b5d2dbf8
https://github.com/Perl/perl5/commit/e11e9e2c62dc334d7a25d727f255eb12b5d2dbf8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9828599ed7405672835d209c1bcec415ca77737b
https://github.com/Perl/perl5/commit/9828599ed7405672835d209c1bcec415ca77737b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 660bc0afe38413428b6a1232b6bc7c358c7ba958
https://github.com/Perl/perl5/commit/660bc0afe38413428b6a1232b6bc7c358c7ba958
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 20c27048679b66b4f97f9b46427b3f48643c951c
https://github.com/Perl/perl5/commit/20c27048679b66b4f97f9b46427b3f48643c951c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 7ac15e5d710e84b9ba6e398cf8544d22802851ce
https://github.com/Perl/perl5/commit/7ac15e5d710e84b9ba6e398cf8544d22802851ce
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: e8ff48ce8454b84e843d1553b272e0be3d6407a1
https://github.com/Perl/perl5/commit/e8ff48ce8454b84e843d1553b272e0be3d6407a1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 00b4f85a7fcc84abcfb59714e219b4dc919b54f9
https://github.com/Perl/perl5/commit/00b4f85a7fcc84abcfb59714e219b4dc919b54f9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 642452bb2f2a1790f2e6f2ee4a8c13d39af4a3f4
https://github.com/Perl/perl5/commit/642452bb2f2a1790f2e6f2ee4a8c13d39af4a3f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: dcd59126e8ab70ea1ca6d9cda17b24beff750b52
https://github.com/Perl/perl5/commit/dcd59126e8ab70ea1ca6d9cda17b24beff750b52
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: dd890924e2c4328abd15bae5588c8dacb9994994
https://github.com/Perl/perl5/commit/dd890924e2c4328abd15bae5588c8dacb9994994
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: d8abbbf72ae3646befd14fa4dd31bc77b6778345
https://github.com/Perl/perl5/commit/d8abbbf72ae3646befd14fa4dd31bc77b6778345
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: f82e1dfbc6dcb2232f2559b1680628d389b5d7d6
https://github.com/Perl/perl5/commit/f82e1dfbc6dcb2232f2559b1680628d389b5d7d6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 99ec60f4a9b9cab3b10573afe78ce1d056820542
https://github.com/Perl/perl5/commit/99ec60f4a9b9cab3b10573afe78ce1d056820542
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 2e8c9e772571d3a15414be6f442118697fc9b3d2
https://github.com/Perl/perl5/commit/2e8c9e772571d3a15414be6f442118697fc9b3d2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: b458460f1fc9f590b9d479fdb39f55e275bdfbaa
https://github.com/Perl/perl5/commit/b458460f1fc9f590b9d479fdb39f55e275bdfbaa
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 7aa916c4a4f90e867a1b1d7196810e401062aeb8
https://github.com/Perl/perl5/commit/7aa916c4a4f90e867a1b1d7196810e401062aeb8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: d718cae62ab31e6aba3e7478442259c9987e8138
https://github.com/Perl/perl5/commit/d718cae62ab31e6aba3e7478442259c9987e8138
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: a95174cc061155398bdb1957f9c92464bb98321a
https://github.com/Perl/perl5/commit/a95174cc061155398bdb1957f9c92464bb98321a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 207da9f3cc680b5851ce01c327140fa97248c306
https://github.com/Perl/perl5/commit/207da9f3cc680b5851ce01c327140fa97248c306
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 5b96c382f1cb56214d5ce1a46fce6e504f83dfdb
https://github.com/Perl/perl5/commit/5b96c382f1cb56214d5ce1a46fce6e504f83dfdb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: cfe7c3c0737a76698cfebf0fac4e15522d18532a
https://github.com/Perl/perl5/commit/cfe7c3c0737a76698cfebf0fac4e15522d18532a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 6261c6de97ebed7cf755176717e8d7c9fcc2a7c8
https://github.com/Perl/perl5/commit/6261c6de97ebed7cf755176717e8d7c9fcc2a7c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: e2569e5b059ad8619c9beaf45ce4d951cd5af0f5
https://github.com/Perl/perl5/commit/e2569e5b059ad8619c9beaf45ce4d951cd5af0f5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: ffb2b6cabef5254a133c69d53aa5e924987963f3
https://github.com/Perl/perl5/commit/ffb2b6cabef5254a133c69d53aa5e924987963f3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 222d352bc8c29aa787ae9736c7cc9c58dee0cc60
https://github.com/Perl/perl5/commit/222d352bc8c29aa787ae9736c7cc9c58dee0cc60
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 30d229fa468ddba24572e9d0b675c963d9f4b53a
https://github.com/Perl/perl5/commit/30d229fa468ddba24572e9d0b675c963d9f4b53a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 7d53251b19a02168e60e017df1b888d3cbadf73d
https://github.com/Perl/perl5/commit/7d53251b19a02168e60e017df1b888d3cbadf73d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: bcb25b0c686200a572fe91d47643cefadc0237f4
https://github.com/Perl/perl5/commit/bcb25b0c686200a572fe91d47643cefadc0237f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 6915bfb411ddf6f74a2ea34e0c206f1d4b32b895
https://github.com/Perl/perl5/commit/6915bfb411ddf6f74a2ea34e0c206f1d4b32b895
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: f8def17ab09ee368262d40e4d4c67eb70a156199
https://github.com/Perl/perl5/commit/f8def17ab09ee368262d40e4d4c67eb70a156199
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 5c748e20916883f186646c27689b4b7cb460b409
https://github.com/Perl/perl5/commit/5c748e20916883f186646c27689b4b7cb460b409
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 359842ca791fc813bb08c7b449dbbe9437845d8e
https://github.com/Perl/perl5/commit/359842ca791fc813bb08c7b449dbbe9437845d8e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: a126bac5306bb9ebd70cb55b413f1893bc108d4e
https://github.com/Perl/perl5/commit/a126bac5306bb9ebd70cb55b413f1893bc108d4e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 8baf25586736c3578be7e74841d6a1c7b00e8108
https://github.com/Perl/perl5/commit/8baf25586736c3578be7e74841d6a1c7b00e8108
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 55fa112dbe2a528eab8cb277ce993747dd84d6d7
https://github.com/Perl/perl5/commit/55fa112dbe2a528eab8cb277ce993747dd84d6d7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: c14c362a118e8c443e44420cc12743778dd49203
https://github.com/Perl/perl5/commit/c14c362a118e8c443e44420cc12743778dd49203
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: c01c11bed4926b21f6732b33fa5d08219877c99d
https://github.com/Perl/perl5/commit/c01c11bed4926b21f6732b33fa5d08219877c99d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 0f4d94e48c8ad4e70fd70148a59bc56272bd7559
https://github.com/Perl/perl5/commit/0f4d94e48c8ad4e70fd70148a59bc56272bd7559
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: a8f528e560734f8ed064c9067446005833fd4622
https://github.com/Perl/perl5/commit/a8f528e560734f8ed064c9067446005833fd4622
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 84d302c9f36cb550bc9e427adc7c0466eff726c8
https://github.com/Perl/perl5/commit/84d302c9f36cb550bc9e427adc7c0466eff726c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: c33075c12ac4be4501e1bec1cc58d53fb1fd1915
https://github.com/Perl/perl5/commit/c33075c12ac4be4501e1bec1cc58d53fb1fd1915
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 1eb5d1344dcfc4303634027db95a9544a235852e
https://github.com/Perl/perl5/commit/1eb5d1344dcfc4303634027db95a9544a235852e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 7455df74d048147e77a99d9c154f15dd1f357677
https://github.com/Perl/perl5/commit/7455df74d048147e77a99d9c154f15dd1f357677
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 5d4f43a1a94b5fbc51d9699fff64e9a157333bf0
https://github.com/Perl/perl5/commit/5d4f43a1a94b5fbc51d9699fff64e9a157333bf0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 10223124cc28bcf59773455f3f15cebb40160a40
https://github.com/Perl/perl5/commit/10223124cc28bcf59773455f3f15cebb40160a40
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: ff182f006abdf949b972db538c8fc2824824fa39
https://github.com/Perl/perl5/commit/ff182f006abdf949b972db538c8fc2824824fa39
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 09a564ee27b2389949f45b4f686c8109fc3d81f1
https://github.com/Perl/perl5/commit/09a564ee27b2389949f45b4f686c8109fc3d81f1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 067856468ec7d6ef0bfcff547ff19923a32021d9
https://github.com/Perl/perl5/commit/067856468ec7d6ef0bfcff547ff19923a32021d9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 4359b01cc76e6db28a025e2991df12d8b3b825d4
https://github.com/Perl/perl5/commit/4359b01cc76e6db28a025e2991df12d8b3b825d4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 9b5387197fe9cbd4782886de1a6fc314bf5021bc
https://github.com/Perl/perl5/commit/9b5387197fe9cbd4782886de1a6fc314bf5021bc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 0e6868b896d7bf0d053e9fb104a6e662648cc279
https://github.com/Perl/perl5/commit/0e6868b896d7bf0d053e9fb104a6e662648cc279
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: cb63f63efbb632f2584087e7ff0da8736c9f524a
https://github.com/Perl/perl5/commit/cb63f63efbb632f2584087e7ff0da8736c9f524a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: c2c6e862409d2701385f9fa3bf9fdc689b9554a9
https://github.com/Perl/perl5/commit/c2c6e862409d2701385f9fa3bf9fdc689b9554a9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 9bcdbcc4547ef47088423acd0480150c2081b7b2
https://github.com/Perl/perl5/commit/9bcdbcc4547ef47088423acd0480150c2081b7b2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: f06b3ee81b6dbf4b8b16ba1972b3431319378f9e
https://github.com/Perl/perl5/commit/f06b3ee81b6dbf4b8b16ba1972b3431319378f9e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 79266416387acc24fa5cae251660c99e46b08677
https://github.com/Perl/perl5/commit/79266416387acc24fa5cae251660c99e46b08677
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: dfe5bc02d7210ad7aec3740e96e20c9eb1099d2d
https://github.com/Perl/perl5/commit/dfe5bc02d7210ad7aec3740e96e20c9eb1099d2d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 5c51f24ea91d03d34c67489f1d0fac496d3b690b
https://github.com/Perl/perl5/commit/5c51f24ea91d03d34c67489f1d0fac496d3b690b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 10f19d56301b7b9c0158c5532caf36a238087e27
https://github.com/Perl/perl5/commit/10f19d56301b7b9c0158c5532caf36a238087e27
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 3696cf11f2f6fb9a13ad135e4628af4026183004
https://github.com/Perl/perl5/commit/3696cf11f2f6fb9a13ad135e4628af4026183004
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 9fc613c6b35017d11cfc0c20fee996d718f30e33
https://github.com/Perl/perl5/commit/9fc613c6b35017d11cfc0c20fee996d718f30e33
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 25fb21e8f455bd3d3e1f38d6526349178502234c
https://github.com/Perl/perl5/commit/25fb21e8f455bd3d3e1f38d6526349178502234c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 3048955e4d7b89c6c8636dc87fbff14e0a9d3412
https://github.com/Perl/perl5/commit/3048955e4d7b89c6c8636dc87fbff14e0a9d3412
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 7005ec070c05146284dc35fa758b449d39e389f5
https://github.com/Perl/perl5/commit/7005ec070c05146284dc35fa758b449d39e389f5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 293d54b2fe23a5faa75b1aaa5f6d4e95d11ba055
https://github.com/Perl/perl5/commit/293d54b2fe23a5faa75b1aaa5f6d4e95d11ba055
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: d9c118b2ce51180979e8a06f810da41942b7d6e2
https://github.com/Perl/perl5/commit/d9c118b2ce51180979e8a06f810da41942b7d6e2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 536695058bc5fa817af24c39c9218c076c9225c1
https://github.com/Perl/perl5/commit/536695058bc5fa817af24c39c9218c076c9225c1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 5ab4721dcbfc512f1708ccaa4e6b0be74f6679c6
https://github.com/Perl/perl5/commit/5ab4721dcbfc512f1708ccaa4e6b0be74f6679c6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 0d8fca04e330f117d418ec2ff687156285c920be
https://github.com/Perl/perl5/commit/0d8fca04e330f117d418ec2ff687156285c920be
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 517cd33a9eb606f194c5cd975df7c9a73e5e8e4a
https://github.com/Perl/perl5/commit/517cd33a9eb606f194c5cd975df7c9a73e5e8e4a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 135d9074f3768575bc464fbfa38db791f0abadfd
https://github.com/Perl/perl5/commit/135d9074f3768575bc464fbfa38db791f0abadfd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: eb0e2b2b6e22d6bc6a572d784dc5042e4fb5678e
https://github.com/Perl/perl5/commit/eb0e2b2b6e22d6bc6a572d784dc5042e4fb5678e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 602c68b3a3554cc30258f215f0281355f2825e41
https://github.com/Perl/perl5/commit/602c68b3a3554cc30258f215f0281355f2825e41
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 3448b7933b3dc55eb0f15375cc296d87679798ea
https://github.com/Perl/perl5/commit/3448b7933b3dc55eb0f15375cc296d87679798ea
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 41d2c9dcc77ecbd642ba10ea0cb8865023d1334f
https://github.com/Perl/perl5/commit/41d2c9dcc77ecbd642ba10ea0cb8865023d1334f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: aebff300e7abd43e9c9d9913ff0a3f487775fbeb
https://github.com/Perl/perl5/commit/aebff300e7abd43e9c9d9913ff0a3f487775fbeb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 062d983b2775a5575e13762ed3a8d937712d4c22
https://github.com/Perl/perl5/commit/062d983b2775a5575e13762ed3a8d937712d4c22
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 710cf5ec9bd22089e4f455c0b976499d9874c7d3
https://github.com/Perl/perl5/commit/710cf5ec9bd22089e4f455c0b976499d9874c7d3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 80fcbddb18497752820fd58b50213ac562a89bcd
https://github.com/Perl/perl5/commit/80fcbddb18497752820fd58b50213ac562a89bcd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: a007c1d771f0e08967695fe6a539c98130b1fe7f
https://github.com/Perl/perl5/commit/a007c1d771f0e08967695fe6a539c98130b1fe7f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 4373ab097d77df70c93bd6b99ac22d26e008d472
https://github.com/Perl/perl5/commit/4373ab097d77df70c93bd6b99ac22d26e008d472
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 392bab1dbf56b1cf29d9ac205fcbbe2c13618b37
https://github.com/Perl/perl5/commit/392bab1dbf56b1cf29d9ac205fcbbe2c13618b37
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c551eaac3a6813ba9f749d5108750ba1ecdadeeb
https://github.com/Perl/perl5/commit/c551eaac3a6813ba9f749d5108750ba1ecdadeeb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: a4245718684b845a97ac32ee0fe846b9689d249f
https://github.com/Perl/perl5/commit/a4245718684b845a97ac32ee0fe846b9689d249f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 4ca13fa5514122bf04b006c25db4a72b424ce7f7
https://github.com/Perl/perl5/commit/4ca13fa5514122bf04b006c25db4a72b424ce7f7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 5bae5d6df6ce35e5d7301a61966fd961278dfb9d
https://github.com/Perl/perl5/commit/5bae5d6df6ce35e5d7301a61966fd961278dfb9d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 9424cc6b8a6f59a7fdf0e1bb4a078250f0dab7dd
https://github.com/Perl/perl5/commit/9424cc6b8a6f59a7fdf0e1bb4a078250f0dab7dd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: c1dca409b0f4253c5995d17a98dc40d8fdc313e0
https://github.com/Perl/perl5/commit/c1dca409b0f4253c5995d17a98dc40d8fdc313e0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: c80e5d4e907c5c55695f3e2a4b915e8881e5faf3
https://github.com/Perl/perl5/commit/c80e5d4e907c5c55695f3e2a4b915e8881e5faf3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 3e1f5da57b7e629a0a91f40d10c169b66c216076
https://github.com/Perl/perl5/commit/3e1f5da57b7e629a0a91f40d10c169b66c216076
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 561b9cc876f723ba5bdc1725cadf041ab20687cc
https://github.com/Perl/perl5/commit/561b9cc876f723ba5bdc1725cadf041ab20687cc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 993648535307a9f49cea02bda211740e93a6b217
https://github.com/Perl/perl5/commit/993648535307a9f49cea02bda211740e93a6b217
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: d3576e86352ab956e44bda07b219e116fb8bc1e5
https://github.com/Perl/perl5/commit/d3576e86352ab956e44bda07b219e116fb8bc1e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 21817d154ed5b74586df631c31ce1cf26f56d716
https://github.com/Perl/perl5/commit/21817d154ed5b74586df631c31ce1cf26f56d716
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 33631248a835ca476bc0008267d3eda28d6f2136
https://github.com/Perl/perl5/commit/33631248a835ca476bc0008267d3eda28d6f2136
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: f2a40c2f03c60e1ea23db40c68e4286c7369b06f
https://github.com/Perl/perl5/commit/f2a40c2f03c60e1ea23db40c68e4286c7369b06f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 45f7782d90e4bf1e5ae6dec43d835d6809de1443
https://github.com/Perl/perl5/commit/45f7782d90e4bf1e5ae6dec43d835d6809de1443
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 7773b1e0aeabeb9f594f5d6528d279d55dccd527
https://github.com/Perl/perl5/commit/7773b1e0aeabeb9f594f5d6528d279d55dccd527
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 7b1a9b74a700f4e27978a34c3247ba3ddb819ec1
https://github.com/Perl/perl5/commit/7b1a9b74a700f4e27978a34c3247ba3ddb819ec1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: ec26aa09c1c834c7c843aad5f0a008febb3ccccf
https://github.com/Perl/perl5/commit/ec26aa09c1c834c7c843aad5f0a008febb3ccccf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 3970f7f53c4389687da3b46e3f6e39a8bbc0d973
https://github.com/Perl/perl5/commit/3970f7f53c4389687da3b46e3f6e39a8bbc0d973
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: ae7feaecebad197703369b4b03f35fe8dbb155a5
https://github.com/Perl/perl5/commit/ae7feaecebad197703369b4b03f35fe8dbb155a5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: f9b02c7a85ef8936d708ebffc9d3fe50f664cb0b
https://github.com/Perl/perl5/commit/f9b02c7a85ef8936d708ebffc9d3fe50f664cb0b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 05fc73a516f3104a4a9c1a0223f57370c0e1fdc9
https://github.com/Perl/perl5/commit/05fc73a516f3104a4a9c1a0223f57370c0e1fdc9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: d66eee8d2d0498885a63439832e7a6e2f7a8795a
https://github.com/Perl/perl5/commit/d66eee8d2d0498885a63439832e7a6e2f7a8795a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 9ee3cb225a9900968c2756dd5bae4bfdca64f3d9
https://github.com/Perl/perl5/commit/9ee3cb225a9900968c2756dd5bae4bfdca64f3d9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: c23b83f9ef3d825d3119c4b7c6e54b08c284e2c7
https://github.com/Perl/perl5/commit/c23b83f9ef3d825d3119c4b7c6e54b08c284e2c7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: dbe17c7f74bd5945ad407e5c9ed9dca8e307a205
https://github.com/Perl/perl5/commit/dbe17c7f74bd5945ad407e5c9ed9dca8e307a205
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 5a75383dcc5f2d08368cf72905c2743886b0f5b0
https://github.com/Perl/perl5/commit/5a75383dcc5f2d08368cf72905c2743886b0f5b0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 8fedc0a0c9c9574042120af03c0030c7480ae958
https://github.com/Perl/perl5/commit/8fedc0a0c9c9574042120af03c0030c7480ae958
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: ff14d1f8f43a7164dcbcd29e522489f67501750a
https://github.com/Perl/perl5/commit/ff14d1f8f43a7164dcbcd29e522489f67501750a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 7ae536a5bf9208fab789c9bbe845860149378cae
https://github.com/Perl/perl5/commit/7ae536a5bf9208fab789c9bbe845860149378cae
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: b7235c7816dab980b43b73822d4e737dc483b848
https://github.com/Perl/perl5/commit/b7235c7816dab980b43b73822d4e737dc483b848
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: da7b1847eff358073ee561029fb9b84b3d3a2b52
https://github.com/Perl/perl5/commit/da7b1847eff358073ee561029fb9b84b3d3a2b52
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 222089e3679b5f9569d9c09993e6995852770def
https://github.com/Perl/perl5/commit/222089e3679b5f9569d9c09993e6995852770def
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 135b4ad9afa1bfb83fe71b9498c42c18f5ebe8b3
https://github.com/Perl/perl5/commit/135b4ad9afa1bfb83fe71b9498c42c18f5ebe8b3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 3bfb5078bc70246a48589ded86585160185452bc
https://github.com/Perl/perl5/commit/3bfb5078bc70246a48589ded86585160185452bc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: e79f7b30ef6bfb130811c5af217b859aa0902c24
https://github.com/Perl/perl5/commit/e79f7b30ef6bfb130811c5af217b859aa0902c24
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 5279818a153985faa238c4c0f15a65fb0b764012
https://github.com/Perl/perl5/commit/5279818a153985faa238c4c0f15a65fb0b764012
Author: Karl Williamson <k...@cpan.org>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more16
Compare: https://github.com/Perl/perl5/compare/6ea4179f6b9b...5279818a1539
