Jürgen Bömmels (via RT) wrote:
# New Ticket Created by Jürgen Bömmels # Please include the string: [perl #18056]
# in the subject line of all future correspondence about this issue. # <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=18056 >
This patch is the beginning of an effort to make PackFile format
extendible. At the moment its combatible with the old bytecode
format.
Looks good to me.
+ cursor += PackFile_Segment_pack (seg, packed, + (cursor-packed)* sizeof(opcode_t), + size) / sizeof (opcode_t);One note WRT *_pack: Could you include the "Interp *interpreter" as first argument to the _pack functions in packout.c, or more flexible, a "void *user_data", which migh be a Parrot_interpreter. So the caller can provide user_data, which might be needed for writing the packfile.
And second, while you are at it, could you provide some PBC versioning, which get checked at packfile load time as discussed in "fingerprinting PBC files".
leo
