At 11:01 PM -0500 3/22/03, Benjamin Goldberg wrote:
"JüRgen BöMmels" wrote:
[snip]
is(<FILE>, <<DATA, 'file content');

Shouldn't this be:


is(scalar <FILE>, <<DATA, 'file content');

(I don't recall whether is() provides scalar context to it's first
argument, but even if it does, it would be clearer to put the 'scalar'
in there anyway.)

[snip]
char buf[1024];
[snip]
len = PIO_read(interpreter, io, buf, sizeof(buf));
[snip]
buf[len] = '\0';

This, almost certainly, should be:


buf[MIN(len, 1023)] = '\0';

No, the PIO_read call should be sizeof(buf)-1. Changed as such, and applied, as soon as the tests finish. -- Dan

--------------------------------------"it's like this"-------------------
Dan Sugalski                          even samurai
[EMAIL PROTECTED]                         have teddy bears and even
                                      teddy bears get drunk

Reply via email to