On Sunday 19 August 2007 17:32:01 Andy Dougherty wrote:

> On Sat, 18 Aug 2007, [EMAIL PROTECTED] wrote:

> > Log:
> > Added FLOAT_IS_ZERO() macro to parrot/misc.h for comparing floats to
> > zero. This may need some attention on platforms where INTVAL isn't four
> > bytes, but I did the best I could.
>
> Stepping back a moment, I don't think this is a good idea.  The original
> code,
>       f == 0.0
> is perfectly clear and quite well-defined.  I think the compiler warning
> should simply be turned off.  It isn't doing anything useful here.

For the zero case or for all floating point comparisons?  If it's not useful 
for the zero case, can we disable it for just that one?

-- c

Reply via email to