From: chromatic <[EMAIL PROTECTED]>
   Date: Fri, 14 Mar 2008 22:51:03 -0700

   As size_t is always positive, the conditional on [src/embed.c] line
   431 can never be true . . .

Sorry; I had intended to do something about this.  Is this TRT?

                                        -- Bob

* src/embed.c:
   + (Parrot_readbc):  Make I/O error check really work.

Diffs between last version checked in and current workfile(s):

Index: src/embed.c
===================================================================
--- src/embed.c (revision 26370)
+++ src/embed.c (working copy)
@@ -428,9 +428,9 @@
             cursor = (char *)program_code + program_size;
         }
 
-        if (read_result < 0) {
-            PIO_eprintf(interp,
-                    "Parrot VM: Problem reading packfile from PIO.\n");
+        if (ferror(io)) {
+            PIO_eprintf(interp, "Parrot VM: Problem reading packfile from PIO: 
 code %d.\n",
+                        ferror(io));
             return NULL;
         }
         fclose(io);

End of diffs.

Reply via email to