# New Ticket Created by  Ron Schmidt 
# Please include the string:  [perl #58484]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=58484 >


Warning occurs when issuing 'perl Configure.pl' under cygwin where the
LANG environment variable does not have a default value on my system.
Patch to fix is included below.

Index: lib/Parrot/Revision.pm
===================================================================
--- lib/Parrot/Revision.pm      (revision 30633)
+++ lib/Parrot/Revision.pm      (working copy)
@@ -80,19 +80,18 @@
}

sub _analyze_sandbox {
+    local %ENV = %ENV;
     my $revision = 0;
     # code taken from pugs/util/version_h.pl rev 14410
     # modified because in xml output commit and entry revision
     # are difficult to distinguih in a simplified parsing
     my $nul = File::Spec->devnull;
-    my $oldLANG = $ENV{LANG};
     $ENV{LANG} = 'C';
     if ( my @svn_info = qx/svn info 2>$nul/ and $? == 0 ) {
         if ( my ($line) = grep /^Revision:/, @svn_info ) {
             ($revision) = $line =~ /(\d+)/;
         }
     }
-    $ENV{LANG} = $oldLANG;
     return $revision;
}


Reply via email to