On Sunday 31 August 2008 14:23:50 Ron Schmidt wrote:

> Warning occurs when issuing 'perl Configure.pl' under cygwin where the
> LANG environment variable does not have a default value on my system.
> Patch to fix is included below.
>
> Index: lib/Parrot/Revision.pm
> ===================================================================
> --- lib/Parrot/Revision.pm      (revision 30633)
> +++ lib/Parrot/Revision.pm      (working copy)
> @@ -80,19 +80,18 @@
> }
>
> sub _analyze_sandbox {
> +    local %ENV = %ENV;
>      my $revision = 0;
>      # code taken from pugs/util/version_h.pl rev 14410
>      # modified because in xml output commit and entry revision
>      # are difficult to distinguih in a simplified parsing
>      my $nul = File::Spec->devnull;
> -    my $oldLANG = $ENV{LANG};
>      $ENV{LANG} = 'C';
>      if ( my @svn_info = qx/svn info 2>$nul/ and $? == 0 ) {
>          if ( my ($line) = grep /^Revision:/, @svn_info ) {
>              ($revision) = $line =~ /(\d+)/;
>          }
>      }
> -    $ENV{LANG} = $oldLANG;
>      return $revision;
> }

That seems reasonable, but how does this work on your system:

        local $ENV{LANG} = 'C';

-- c

Reply via email to