----- Original Message ----- From: "Leopold Toetsch" <[EMAIL PROTECTED]> To: "Jonathan Worthington" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Thursday, February 19, 2004 7:06 PM Subject: Re: [PATCH] Re: [perl #25239] Platform-specific files not granular enough
> Jonathan Worthington <[EMAIL PROTECTED]> wrote: > > > src\exceptions.c > > exceptions.c > > c:\documents and settings\jonathan\desktop\pow\parrot\src\exceptions.c(125) > > : error C2065: 'SIGQUIT' : undeclared identifier > > Seems that dumpcore is used from generic/signal.h > > You could try to create an empty win32/signal.h or insert > > #undef dumpcore > > in a file, that is included after signal.h's code. > Creating an empty signal.h works fine, but then I ran into a load of errors in platform.c. On further inspection, we're coming out with this in platform.c:- -- #include "parrot/parrot.h" /* ** config/gen/platform/win32/begin.c: */ #include <windows.h> -- Somewhere in parrot/parrot.h, something causes winsock.h to be included. I can't for the life of me find *where*, but it is being. The problem with this is that it's being included before windows.h is being included, which means stuff that needs to be defined isn't. I've attached a patch which causes stuff in begin.c to be put before the #include "parrot/parrot.h" line, which fixes up this problem. I don't know if it's the right thing to do, but it's the best one I could think of. Please create the empty signal.h too - BTW, how should I have gone about including that in my patch (e.g. what's the flag for cvs diff)? Thanks, Jonathan
platform.patch
Description: Binary data
