much better! one failing test now... with my inline patch to remove the skip block around test 6.
On 5/19/05, Leopold Toetsch <[EMAIL PROTECTED]> wrote: > Vladimir Lipsky <[EMAIL PROTECTED]> wrote: > > > 1) Why the heck > > Easy: it's not in the MANIFEST. Why: patches scattered between inline > and attached and the MANIFEST part missing ... it's easy to overlook. > > > -# ifdef _MCS_VER1 > > +# ifdef _MCS_VER > > Thanks, applied - hope that's really the whole thing now ;-) almost! :) > leo > test output below: D:\usr\local\parrot-HEAD\trunk>perl t/harness t/pmc/threads.t t/pmc/threads....ok 3/11# Failed test (t/pmc/threads.t at line 163) # got: 'start 1 # in thread # done # Can't spawn ".\parrot.exe "D:\usr\local\parrot-HEAD\trunk\t\pmc\threads_4.pasm"": Bad file descriptor at lib/Parrot/Test.pm line 231. # ' # expected: 'start 1 t/pmc/threads....NOK 4# in thread # done # ' # '.\parrot.exe "D:\usr\local\parrot-HEAD\trunk\t\pmc\threads_4.pasm"' failed with exit code 255 t/pmc/threads....ok 9/11# Looks like you failed 1 tests of 11. t/pmc/threads....dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 4 Failed 1/11 tests, 90.91% okay (less 2 skipped tests: 8 okay, 72.73%) Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/pmc/threads.t 1 256 11 1 9.09% 4 2 subtests skipped. Failed 1/1 test scripts, 0.00% okay. 1/11 subtests failed, 90.91% okay. here's the patch to unskip test 6: D:\usr\local\parrot-HEAD\trunk>svn diff t/pmc/threads.t Index: t/pmc/threads.t =================================================================== --- t/pmc/threads.t (revision 8119) +++ t/pmc/threads.t (working copy) @@ -263,8 +263,6 @@ 500500 OUTPUT -SKIP: { - skip("detach broken on $^O", 1) if ($^O =~ /MSWin32/); output_like(<<'CODE', <<'OUTPUT', "detach"); find_global P5, "_foo" new P2, .ParrotThread @@ -292,7 +290,6 @@ CODE /(done\nthread\n)|(thread\ndone\n)/ OUTPUT -} output_is(<<'CODE', <<'OUTPUT', "share a PMC"); find_global P5, "_foo" ~jerry