Nope it isn't. I debated the fix. Of course the return NULL isn't reachable either so we should remove it too. But that will cause compiler warnings for not having a return value.
My thinking was that, should someone, someday change PANIC into a recoverable error, this will prevent leakage.
Ok its a stretch. :) If we keep the compiler happy, why not keep Coverity happy. Kevin chromatic wrote:
On Sunday 22 July 2007 08:39:17 [EMAIL PROTECTED] wrote:Modified: trunk/ (props changed) trunk/tools/build/nativecall.pl Log: [Coverity] parrot-0.4.13 CID:28 RESOURCE_LEAK - added string_cstring_free(c) to free resouce Modified: trunk/tools/build/nativecall.pl =========================================================================== === --- trunk/tools/build/nativecall.pl (original) +++ trunk/tools/build/nativecall.pl Sun Jul 22 08:39:15 2007 @@ -710,6 +710,7 @@ */ c = string_to_cstring(interp, message); PANIC(interp, c); + string_cstring_free(c); return NULL; }Is that even reachable? -- c
