On Monday 23 July 2007 17:57:29 Kevin Tew wrote: > Nope it isn't. > I debated the fix. > > Of course the return NULL isn't reachable either so we should remove it > too. But that will cause compiler warnings for not having a return value. > > My thinking was that, should someone, someday change PANIC into a > recoverable error, this will prevent leakage. > Ok its a stretch. :) > > If we keep the compiler happy, why not keep Coverity happy.
I'm okay with that, but we should also decorate PANIC with PARROT_DOES_NOT_RETURN, which I believe *should* help compilers. -- c