On 15/10/2007, James E Keenan <[EMAIL PROTECTED]> wrote: > Paul Cochrane via RT wrote: > > On Sun Jul 08 15:09:19 2007, ptc wrote: > >> At present we have to specify warnings flags for each version of gcc > >> (see config/auto/gcc.pm). This is a pain. Perl 5 is able to work out > >> automatically the warnings flags of gcc and then use those for > >> compilation. Parrot should do this too. > > > > Automatic detection of gcc warnings has been implemented for a while > > now, just not switched on by default. The code is in config/auto/ > > warnings.pm and I added it to trunk in r21522. This greatly reduces > > the burden on warnings flag maintenance. Anyway, I'd like the code to > > be on by default and to rip the old stuff out. Can I? Huh? Huh? > > Please? > > > > Paul > > ptc, Thanks for being persistent with this. I have a few questions: > > 1. Where would it be placed in the list of configuration steps found in > lib/Parrot/Configure/Step/List.pm?
Just after the attribute sniffing code, i.e. add an entry auto::warnings just after auto::attributes. > 2. In http://rt.perl.org/rt3/Ticket/Display.html?id=46373, I propose a > change in Parrot::Configure::Step::Base which affects the individual > configuration step classes. Can we adapt this class for that as well? > Plan is for this patch also to be applied after the release. I believe that is already implemented in auto::warnings.pm > 3. Can you supply at least a skeleton of a test file for this step? > (See tests for other 'auto' steps in the reconfigure/ branch; these will > soon be ported to trunk.) I'm going to keep playing with the test I've written so far and try and get it working properly. This way I'll learn a bit more, and be able to add a test for the attribute sniffing code as well. > 4. Can you answer the question I posed in my July 8 response to your > original post? Ok. Just managed to get some tuits, so am working through stuff now. Paul
