On Wednesday 30 July 2008 11:20:33 Andy Dougherty wrote:
> Ahh -- it's just an octal/decimal mix-up. Here's the patch:
>
> --- parrot-current/t/steps/auto_icu-01.t 2008-07-30 13:45:19.000000000
> -0400 +++ parrot-andy/t/steps/auto_icu-01.t 2008-07-30 14:15:44.000000000
> -0400 @@ -228,7 +228,7 @@
> my $expected_include_dir =
> $expected_dir . $conf->data->get('slash') . q{include};
> mkdir $expected_dir or croak "Unable to make testing directory";
> - mkpath($expected_include_dir, 0, 755)
> + mkpath($expected_include_dir, 0, 0755)
> or croak "Unable to make second-level testing directory";
> ($icuheaders, $without) =
> $step->_handle_icuheaders($conf, qq{$expected_dir\n}, 0);
>
>
> Mind you, the directories still aren't cleaned up automatically, but this
> at least makes that less tedious.
Good catch. Does this revision of the patch perform the cleanup
appropriately?
-- c
=== t/steps/auto_icu-01.t
==================================================================
--- t/steps/auto_icu-01.t (revision 29906)
+++ t/steps/auto_icu-01.t (local)
@@ -1,5 +1,5 @@
#! perl
-# Copyright (C) 2007, The Perl Foundation.
+# Copyright (C) 2007-2008, The Perl Foundation.
# $Id$
# auto_icu-01.t
@@ -222,13 +222,13 @@
}
{
- my $tdir = tempdir();
+ my $tdir = tempdir( CLEANUP => 1);
chdir $tdir or croak "Unable to change to temporary directory";
my $expected_dir = q{alpha};
my $expected_include_dir =
$expected_dir . $conf->data->get('slash') . q{include};
mkdir $expected_dir or croak "Unable to make testing directory";
- mkpath($expected_include_dir, 0, 755)
+ mkpath($expected_include_dir, 0, 0755)
or croak "Unable to make second-level testing directory";
($icuheaders, $without) =
$step->_handle_icuheaders($conf, qq{$expected_dir\n}, 0);
