On Mon, Aug 4, 2008 at 2:59 AM, Christoph Otto <[EMAIL PROTECTED]> wrote: > Will Coleda (via RT) wrote: >> >> # New Ticket Created by Will Coleda # Please include the string: [perl >> #57468] >> # in the subject line of all future correspondence about this issue. # >> <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=57468 > >> >> >> There's an ifdef in misc.c to allow us to conditionally use vnsnprintf. >> >> If we're going to keep the conditional, we need to provide a config >> probe for it (and rename to something like PARROT_HAS_VNSNPRINTF) >> >> Otherwise, we should delete the conditional. >> >> $ ack -a BLAHBLAHBLAH >> src/misc.c >> 249:#ifdef BLAHBLAHBLAH_WAS_A_CHECK_FOR_VNSNPRINTF >> $ svn blame src/misc.c | ack BLAHBLAHBLAH >> 25545 petdance #ifdef BLAHBLAHBLAH_WAS_A_CHECK_FOR_VNSNPRINTF >> > > vnsnprintf here appears be a typo of vsnprintf. There are a couple > references to it that Google finds, but they appear to be typos too. > > The attached patch adds a configure step for vsnprintf based heavily on the > one for snprintf. make test passes, but the only function that uses > vsnprintf (Parrot_secret_snprintf) doesn't appear to have any test coverage. > > The patch should be simple enough to be obviously correct, but I'd like a +1 > from someone just to be on the safe side. > > Christoph >
As I mentioned on IRC, I'd recommend just removing it instead of adding another probe we're not sure we need. We can always come back to this ticket and grab your patch for later application if it we need to. -- Will "Coke" Coleda
