-----Original Message----- From: [email protected]

And there's still the question of what on earth Filter::Simple is doing to
MatrixOps.pm on 5.12 and earlier.

Attached is a patch to Basic/MatrixOps/matrixops.pd that fixes the problem with 5.12 and earlier. I don't know why those changes are necessary for the older perls, as 'use PDL::NiceSlice;' has already been done earlier in the generated MatrixOps.pm.

Now that I can build on 5.12, I find similar test errors with:

t/transform.t ............... syntax error at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3073, near "$p(" syntax error at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3074, near "$p(" syntax error at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3086, near "$p(" syntax error at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3090, near "0:" syntax error at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3107, near "0:" syntax error at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3115, near "0:" BEGIN not safe after errors--compilation aborted at C:\sisyphusion\PDL-2.4.11_006\blib\lib/PDL/Transform.pm line 3137.
Compilation failed in require at t/transform.t line 8.
BEGIN failed--compilation aborted at t/transform.t line 8.

Seems that can be fixed by the attached patch to Lib/Transform/transform.pd. (I also don't know why that additional instance of 'use PDL::NiceSlice;' is needed.)

I still need to double check these changes by rebuilding _006 on all perls - which won't happen until tomorrow night. Maybe someone sees fixes that are more appropriate than the ones I've come up with ?

Cheers,
Rob
--- matrixops.pd_orig   2013-01-31 19:27:42 +1100
+++ matrixops.pd        2013-01-31 19:23:19 +1100
@@ -410,6 +410,7 @@

*PDL::determinant = \&determinant;
sub determinant {
+  use PDL::NiceSlice;
  my($a) = shift;
  my($n);
  return undef unless(
@@ -1059,6 +1060,7 @@
*PDL::lu_decomp2 = \&lu_decomp2;

sub lu_decomp2 {
+  use PDL::NiceSlice;
  my($in) = shift;
  my($perm) = shift;
  my($par) = shift;
--- transform.pd_orig   2013-01-31 19:55:49 +1100
+++ transform.pd        2013-01-31 19:56:23 +1100
@@ -3691,6 +3691,7 @@
=cut

sub t_projective {
+  use PDL::NiceSlice;
  my($class) = 'PDL::Transform';
  my($o) = $_[0];
  if(ref $o ne 'HASH') {
_______________________________________________
Perldl mailing list
[email protected]
http://mailman.jach.hawaii.edu/mailman/listinfo/perldl

Reply via email to