Nice! I was going through perl-side contortions to determine the correct type when the PDL_CORE_VERSION info was exactly what was needed for C/PP code. Very elegant...
--Chris On Sat, Nov 9, 2013 at 11:03 PM, <[email protected]> wrote: > > > -----Original Message----- From: Chris Marshall > Sent: Sunday, November 10, 2013 12:25 PM > To: Sisyphus > Cc: Christopher Meng ; Doug Hunt ; [email protected] > > Subject: Re: [Perldl] Some updates of PDL-Graphics-PLplot? > >> Great! The only catch is that for PDL versions before 2.007, >> PDL_Indx doesn't exist so that case needs to be handled. > > > Yes, I was wearing my "package manager" blinkers. > > For portability, I think something like: > > --- plplot.pd_orig 2013-11-10 11:14:30 +1100 > +++ plplot.pd 2013-11-10 14:27:53 +1100 > @@ -3813,7 +3813,11 @@ > > pdl *x_pdl, *y_pdl; > PLFLT *tx, *ty; > SV *x_sv, *y_sv; > +#if defined(PDL_CORE_VERSION) && PDL_CORE_VERSION >= 10 > + PDL_Indx dims, i; > +#else > int dims, i; > +#endif > I32 count, ax; > dSP; > > Although that's not very pretty. > It could be made slightly more appealing if (as I suspect) we don't need to > check that PDL_CORE_VERSION is defined. > > Cheers, > Rob _______________________________________________ Perldl mailing list [email protected] http://mailman.jach.hawaii.edu/mailman/listinfo/perldl
